uring_cmd copy avoidance
Jens Axboe
maintainerv2 cover uring_cmd copy avoidance
Hi,
Currently uring_cmd unconditionally copies the SQE at prep time, as it has no other choice - the SQE data must remain stable after submit. This can lead to excessive memory bandwidth being used for that copy, as passthrough will often use 128b SQEs, and efficiency concerns as those copies will potentially use quite a lot of CPU cycles as well.
As a quick test, running the current -git kernel on a box with 23 NVMe drives doing passthrough IO, memcpy() is the highest cycle user at 9.05%, which is all off the uring_cmd prep path. The test case is a 512b random read, which runs at 91-92M IOPS.
With these patches, memcpy() is gone from the profiles, and it runs at 98-99M IOPS, or about 7-8% faster.
Before:
IOPS=91.12M, BW=44.49GiB/s, IOS/call=32/32
IOPS=91.16M, BW=44.51GiB/s, IOS/call=32/32
IOPS=91.18M, BW=44.52GiB/s, IOS/call=31/32
IOPS=91.92M, BW=44.88GiB/s, IOS/call=32/32
IOPS=91.88M, BW=44.86GiB/s, IOS/call=32/32
IOPS=91.82M, BW=44.83GiB/s, IOS/call=32/31
IOPS=91.52M, BW=44.69GiB/s, IOS/call=32/32
with the top perf report -g --no-children being:
+ 9.07% io_uring [kernel.kallsyms] [k] memcpy
and after:
# bash run-peak-pass.sh [...] IOPS=99.30M, BW=48.49GiB/s, IOS/call=32/32 IOPS=99.27M, BW=48.47GiB/s, IOS/call=31/32 IOPS=99.60M, BW=48.63GiB/s, IOS/call=32/32 IOPS=99.68M, BW=48.67GiB/s, IOS/call=32/31 IOPS=99.80M, BW=48.73GiB/s, IOS/call=31/32 IOPS=99.84M, BW=48.75GiB/s, IOS/call=32/32
with memcpy not even in profiles. If you do the actual math of 100M requests per second, and 128b of copying per IOP, then it's almost 12GB/sec of reduced memory bandwidth.
Even for lower IOPS production testing, Caleb reports that memcpy() overhead is in the realm of 1.1% of CPU time.
v2 of this patchset takes a different approach than v1 did - rather than have the core mark a request as being potentially issued out-of-line, this one adds an io_cold_def ->sqe_copy() helper, and puts the onus on io_uring core to call it appropriately. Outside of that, it also adds an IO_URING_F_INLINE flag so that the copy helper _knows_ if it may sanely copy the SQE, or whether there's a bug in the core and it should just be ended with -EFAULT. Where possible, the actual SQE is also passed in.
I think this approach is saner, and in fact it can be extended to reduce over-eager copies in other spots. For now I just did uring_cmd, and verified that the memcpy's are still gone from my test.
Can also be found here:
https://git.kernel.dk/cgit/linux/log/?h=uring_cmd.2
include/linux/io_uring_types.h | 2 ++ io_uring/io_uring.c | 35 +++++++++++++++------ io_uring/opdef.c | 1 + io_uring/opdef.h | 1 + io_uring/uring_cmd.c | 57 ++++++++++++++++++---------------- io_uring/uring_cmd.h | 2 ++ 6 files changed, 63 insertions(+), 35 deletions(-)
Signature · 1 line
Jens Axboe
Jens Axboe
maintainerPATCH v2 1/4 io_uring: add IO_URING_F_INLINE issue flag
Set when the execution of the request is done inline from the system call itself. Any deferred issue will never have this flag set.
--- include/linux/io_uring_types.h | 2 ++ io_uring/io_uring.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-)
include/linux/io_uring_types.h +2 -0
@@ -26,6 +26,8 @@ enum io_uring_cmd_flags {IO_URING_F_MULTISHOT =4 ,/* executed by io-wq */ IO_URING_F_IOWQ =8 , +/* executed inline from syscall */ +IO_URING_F_INLINE =16 ,/* int's last bit, sign checks are usually faster than a bit test */ IO_URING_F_NONBLOCK = INT_MIN,
io_uring/io_uring.c +2 -1
@@ -1962,7 +1962,8 @@ static inline void io_queue_sqe(struct io_kiocb *req) {int ret; - ret =io_issue_sqe (req,IO_URING_F_NONBLOCK |IO_URING_F_COMPLETE_DEFER ); + ret =io_issue_sqe (req,IO_URING_F_NONBLOCK |IO_URING_F_COMPLETE_DEFER | +IO_URING_F_INLINE );/* * We async punt it if the file wasn't marked NOWAIT, or if the file
Signature · 1 line
2.49.0
Re: [PATCH 1/4] io_uring: add IO_URING_F_INLINE issue flag
Quoted 28 lines · Jens Axboe
Set when the execution of the request is done inline from the system call itself. Any deferred issue will never have this flag set.
Signed-off-by Jens Axboe <[email protected]>--- include/linux/io_uring_types.h | 2 ++ io_uring/io_uring.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-)include/linux/io_uring_types.h +2
-0@@ -26,6 +26,8 @@ enum io_uring_cmd_flags {IO_URING_F_MULTISHOT =4 ,/* executed by io-wq */ IO_URING_F_IOWQ =8 , +/* executed inline from syscall */ +IO_URING_F_INLINE =16 ,/* int's last bit, sign checks are usually faster than a bit test */ IO_URING_F_NONBLOCK = INT_MIN,io_uring/io_uring.c +0
-0
io_uring/io_uring.c static inline void io_queue_sqe(struct io_kiocb *req) · line 1966
Quoted 6 lines
io_uring/io_uring.c +2
-1@@ -1962,7 +1962,8 @@ static inline void io_queue_sqe(struct io_kiocb *req) {int ret; - ret =io_issue_sqe (req,IO_URING_F_NONBLOCK |IO_URING_F_COMPLETE_DEFER ); + ret =io_issue_sqe (req,IO_URING_F_NONBLOCK |IO_URING_F_COMPLETE_DEFER | +IO_URING_F_INLINE );
Isn't io_queue_sqe() also called from io_req_task_submit(), which is an io_req_tw_func_t callback? Task work runs after the SQ slots have already been returned to userspace, right? Before the unconditional memcpy() was added, we had observed requests in linked chains with corrupted SQEs due to the async task work issue.
As is, it looks like IO_URING_F_INLINE is just the inverse of IO_URING_F_IOWQ, so it may not be necessary to add a new flag. But I can see how core io_uring might add additional async issue cases in the future.
Best,
Caleb
Quoted 6 lines
io_uring/io_uring.c +0
-1/* * We async punt it if the file wasn't marked NOWAIT, or if the file -- 2.49.0
Jens Axboe
maintainerRe: [PATCH 1/4] io_uring: add IO_URING_F_INLINE issue flag
Quoted 32 lines · Caleb Sander Mateos
Quoted 31 lines · On Thu, Jun 5, 2025 at 12:47?PM Jens Axboe <[email protected]> wrote:
Set when the execution of the request is done inline from the system call itself. Any deferred issue will never have this flag set.
Signed-off-by Jens Axboe <[email protected]>--- include/linux/io_uring_types.h | 2 ++ io_uring/io_uring.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-)include/linux/io_uring_types.h +2
-0@@ -26,6 +26,8 @@ enum io_uring_cmd_flags {IO_URING_F_MULTISHOT =4 ,/* executed by io-wq */ IO_URING_F_IOWQ =8 , +/* executed inline from syscall */ +IO_URING_F_INLINE =16 ,/* int's last bit, sign checks are usually faster than a bit test */ IO_URING_F_NONBLOCK = INT_MIN,io_uring/io_uring.c +0
-0@@ -1962,7 +1962,8 @@ static inline void io_queue_sqe(struct io_kiocb *req) {int ret;
Quoted 9 lines
io_uring/io_uring.c static inline void io_queue_sqe(struct io_kiocb *req) · line 1966
Quoted 3 lines
io_uring/io_uring.c +2
-1- ret =io_issue_sqe (req,IO_URING_F_NONBLOCK |IO_URING_F_COMPLETE_DEFER ); + ret =io_issue_sqe (req,IO_URING_F_NONBLOCK |IO_URING_F_COMPLETE_DEFER | +IO_URING_F_INLINE );Isn't
io_queue_sqe()also called fromio_req_task_submit(), which is anio_req_tw_func_tcallback? Task work runs after the SQ slots have already been returned to userspace, right? Before the unconditionalmemcpy()was added, we had observed requests in linked chains with corrupted SQEs due to the async task work issue.
It's really just a patch ordering issue, as per the other email.
Quoted 4 lines
As is, it looks like
IO_URING_F_INLINEis just the inverse ofIO_URING_F_IOWQ, so it may not be necessary to add a new flag. But I can see how coreio_uringmight add additional async issue cases in the future.
I'd greatly prefer a separate flag, it's more robust than tying it to some other flag.
Signature · 1 line
Jens Axboe
Jens Axboe
maintainerPATCH v2 2/4 io_uring: add struct io_cold_def->sqe_copy() method
In reply to Jens AxboeWill be called by the core of io_uring, if inline issue is not going to be tried for a request. Opcodes can define this handler to defer copying of SQE data that should remain stable.
Called with IO_URING_F_INLINE set if this is an inline issue, and that flag NOT set if it's an out-of-line call. The handler can use this to determine if it's still safe to copy the SQE. The core should always guarantee that it will be safe, but by having this flag available the handler is able to check and fail.
--- io_uring/io_uring.c | 32 ++++++++++++++++++++++++-------- io_uring/opdef.h | 1 + 2 files changed, 25 insertions(+), 8 deletions(-)
io_uring/io_uring.c +24 -8
@@ -147,7 +147,7 @@ static bool io_uring_try_cancel_requests(struct io_ring_ctx *ctx,bool cancel_all, bool is_sqpoll_thread); -static void io_queue_sqe (struct io_kiocb *req); +static void io_queue_sqe (struct io_kiocb *req,const struct io_uring_sqe *sqe);static void __io_req_caches_free (struct io_ring_ctx *ctx);static __read_mostly DEFINE_STATIC_KEY_FALSE (io_key_has_sqarray);
@@ -1377,7 +1377,7 @@ void io_req_task_submit(struct io_kiocb *req, io_tw_token_t tw)else if (req->flags &REQ_F_FORCE_ASYNC )io_queue_iowq (req);else -io_queue_sqe (req); +io_queue_sqe (req,NULL ); }void io_req_task_queue_fail (struct io_kiocb *req,int ret)
@@ -1935,14 +1935,30 @@ struct file *io_file_get_normal(struct io_kiocb *req, int fd)return file; } -static void io_queue_async (struct io_kiocb *req,int ret) +static int io_req_sqe_copy (struct io_kiocb *req,const struct io_uring_sqe *sqe, +unsigned int issue_flags) +{ +const struct io_cold_def *def = &io_cold_defs[req->opcode]; + +if (!def->sqe_copy) +return 0 ; +return def->sqe_copy (req, sqe, issue_flags); +} + +static void io_queue_async (struct io_kiocb *req,const struct io_uring_sqe *sqe, +int ret) __must_hold(&req->ctx->uring_lock) {if (ret != -EAGAIN || (req->flags &REQ_F_NOWAIT )) { +fail:io_req_defer_failed (req, ret);return ; } + ret =io_req_sqe_copy (req, sqe,0 ); +if (unlikely (ret)) + goto fail; +switch (io_arm_poll_handler (req,0 )) {case IO_APOLL_READY :io_kbuf_recycle (req,0 );
@@ -1957,7 +1973,7 @@ static void io_queue_async(struct io_kiocb *req, int ret) } } -static inline void io_queue_sqe (struct io_kiocb *req) +static inline void io_queue_sqe (struct io_kiocb *req,const struct io_uring_sqe *sqe) __must_hold(&req->ctx->uring_lock) {int ret;
@@ -1970,7 +1986,7 @@ static inline void io_queue_sqe(struct io_kiocb *req)* doesn't support non-blocking read/write attempts */ if (unlikely (ret)) -io_queue_async (req, ret); +io_queue_async (req, sqe, ret); }static void io_queue_sqe_fallback (struct io_kiocb *req)
@@ -2200,7 +2216,7 @@ static inline int io_submit_sqe(struct io_ring_ctx *ctx, struct io_kiocb *req, link->last = req;if (req->flags &IO_REQ_LINK_FLAGS ) -return 0 ; +return io_req_sqe_copy (req, sqe,IO_URING_F_INLINE );/* last request of the link, flush it */ req = link->head; link->head =NULL ;
@@ -2216,10 +2232,10 @@ static inline int io_submit_sqe(struct io_ring_ctx *ctx, struct io_kiocb *req, fallback:io_queue_sqe_fallback (req); } -return 0 ; +return io_req_sqe_copy (req, sqe,IO_URING_F_INLINE ); } -io_queue_sqe (req); +io_queue_sqe (req, sqe);return 0 ; }
io_uring/opdef.h +1 -0
@@ -38,6 +38,7 @@ struct io_issue_def {struct io_cold_def {const char *name; +int (*sqe_copy)(struct io_kiocb *,const struct io_uring_sqe *,unsigned int issue_flags);void (*cleanup)(struct io_kiocb *);void (*fail)(struct io_kiocb *); };
Signature · 1 line
2.49.0
Jens Axboe
maintainerRe: [PATCH 2/4] io_uring: add struct io_cold_def->sqe_copy() method
Ran all test cases and found that...
Quoted 4 lines
io_uring/io_uring.c +2
-0+static void io_queue_async (struct io_kiocb *req,const struct io_uring_sqe *sqe, +int ret) __must_hold(&req->ctx->uring_lock) {
io_uring/io_uring.c struct file *io_file_get_normal(struct io_kiocb *req, int fd) · line 1961
Quoted 10 lines
io_uring/io_uring.c +5
-0if (ret != -EAGAIN || (req->flags &REQ_F_NOWAIT )) { +fail:io_req_defer_failed (req, ret);return ; } + ret =io_req_sqe_copy (req, sqe,0 ); +if (unlikely (ret)) + goto fail; +
we of course need to pass 'issue_flags' from io_queue_sqe() here, otherwise we risk breaking the sanity checks in uring_cmd later on.
The git branch referenced in the cover letter has been updated.
Signature · 1 line
Jens Axboe
Re: [PATCH 2/4] io_uring: add struct io_cold_def->sqe_copy() method
In reply to Jens AxboeQuoted 31 lines · Jens Axboe
Will be called by the core of
io_uring, if inline issue is not going to be tried for a request. Opcodes can define this handler to defer copying of SQE data that should remain stable.Called with
IO_URING_F_INLINEset if this is an inline issue, and that flag NOT set if it's an out-of-line call. The handler can use this to determine if it's still safe to copy the SQE. The core should always guarantee that it will be safe, but by having this flag available the handler is able to check and fail.Signed-off-by Jens Axboe <[email protected]>--- io_uring/io_uring.c | 32 ++++++++++++++++++++++++-------- io_uring/opdef.h | 1 + 2 files changed, 25 insertions(+), 8 deletions(-)io_uring/io_uring.c +1
-1@@ -147,7 +147,7 @@ static bool io_uring_try_cancel_requests(struct io_ring_ctx *ctx,bool cancel_all, bool is_sqpoll_thread); -static void io_queue_sqe (struct io_kiocb *req); +static void io_queue_sqe (struct io_kiocb *req,const struct io_uring_sqe *sqe);static void __io_req_caches_free (struct io_ring_ctx *ctx);static __read_mostly DEFINE_STATIC_KEY_FALSE (io_key_has_sqarray);
io_uring/io_uring.c void io_req_task_submit(struct io_kiocb *req, io_tw_token_t tw) · line 1380
Quoted 5 lines
io_uring/io_uring.c +1
-1@@ -1377,7 +1377,7 @@ void io_req_task_submit(struct io_kiocb *req, io_tw_token_t tw)else if (req->flags &REQ_F_FORCE_ASYNC )io_queue_iowq (req);else -io_queue_sqe (req); +io_queue_sqe (req,NULL );
Passing NULL here is a bit weird. As I mentioned on patch 1, I think it would make more sense to consider this task work path a "non-inline" issue.
Quoted 21 lines
io_uring/io_uring.c +12
-1}void io_req_task_queue_fail (struct io_kiocb *req,int ret)@@ -1935,14 +1935,30 @@ struct file *io_file_get_normal(struct io_kiocb *req, int fd)return file; } -static void io_queue_async(struct io_kiocb *req, int ret) +static int io_req_sqe_copy (struct io_kiocb *req,const struct io_uring_sqe *sqe, +unsigned int issue_flags) +{ +const struct io_cold_def *def = &io_cold_defs[req->opcode]; + +if (!def->sqe_copy) +return 0 ; +return def->sqe_copy (req, sqe, issue_flags); +} + +static void io_queue_async(struct io_kiocb *req, const struct io_uring_sqe *sqe, + int ret) __must_hold(&req->ctx->uring_lock)
io_uring/io_uring.c struct file *io_file_get_normal(struct io_kiocb *req, int fd) · line 1960
Quoted 10 lines
io_uring/io_uring.c +4
-0{if (ret != -EAGAIN || (req->flags &REQ_F_NOWAIT )) { +fail:io_req_defer_failed (req, ret);return ; } + ret =io_req_sqe_copy (req, sqe,0 ); +if (unlikely (ret)) + goto fail;
It seems possible to avoid the goto by just adding "|| unlikely(ret = io_req_sqe_copy(req, sqe, 0))" to the if condition above. But the control flow isn't super convoluted with the goto, so I don't feel strongly.
Quoted 23 lines
io_uring/io_uring.c +3
-2+switch (io_arm_poll_handler (req,0 )) {case IO_APOLL_READY :io_kbuf_recycle (req,0 );@@ -1957,7 +1973,7 @@ static void io_queue_async(struct io_kiocb *req, int ret) } } -static inline void io_queue_sqe (struct io_kiocb *req) +static inline void io_queue_sqe (struct io_kiocb *req,const struct io_uring_sqe *sqe) __must_hold(&req->ctx->uring_lock) {int ret;@@ -1970,7 +1986,7 @@ static inline void io_queue_sqe(struct io_kiocb *req)* doesn't support non-blocking read/write attempts */ if (unlikely (ret)) -io_queue_async (req, ret); +io_queue_async (req, sqe, ret); }static void io_queue_sqe_fallback (struct io_kiocb *req)
io_uring/io_uring.c static inline int io_submit_sqe(struct io_ring_ctx *ctx, struct io_kiocb *req, · line 2219
Quoted 5 lines
io_uring/io_uring.c +1
-1@@ -2200,7 +2216,7 @@ static inline int io_submit_sqe(struct io_ring_ctx *ctx, struct io_kiocb *req, link->last = req;if (req->flags &IO_REQ_LINK_FLAGS ) -return 0 ; +return io_req_sqe_copy (req, sqe,IO_URING_F_INLINE );
This only copies the SQE for the middle reqs in a linked chain. Don't we need to copy it for the last req too? I would call io_req_sqe_copy() unconditionally before the req->flags & IO_REQ_LINK_FLAGS check.
io_uring/io_uring.c static inline int io_submit_sqe(struct io_ring_ctx *ctx, struct io_kiocb *req, · line 2235
Quoted 9 lines
io_uring/io_uring.c +1
-1/* last request of the link, flush it */ req = link->head; link->head =NULL ;@@ -2216,10 +2232,10 @@ static inline int io_submit_sqe(struct io_ring_ctx *ctx, struct io_kiocb *req, fallback:io_queue_sqe_fallback (req); } -return 0 ; +return io_req_sqe_copy (req, sqe,IO_URING_F_INLINE );
The first req in a linked chain hits this code path too, but it doesn't usually need its SQE copied since it will still be issued synchronously by default. (The io_queue_sqe_fallback() to handle unterminated links in io_submit_state_end() might be an exception.) But I am fine with copying the SQE for the first req too if it keeps the code simpler. If the first req in a chain also has REQ_F_FORCE_ASYNC | REQ_F_FAIL set, it will actually reach this io_req_sqe_copy() twice (the second time from the goto fallback path). I think the io_req_sqe_copy() can just move into the fallback block?
Quoted 12 lines
io_uring/io_uring.c +1
-1} -io_queue_sqe (req); +io_queue_sqe (req, sqe);return 0 ; }io_uring/opdef.h +0
-0
io_uring/opdef.h struct io_issue_def { · line 41
Quoted 4 lines
io_uring/opdef.h +1
-0@@ -38,6 +38,7 @@ struct io_issue_def {struct io_cold_def {const char *name; +int (*sqe_copy)(struct io_kiocb *,const struct io_uring_sqe *,unsigned int issue_flags);
nit: this line is a tad long
Best,
Caleb
Quoted 6 lines
io_uring/opdef.h +0
-1void (*cleanup)(struct io_kiocb *);void (*fail)(struct io_kiocb *); }; --2.49.0
Jens Axboe
maintainerRe: [PATCH 2/4] io_uring: add struct io_cold_def->sqe_copy() method
Quoted 30 lines · Caleb Sander Mateos
Quoted 29 lines · On Thu, Jun 5, 2025 at 12:47?PM Jens Axboe <[email protected]> wrote:
Will be called by the core of
io_uring, if inline issue is not going to be tried for a request. Opcodes can define this handler to defer copying of SQE data that should remain stable.Called with
IO_URING_F_INLINEset if this is an inline issue, and that flag NOT set if it's an out-of-line call. The handler can use this to determine if it's still safe to copy the SQE. The core should always guarantee that it will be safe, but by having this flag available the handler is able to check and fail.Signed-off-by Jens Axboe <[email protected]>--- io_uring/io_uring.c | 32 ++++++++++++++++++++++++-------- io_uring/opdef.h | 1 + 2 files changed, 25 insertions(+), 8 deletions(-)io_uring/io_uring.c +1
-1@@ -147,7 +147,7 @@ static bool io_uring_try_cancel_requests(struct io_ring_ctx *ctx,bool cancel_all, bool is_sqpoll_thread); -static void io_queue_sqe (struct io_kiocb *req); +static void io_queue_sqe (struct io_kiocb *req,const struct io_uring_sqe *sqe);static void __io_req_caches_free (struct io_ring_ctx *ctx);
Quoted 11 lines
io_uring/io_uring.c void io_req_task_submit(struct io_kiocb *req, io_tw_token_t tw) · line 1380
Quoted 7 lines
io_uring/io_uring.c +1
-1static __read_mostly DEFINE_STATIC_KEY_FALSE (io_key_has_sqarray);@@ -1377,7 +1377,7 @@ void io_req_task_submit(struct io_kiocb *req, io_tw_token_t tw)else if (req->flags &REQ_F_FORCE_ASYNC )io_queue_iowq (req);else -io_queue_sqe (req); +io_queue_sqe (req,NULL );Passing NULL here is a bit weird. As I mentioned on patch 1, I think it would make more sense to consider this task work path a "non-inline" issue.
It very much _is_ a non-inline issue, the sqe being NULL is how the ->sqe_copy() would treat it. But it is a bit confusing in that the callback would need to check
if (!sqe || !(flags & INLINE))
as the condition for whether or not the sqe is valid. Probably better to make the INLINE flag dependent on sqe != NULL as well, and then that's all the callback would need to check for.
Signature · 1 line
Jens Axboe
Jens Axboe
maintainerPATCH v2 3/4 io_uring/uring_cmd: get rid of io_uring_cmd_prep_setup()
In reply to Jens AxboeIt's a pretty pointless helper, just allocates and copies data. Fold it into io_uring_cmd_prep().
--- io_uring/uring_cmd.c | 34 +++++++++++++--------------------- 1 file changed, 13 insertions(+), 21 deletions(-)
io_uring/uring_cmd.c +13 -21
@@ -181,8 +181,7 @@ void io_uring_cmd_done(struct io_uring_cmd *ioucmd, ssize_t ret, u64 res2, }EXPORT_SYMBOL_GPL (io_uring_cmd_done); -static int io_uring_cmd_prep_setup (struct io_kiocb *req, -const struct io_uring_sqe *sqe) +int io_uring_cmd_prep (struct io_kiocb *req,const struct io_uring_sqe *sqe) { struct io_uring_cmd *ioucmd = io_kiocb_to_cmd(req, struct io_uring_cmd);struct io_async_cmd *ac;
@@ -190,6 +189,18 @@ static int io_uring_cmd_prep_setup(struct io_kiocb *req,/* see io_uring_cmd_get_async_data() */ BUILD_BUG_ON (offsetof(struct io_async_cmd , data) !=0 ); +if (sqe->__pad1) +return -EINVAL ; + + ioucmd->flags =READ_ONCE (sqe->uring_cmd_flags); +if (ioucmd->flags & ~IORING_URING_CMD_MASK ) +return -EINVAL ; + +if (ioucmd->flags &IORING_URING_CMD_FIXED ) + req->buf_index =READ_ONCE (sqe->buf_index); + + ioucmd->cmd_op =READ_ONCE (sqe->cmd_op); + ac =io_uring_alloc_async_data (&req->ctx->cmd_cache, req);if (!ac)return -ENOMEM ;
@@ -207,25 +218,6 @@ static int io_uring_cmd_prep_setup(struct io_kiocb *req,return 0 ; } -int io_uring_cmd_prep (struct io_kiocb *req,const struct io_uring_sqe *sqe) -{ - struct io_uring_cmd *ioucmd = io_kiocb_to_cmd(req, struct io_uring_cmd); - -if (sqe->__pad1) -return -EINVAL ; - - ioucmd->flags =READ_ONCE (sqe->uring_cmd_flags); -if (ioucmd->flags & ~IORING_URING_CMD_MASK ) -return -EINVAL ; - -if (ioucmd->flags &IORING_URING_CMD_FIXED ) - req->buf_index =READ_ONCE (sqe->buf_index); - - ioucmd->cmd_op =READ_ONCE (sqe->cmd_op); - -return io_uring_cmd_prep_setup (req, sqe); -} -int io_uring_cmd (struct io_kiocb *req,unsigned int issue_flags) { struct io_uring_cmd *ioucmd = io_kiocb_to_cmd(req, struct io_uring_cmd);
Signature · 1 line
2.49.0
Re: [PATCH 3/4] io_uring/uring_cmd: get rid of io_uring_cmd_prep_setup()
Quoted 5 lines · Jens Axboe
It's a pretty pointless helper, just allocates and copies data. Fold it into
io_uring_cmd_prep().Signed-off-by Jens Axboe <[email protected]>
Jens Axboe
maintainerPATCH v2 4/4 io_uring/uring_cmd: implement ->sqe_copy() to avoid unnecessary copies
In reply to Jens Axboeuring_cmd currently copies the full SQE at prep time, just in case it needs it to be stable. Opt in to using ->sqe_copy() to let the core of io_uring decide when to copy SQEs.
This provides two checks to see if ioucmd->sqe is still valid:
1) If ioucmd->sqe is not the uring copied version AND IO_URING_F_INLINE isn't set, then the core of io_uring has a bug. Warn and return -EFAULT.
2) If sqe is NULL AND IO_URING_F_INLINE isn't set, then the core of io_uring has a bug. Warn and return -EFAULT.
--- io_uring/opdef.c | 1 + io_uring/uring_cmd.c | 35 ++++++++++++++++++++++++----------- io_uring/uring_cmd.h | 2 ++ 3 files changed, 27 insertions(+), 11 deletions(-)
io_uring/opdef.c +1 -0
@@ -759,6 +759,7 @@ const struct io_cold_def io_cold_defs[] = { }, [IORING_OP_URING_CMD] = { .name = "URING_CMD", + .sqe_copy = io_uring_cmd_sqe_copy, .cleanup = io_uring_cmd_cleanup, }, [IORING_OP_SEND_ZC] = {
io_uring/uring_cmd.c +24 -11
@@ -205,16 +205,25 @@ int io_uring_cmd_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)if (!ac)return -ENOMEM ; ac->data.op_data =NULL ; + ioucmd->sqe = sqe; +return 0 ; +} + +int io_uring_cmd_sqe_copy (struct io_kiocb *req,const struct io_uring_sqe *sqe, +unsigned int issue_flags) +{ + struct io_uring_cmd *ioucmd = io_kiocb_to_cmd(req, struct io_uring_cmd); +struct io_async_cmd *ac = req->async_data; + +if (sqe != ac->sqes) { +if (WARN_ON_ONCE (!(issue_flags &IO_URING_F_INLINE ))) +return -EFAULT ; +if (WARN_ON_ONCE (!sqe)) +return -EFAULT ; +memcpy (ac->sqes, sqe,uring_sqe_size (req->ctx)); + ioucmd->sqe = ac->sqes; + } -/* -* Unconditionally cache the SQE for now - this is only needed for -* requests that go async, but prep handlers must ensure that any -* sqe data is stable beyond prep. Since uring_cmd is special in -* that it doesn't read in per-op data, play it safe and ensure that -* any SQE data is stable beyond prep. This can later get relaxed. -*/ -memcpy (ac->sqes, sqe,uring_sqe_size (req->ctx)); - ioucmd->sqe = ac->sqes;return 0 ; }
@@ -251,8 +260,12 @@ int io_uring_cmd(struct io_kiocb *req, unsigned int issue_flags) } ret = file->f_op->uring_cmd (ioucmd, issue_flags); -if (ret == -EAGAIN || ret == -EIOCBQUEUED ) -return ret; +if (ret == -EAGAIN ) { +io_uring_cmd_sqe_copy (req, ioucmd->sqe, issue_flags); +return -EAGAIN ; + }else if (ret == -EIOCBQUEUED ) { +return -EIOCBQUEUED ; + }if (ret <0 )req_set_fail (req);io_req_uring_cleanup (req, issue_flags);
io_uring/uring_cmd.h +2 -0
@@ -11,6 +11,8 @@ struct io_async_cmd {int io_uring_cmd (struct io_kiocb *req,unsigned int issue_flags);int io_uring_cmd_prep (struct io_kiocb *req,const struct io_uring_sqe *sqe); +int io_uring_cmd_sqe_copy (struct io_kiocb *req,const struct io_uring_sqe *sqe, +unsigned int issue_flags);void io_uring_cmd_cleanup (struct io_kiocb *req); bool io_uring_try_cancel_uring_cmd(struct io_ring_ctx *ctx,
Signature · 1 line
2.49.0
Re: [PATCH 4/4] io_uring/uring_cmd: implement ->sqe_copy() to avoid unnecessary copies
Quoted 38 lines · Jens Axboe
uring_cmdcurrently copies the full SQE at prep time, just in case it needs it to be stable. Opt in to using ->sqe_copy() to let the core ofio_uringdecide when to copy SQEs.This provides two checks to see if
ioucmd->sqeis still valid:1) If
ioucmd->sqeis not the uring copied version ANDIO_URING_F_INLINEisn't set, then the core ofio_uringhas a bug. Warn and return-EFAULT.2) If sqe is NULL AND
IO_URING_F_INLINEisn't set, then the core ofio_uringhas a bug. Warn and return-EFAULT.Signed-off-by Jens Axboe <[email protected]>--- io_uring/opdef.c | 1 + io_uring/uring_cmd.c | 35 ++++++++++++++++++++++++----------- io_uring/uring_cmd.h | 2 ++ 3 files changed, 27 insertions(+), 11 deletions(-)io_uring/opdef.c +1
-0@@ -759,6 +759,7 @@ const struct io_cold_def io_cold_defs[] = { }, [IORING_OP_URING_CMD] = { .name = "URING_CMD", + .sqe_copy = io_uring_cmd_sqe_copy, .cleanup = io_uring_cmd_cleanup, }, [IORING_OP_SEND_ZC] = {io_uring/uring_cmd.c +0
-0
io_uring/uring_cmd.c int io_uring_cmd_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) · line 213
Quoted 9 lines
io_uring/uring_cmd.c +6
-0@@ -205,16 +205,25 @@ int io_uring_cmd_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)if (!ac)return -ENOMEM ; ac->data.op_data =NULL ; + ioucmd->sqe = sqe; +return 0 ; +} + +int io_uring_cmd_sqe_copy (struct io_kiocb *req,const struct io_uring_sqe *sqe, +unsigned int issue_flags)
Is it necessary to pass the sqe? Wouldn't it always be ioucmd->sqe? Presumably any other opcode that implements ->sqe_copy() would also have the sqe pointer stashed somewhere. Seems like it would simplify the core io_uring code a bit not to have to thread the sqe through several function calls.
io_uring/uring_cmd.c int io_uring_cmd_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) · line 218
Quoted 5 lines
io_uring/uring_cmd.c +5
-0+{ + struct io_uring_cmd *ioucmd = io_kiocb_to_cmd(req, struct io_uring_cmd); +struct io_async_cmd *ac = req->async_data; + +if (sqe != ac->sqes) {
Maybe return early if sqe == ac->sqes to reduce indentation?
Quoted 21 lines
io_uring/uring_cmd.c +7
-9+if (WARN_ON_ONCE (!(issue_flags &IO_URING_F_INLINE ))) +return -EFAULT ; +if (WARN_ON_ONCE (!sqe)) +return -EFAULT ; +memcpy (ac->sqes, sqe,uring_sqe_size (req->ctx)); + ioucmd->sqe = ac->sqes; + } -/* -* Unconditionally cache the SQE for now - this is only needed for -* requests that go async, but prep handlers must ensure that any -* sqe data is stable beyond prep. Since uring_cmd is special in -* that it doesn't read in per-op data, play it safe and ensure that -* any SQE data is stable beyond prep. This can later get relaxed. -*/ -memcpy (ac->sqes, sqe,uring_sqe_size (req->ctx)); - ioucmd->sqe = ac->sqes;return 0 ; }
io_uring/uring_cmd.c int io_uring_cmd(struct io_kiocb *req, unsigned int issue_flags) · line 264
Quoted 7 lines
io_uring/uring_cmd.c +2
-2@@ -251,8 +260,12 @@ int io_uring_cmd(struct io_kiocb *req, unsigned int issue_flags) } ret = file->f_op->uring_cmd (ioucmd, issue_flags); -if (ret == -EAGAIN || ret == -EIOCBQUEUED ) -return ret; +if (ret == -EAGAIN ) { +io_uring_cmd_sqe_copy (req, ioucmd->sqe, issue_flags);
Is it necessary to call io_uring_cmd_sqe_copy() here? Won't the call in io_queue_async() already handle this case?
io_uring/uring_cmd.c int io_uring_cmd(struct io_kiocb *req, unsigned int issue_flags) · line 266
Quoted 2 lines
io_uring/uring_cmd.c +2
-0+return -EAGAIN ; + }else if (ret == -EIOCBQUEUED ) {
nit: else could be omitted since the if case diverges
Best,
Caleb
Quoted 21 lines
io_uring/uring_cmd.c +2
-0+return -EIOCBQUEUED ; + }if (ret <0 )req_set_fail (req);io_req_uring_cleanup (req, issue_flags);io_uring/uring_cmd.h +2
-1@@ -11,6 +11,8 @@ struct io_async_cmd {int io_uring_cmd (struct io_kiocb *req,unsigned int issue_flags);int io_uring_cmd_prep (struct io_kiocb *req,const struct io_uring_sqe *sqe); +int io_uring_cmd_sqe_copy (struct io_kiocb *req,const struct io_uring_sqe *sqe, +unsigned int issue_flags);void io_uring_cmd_cleanup (struct io_kiocb *req); bool io_uring_try_cancel_uring_cmd(struct io_ring_ctx *ctx, --2.49.0
Jens Axboe
maintainerRe: [PATCH 4/4] io_uring/uring_cmd: implement ->sqe_copy() to avoid unnecessary copies
Quoted 46 lines · Caleb Sander Mateos
Quoted 45 lines · On Thu, Jun 5, 2025 at 12:47?PM Jens Axboe <[email protected]> wrote:
uring_cmdcurrently copies the full SQE at prep time, just in case it needs it to be stable. Opt in to using ->sqe_copy() to let the core ofio_uringdecide when to copy SQEs.This provides two checks to see if
ioucmd->sqeis still valid:1) If
ioucmd->sqeis not the uring copied version ANDIO_URING_F_INLINEisn't set, then the core ofio_uringhas a bug. Warn and return-EFAULT.2) If sqe is NULL AND
IO_URING_F_INLINEisn't set, then the core ofio_uringhas a bug. Warn and return-EFAULT.Signed-off-by Jens Axboe <[email protected]>--- io_uring/opdef.c | 1 + io_uring/uring_cmd.c | 35 ++++++++++++++++++++++++----------- io_uring/uring_cmd.h | 2 ++ 3 files changed, 27 insertions(+), 11 deletions(-)io_uring/opdef.c +1
-0@@ -759,6 +759,7 @@ const struct io_cold_def io_cold_defs[] = { }, [IORING_OP_URING_CMD] = { .name = "URING_CMD", + .sqe_copy = io_uring_cmd_sqe_copy, .cleanup = io_uring_cmd_cleanup, }, [IORING_OP_SEND_ZC] = {io_uring/uring_cmd.c +4
-0@@ -205,16 +205,25 @@ int io_uring_cmd_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)if (!ac)return -ENOMEM ; ac->data.op_data =NULL ; + ioucmd->sqe = sqe; +return 0 ; +} +
Quoted 8 lines
io_uring/uring_cmd.c int io_uring_cmd_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) · line 213
Quoted 2 lines
io_uring/uring_cmd.c +2
-0+int io_uring_cmd_sqe_copy (struct io_kiocb *req,const struct io_uring_sqe *sqe, +unsigned int issue_flags)Is it necessary to pass the sqe? Wouldn't it always be
ioucmd->sqe? Presumably any other opcode that implements ->sqe_copy() would also have the sqe pointer stashed somewhere. Seems like it would simplify the coreio_uringcode a bit not to have to thread the sqe through several function calls.
It's not necessary, but I would rather get rid of needing to store an SQE since that is a bit iffy than get rid of passing the SQE. When it comes from the core, you _know_ it's going to be valid. I feel like you need a fairly intimate understanding of io_uring issue flow to make any judgement on this, if you were adding an opcode and defining this type of handler.
Quoted 7 lines
io_uring/uring_cmd.c int io_uring_cmd_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe) · line 218
Quoted 5 lines
io_uring/uring_cmd.c +5
-0+{ + struct io_uring_cmd *ioucmd = io_kiocb_to_cmd(req, struct io_uring_cmd); +struct io_async_cmd *ac = req->async_data; + +if (sqe != ac->sqes) {Maybe return early if sqe ==
ac->sqesto reduce indentation?
Heh, the current -git version has it like that, since yesterday. So yeah, I agree.
Quoted 12 lines
io_uring/uring_cmd.c int io_uring_cmd(struct io_kiocb *req, unsigned int issue_flags) · line 264
Quoted 8 lines
io_uring/uring_cmd.c +2
-2@@ -251,8 +260,12 @@ int io_uring_cmd(struct io_kiocb *req, unsigned int issue_flags) } ret = file->f_op->uring_cmd (ioucmd, issue_flags); -if (ret == -EAGAIN || ret == -EIOCBQUEUED ) -return ret; +if (ret == -EAGAIN ) { +io_uring_cmd_sqe_copy (req, ioucmd->sqe, issue_flags);Is it necessary to call
io_uring_cmd_sqe_copy()here? Won't the call inio_queue_async()already handle this case?
Good point, yes it should not be necessary at all. I'll kill it.
Quoted 4 lines
io_uring/uring_cmd.c int io_uring_cmd(struct io_kiocb *req, unsigned int issue_flags) · line 266
Quoted 2 lines
io_uring/uring_cmd.c +2
-0+return -EAGAIN ; + }else if (ret == -EIOCBQUEUED ) {nit: else could be omitted since the if case diverges
With the above removal of cmd_sqe_copu(), then this entire hunk goes away.
Signature · 1 line
Jens Axboe
Jens Axboe
maintainerRe: [PATCH 4/4] io_uring/uring_cmd: implement ->sqe_copy() to avoid unnecessary copies
Quoted 6 lines · Jens Axboe
Quoted 5 lines
Is it necessary to pass the sqe? Wouldn't it always be
ioucmd->sqe? Presumably any other opcode that implements ->sqe_copy() would also have the sqe pointer stashed somewhere. Seems like it would simplify the coreio_uringcode a bit not to have to thread the sqe through several function calls.
Quoted 6 lines
It's not necessary, but I would rather get rid of needing to store an SQE since that is a bit iffy than get rid of passing the SQE. When it comes from the core, you _know_ it's going to be valid. I feel like you need a fairly intimate understanding of
io_uringissue flow to make any judgement on this, if you were adding an opcode and defining this type of handler.
Actually did go that route anyway, because we still need to stash it. And if we do go that route, then we can keep all the checking in the core and leave the handler just a basic copy with a void return. Which is pretty nice.
Anyway, checkout v3 and see what you thing.
Signature · 1 line
Jens Axboe
Re: [PATCH 4/4] io_uring/uring_cmd: implement ->sqe_copy() to avoid unnecessary copies
Quoted 15 lines · Jens Axboe
Quoted 6 lines · Jens Axboe
Quoted 5 lines
Is it necessary to pass the sqe? Wouldn't it always be
ioucmd->sqe? Presumably any other opcode that implements ->sqe_copy() would also have the sqe pointer stashed somewhere. Seems like it would simplify the coreio_uringcode a bit not to have to thread the sqe through several function calls.Quoted 6 lines
It's not necessary, but I would rather get rid of needing to store an SQE since that is a bit iffy than get rid of passing the SQE. When it comes from the core, you _know_ it's going to be valid. I feel like you need a fairly intimate understanding of
io_uringissue flow to make any judgement on this, if you were adding an opcode and defining this type of handler.
Quoted 6 lines
Actually did go that route anyway, because we still need to stash it. And if we do go that route, then we can keep all the checking in the core and leave the handler just a basic copy with a void return. Which is pretty nice.
Anyway, checkout v3 and see what you thing.
From a quick glance it looks good to me. Let me give it a more detailed look with a fresh pair of eyes.
Best,
Caleb
Jens Axboe
maintainerRe: [PATCH 4/4] io_uring/uring_cmd: implement ->sqe_copy() to avoid unnecessary copies
Quoted 21 lines · Caleb Sander Mateos
Quoted 20 lines · On Fri, Jun 6, 2025 at 3:08?PM Jens Axboe <[email protected]> wrote:
Quoted 6 lines · Jens Axboe
Quoted 5 lines
Is it necessary to pass the sqe? Wouldn't it always be
ioucmd->sqe? Presumably any other opcode that implements ->sqe_copy() would also have the sqe pointer stashed somewhere. Seems like it would simplify the coreio_uringcode a bit not to have to thread the sqe through several function calls.Quoted 6 lines
It's not necessary, but I would rather get rid of needing to store an SQE since that is a bit iffy than get rid of passing the SQE. When it comes from the core, you _know_ it's going to be valid. I feel like you need a fairly intimate understanding of
io_uringissue flow to make any judgement on this, if you were adding an opcode and defining this type of handler.Actually did go that route anyway, because we still need to stash it. And if we do go that route, then we can keep all the checking in the core and leave the handler just a basic copy with a void return. Which is pretty nice.
Quoted 4 lines
Quoted 1 line
Anyway, checkout v3 and see what you thing.
From a quick glance it looks good to me. Let me give it a more detailed look with a fresh pair of eyes.
Thanks, that'd be great. Ignore the commit message for patch 4, I did update it but didn't amend before sending out... The one in the git tree is accurate.
Signature · 1 line
Jens Axboe
Quoted 49 lines · Jens Axboe
Hi,
Currently
uring_cmdunconditionally copies the SQE at prep time, as it has no other choice - the SQE data must remain stable after submit. This can lead to excessive memory bandwidth being used for that copy, as passthrough will often use 128b SQEs, and efficiency concerns as those copies will potentially use quite a lot of CPU cycles as well.As a quick test, running the current -git kernel on a box with 23 NVMe drives doing passthrough IO,
memcpy()is the highest cycle user at 9.05%, which is all off theuring_cmdprep path. The test case is a 512b random read, which runs at 91-92M IOPS.With these patches,
memcpy()is gone from the profiles, and it runs at 98-99M IOPS, or about 7-8% faster.Before:
IOPS=91.12M, BW=44.49GiB/s, IOS/call=32/32
IOPS=91.16M, BW=44.51GiB/s, IOS/call=32/32
IOPS=91.18M, BW=44.52GiB/s, IOS/call=31/32
IOPS=91.92M, BW=44.88GiB/s, IOS/call=32/32
IOPS=91.88M, BW=44.86GiB/s, IOS/call=32/32
IOPS=91.82M, BW=44.83GiB/s, IOS/call=32/31
IOPS=91.52M, BW=44.69GiB/s, IOS/call=32/32with the top perf report -g --no-children being:
+ 9.07%
io_uring[kernel.kallsyms] [k] memcpyand after:
# bash run-peak-pass.sh [...] IOPS=99.30M, BW=48.49GiB/s, IOS/call=32/32 IOPS=99.27M, BW=48.47GiB/s, IOS/call=31/32 IOPS=99.60M, BW=48.63GiB/s, IOS/call=32/32 IOPS=99.68M, BW=48.67GiB/s, IOS/call=32/31 IOPS=99.80M, BW=48.73GiB/s, IOS/call=31/32 IOPS=99.84M, BW=48.75GiB/s, IOS/call=32/32with memcpy not even in profiles. If you do the actual math of 100M requests per second, and 128b of copying per IOP, then it's almost 12GB/sec of reduced memory bandwidth.
Even for lower IOPS production testing, Caleb reports that
memcpy()overhead is in the realm of 1.1% of CPU time.
Quoted 8 lines
v2 of this patchset takes a different approach than v1 did - rather than have the core mark a request as being potentially issued out-of-line, this one adds an
io_cold_def->sqe_copy() helper, and puts the onus onio_uringcore to call it appropriately. Outside of that, it also adds anIO_URING_F_INLINEflag so that the copy helper _knows_ if it may sanely copy the SQE, or whether there's a bug in the core and it should just be ended with-EFAULT. Where possible, the actual SQE is also passed in.
I like the ->sqe_copy() approach. I'm not totally convinced the complexity of computing and checking IO_URING_F_INLINE is worth it for what's effectively an assertion, but I'm not strongly opposed to it either.
Thanks,
Caleb
Quoted 20 lines
I think this approach is saner, and in fact it can be extended to reduce over-eager copies in other spots. For now I just did
uring_cmd, and verified that the memcpy's are still gone from my test.Can also be found here:
https://git.kernel.dk/cgit/linux/log/?h=uring_cmd.2
include/linux/io_uring_types.h | 2 ++ io_uring/io_uring.c | 35 +++++++++++++++------ io_uring/opdef.c | 1 + io_uring/opdef.h | 1 + io_uring/uring_cmd.c | 57 ++++++++++++++++++---------------- io_uring/uring_cmd.h | 2 ++ 6 files changed, 63 insertions(+), 35 deletions(-)--
Jens Axboe
Jens Axboe
maintainerQuoted 59 lines · Caleb Sander Mateos
Quoted 49 lines · On Thu, Jun 5, 2025 at 12:47?PM Jens Axboe <[email protected]> wrote:
Hi,
Currently
uring_cmdunconditionally copies the SQE at prep time, as it has no other choice - the SQE data must remain stable after submit. This can lead to excessive memory bandwidth being used for that copy, as passthrough will often use 128b SQEs, and efficiency concerns as those copies will potentially use quite a lot of CPU cycles as well.As a quick test, running the current -git kernel on a box with 23 NVMe drives doing passthrough IO,
memcpy()is the highest cycle user at 9.05%, which is all off theuring_cmdprep path. The test case is a 512b random read, which runs at 91-92M IOPS.With these patches,
memcpy()is gone from the profiles, and it runs at 98-99M IOPS, or about 7-8% faster.Before:
IOPS=91.12M, BW=44.49GiB/s, IOS/call=32/32
IOPS=91.16M, BW=44.51GiB/s, IOS/call=32/32
IOPS=91.18M, BW=44.52GiB/s, IOS/call=31/32
IOPS=91.92M, BW=44.88GiB/s, IOS/call=32/32
IOPS=91.88M, BW=44.86GiB/s, IOS/call=32/32
IOPS=91.82M, BW=44.83GiB/s, IOS/call=32/31
IOPS=91.52M, BW=44.69GiB/s, IOS/call=32/32with the top perf report -g --no-children being:
+ 9.07%
io_uring[kernel.kallsyms] [k] memcpyand after:
# bash run-peak-pass.sh [...] IOPS=99.30M, BW=48.49GiB/s, IOS/call=32/32 IOPS=99.27M, BW=48.47GiB/s, IOS/call=31/32 IOPS=99.60M, BW=48.63GiB/s, IOS/call=32/32 IOPS=99.68M, BW=48.67GiB/s, IOS/call=32/31 IOPS=99.80M, BW=48.73GiB/s, IOS/call=31/32 IOPS=99.84M, BW=48.75GiB/s, IOS/call=32/32with memcpy not even in profiles. If you do the actual math of 100M requests per second, and 128b of copying per IOP, then it's almost 12GB/sec of reduced memory bandwidth.
Even for lower IOPS production testing, Caleb reports that
memcpy()overhead is in the realm of 1.1% of CPU time.Quoted 8 lines
v2 of this patchset takes a different approach than v1 did - rather than have the core mark a request as being potentially issued out-of-line, this one adds an
io_cold_def->sqe_copy() helper, and puts the onus onio_uringcore to call it appropriately. Outside of that, it also adds anIO_URING_F_INLINEflag so that the copy helper _knows_ if it may sanely copy the SQE, or whether there's a bug in the core and it should just be ended with-EFAULT. Where possible, the actual SQE is also passed in.
Quoted 4 lines
I like the ->sqe_copy() approach. I'm not totally convinced the complexity of computing and checking
IO_URING_F_INLINEis worth it for what's effectively an assertion, but I'm not strongly opposed to it either.
It's no extra overhead on the normal issue side, as the mask isn't conditional. For now it's just belt and suspenders, down the line we can relax (and remove) some of this on the uring_cmd side.
Signature · 1 line
Jens Axboe