scripts/s390x: Fix the execution of the PV tests
PATCH 1/1 scripts/s390x: Fix the execution of the PV tests
Commit ccb37496 ("scripts: allow machine option to be specified in unittests.cfg") added an additonal parameter (the "machine"), but we forgot to add it to the spot that runs the PV test cases, so those are currently broken without this fix.
--- scripts/s390x/func.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/s390x/func.bash +1 -1
@@ -35,5 +35,5 @@ function arch_cmd_s390x() print_result 'SKIP' $testname '' 'PVM image was not created' return 2 fi - "$cmd" "$testname" "$groups pv" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout" + "$cmd" "$testname" "$groups pv" "$smp" "$kernel" "$opts" "$arch" "$machine" "$check" "$accel" "$timeout" }
Signature · 1 line
2.45.1
Quoted 7 lines · Thomas Huth
Commit
ccb37496("scripts: allow machine option to be specified in unittests.cfg") added an additonal parameter (the "machine"), but we forgot to add it to the spot that runs the PV test cases, so those are currently broken without this fix.Fixes ccb37496 ("scripts: allow machine option to be specified in unittests.cfg")Signed-off-by Thomas Huth <[email protected]>
LGTM
Has this issue come up in the Gitlab CI or in your internal CI?
Quoted 11 lines · Janosch Frank
Quoted 7 lines · Thomas Huth
Commit
ccb37496("scripts: allow machine option to be specified in unittests.cfg") added an additonal parameter (the "machine"), but we forgot to add it to the spot that runs the PV test cases, so those are currently broken without this fix.Fixes ccb37496 ("scripts: allow machine option to be specified in unittests.cfg")Signed-off-by Thomas Huth <[email protected]>LGTM
Has this issue come up in the Gitlab CI or in your internal CI?
Gitlab CI does not run the PV tests yet - I just noticed it while running the tests on the s390x machine that I've got access to.
Thomas
Quoted 4 lines · Thomas Huth
Commit
ccb37496("scripts: allow machine option to be specified in unittests.cfg") added an additonal parameter (the "machine"), but we forgot to add it to the spot that runs the PV test cases, so those are currently broken without this fix.
Thanks, this is the one you already found? Looks good to me.
Thanks,
Nick
Quoted 18 lines
Fixes ccb37496 ("scripts: allow machine option to be specified in unittests.cfg")Signed-off-by Thomas Huth <[email protected]>--- scripts/s390x/func.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)scripts/s390x/func.bash +1
-1@@ -35,5 +35,5 @@ function arch_cmd_s390x() print_result 'SKIP' $testname '' 'PVM image was not created' return 2 fi - "$cmd" "$testname" "$groups pv" "$smp" "$kernel" "$opts" "$arch" "$check" "$accel" "$timeout" + "$cmd" "$testname" "$groups pv" "$smp" "$kernel" "$opts" "$arch" "$machine" "$check" "$accel" "$timeout" }