Skip to contentSkip to conversation

ARM: defconfig: include QCOM_EBI2 in multi_v7

PATCH New Linus Walleij 3 participants 5 messages Jan 10, 2017 – Jan 12, 2017 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: defconfig: include QCOM_EBI2 in multi_v7

This adds the Qualcomm External Bus Interface 2 to the multi_v7
defconfig: it is hard for users to realize that this is a required driver for getting things like ethernet, and a necessary prerequisite to get the external bus discoverable on the MSM8660/APQ8060 machines.

As regular users will likely want to have some ethernet and other functionality up quickly, it makes sense to add this to the multi_v7 defconfig.

---
ARM SoC folks: please just apply this wherever ARM multi_v7 defconfigs go if you're OK with it.

---
 arch/arm/configs/multi_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/multi_v7_defconfig +1 -0
index b01a43851294..267d0703caae 100644
@@ -192,6 +192,7 @@ CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_DMA_CMA=y
 CONFIG_CMA_SIZE_MBYTES=64
 CONFIG_OMAP_OCP2SCP=y
+CONFIG_QCOM_EBI2=y
 CONFIG_SIMPLE_PM_BUS=y
 CONFIG_SUNXI_RSB=m
 CONFIG_MTD=y
Signature · 1 line
2.9.3
#1 lore raw

PATCH 1/1 ARM: defconfig: include QCOM_EBI2 in multi_v7

Quoted 5 lines · Linus Walleij

This adds the Qualcomm External Bus Interface 2 to the multi_v7
defconfig: it is hard for users to realize that this is a required driver for getting things like ethernet, and a necessary prerequisite to get the external bus discoverable on the MSM8660/APQ8060 machines.

Is it the kind of option that should really be selected through Kconfig instead for those platforms?

I.e. is it ever really likely that we'll want it off?

-Olof

#2 lore raw

PATCH 1/1 ARM: defconfig: include QCOM_EBI2 in multi_v7

Quoted 9 lines · Olof Johansson
Quoted 5 lines · Linus Walleij

This adds the Qualcomm External Bus Interface 2 to the multi_v7
defconfig: it is hard for users to realize that this is a required driver for getting things like ethernet, and a necessary prerequisite to get the external bus discoverable on the MSM8660/APQ8060 machines.

Is it the kind of option that should really be selected through Kconfig instead for those platforms?

Stephen Boyd question.

AFAIK the ambition is to go with the platform to have zero stuff in mach-qcom/* and thus it all becomes a defconfig thing.

Quoted 1 line

I.e. is it ever really likely that we'll want it off?

Not really, if this chip should be supported in the resulting image.

Yours,
Linus Walleij

#3 lore raw

PATCH 1/1 ARM: defconfig: include QCOM_EBI2 in multi_v7

Quoted 7 lines · Linus Walleij
Quoted 6 lines · Olof Johansson
Quoted 5 lines · Linus Walleij

This adds the Qualcomm External Bus Interface 2 to the multi_v7
defconfig: it is hard for users to realize that this is a required driver for getting things like ethernet, and a necessary prerequisite to get the external bus discoverable on the MSM8660/APQ8060 machines.

Quoted 7 lines
Quoted 2 lines

Is it the kind of option that should really be selected through Kconfig instead for those platforms?

Stephen Boyd question.

AFAIK the ambition is to go with the platform to have zero stuff in mach-qcom/* and thus it all becomes a defconfig thing.

It could be made a 'default ARCH_QCOM' type of thing. Then the config doesn't need an update unless you want to turn it off. I imagine people would want to turn it off if they're using a board with a qcom SoC that isn't 8660, which is probably going to stay the majority forever.

It's true I've been pushing to get rid of the ARCH_MSM* configs in mach-qcom/Kconfig as they lead to confusion about what qcom SoCs are supported in mainline and cause config options to become outdated each time a new SoC comes out that supports some particular driver. I'll go repush those changes.

Signature · 2 lines
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
#4 lore raw

PATCH 1/1 ARM: defconfig: include QCOM_EBI2 in multi_v7

Quoted 11 lines · Stephen Boyd
Quoted 10 lines · Linus Walleij
Quoted 8 lines · Olof Johansson
Quoted 5 lines · Linus Walleij

This adds the Qualcomm External Bus Interface 2 to the multi_v7
defconfig: it is hard for users to realize that this is a required driver for getting things like ethernet, and a necessary prerequisite to get the external bus discoverable on the MSM8660/APQ8060 machines.

Is it the kind of option that should really be selected through Kconfig instead for those platforms?

Quoted 8 lines
Quoted 5 lines

Stephen Boyd question.

AFAIK the ambition is to go with the platform to have zero stuff in mach-qcom/* and thus it all becomes a defconfig thing.

It could be made a 'default ARCH_QCOM' type of thing. Then the config doesn't need an update unless you want to turn it off.

OK I will do that.

Olof: let's scrap this patch.

Yours,
Linus Walleij