Skip to contentSkip to conversation

ARM: dts: s3c64xx: Fix init order of clock providers

PATCH Applied Krzysztof Kozlowski 2 participants 4 messages Oct 8, 2019

Subsystems (2)
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH 1/1 ARM: dts: s3c64xx: Fix init order of clock providers

From: Lihua Yao <[email protected]>

fin_pll is the parent of clock-controller@7e00f000, specify the dependency to ensure proper initialization order of clock providers.

without this patch:

[    0.000000] S3C6410 clocks: apll = 0, mpll = 0
[    0.000000]  epll = 0, arm_clk = 0

with this patch:

[    0.000000] S3C6410 clocks: apll = 532000000, mpll = 532000000
[    0.000000]  epll = 24000000, arm_clk = 532000000
Fixes 3f6d439f2022 ("clk: reverse default clk provider initialization order in of_clk_init()")

---

Sending in author's name because outlook bounces from the lists.

---
 arch/arm/boot/dts/s3c6410-mini6410.dts | 4 ++++
 arch/arm/boot/dts/s3c6410-smdk6410.dts | 4 ++++
 2 files changed, 8 insertions(+)
arch/arm/boot/dts/s3c6410-mini6410.dts +4 -0
index 0e159c884f97..1aeac33b0d34 100644
@@ -165,6 +165,10 @@
 	};
 };
 
+&clocks {
+	clocks = <&fin_pll>;
+};
+
 &sdhci0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&sd0_clk>, <&sd0_cmd>, <&sd0_cd>, <&sd0_bus4>;
arch/arm/boot/dts/s3c6410-smdk6410.dts +4 -0
index a9a5689dc462..3bf6c450a26e 100644
@@ -69,6 +69,10 @@
 	};
 };
 
+&clocks {
+	clocks = <&fin_pll>;
+};
+
 &sdhci0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&sd0_clk>, <&sd0_cmd>, <&sd0_cd>, <&sd0_bus4>;
Signature · 1 line
2.17.1
author maintainer Applied
#1 lore raw
Quoted 10 lines · Krzysztof Kozlowski

From: Lihua Yao <[email protected]>

fin_pll is the parent of clock-controller@7e00f000, specify the dependency to ensure proper initialization order of clock providers.

without this patch:

[    0.000000] S3C6410 clocks: apll = 0, mpll = 0
[    0.000000]  epll = 0, arm_clk = 0
Quoted 6 lines

with this patch:

[    0.000000] S3C6410 clocks: apll = 532000000, mpll = 532000000
[    0.000000]  epll = 24000000, arm_clk = 532000000
Fixes 3f6d439f2022 ("clk: reverse default clk provider initialization order in of_clk_init()")

Thanks, applied.

Best regards,
Krzysztof

Reviewed-by on v1 1/1
#2 lore raw
In reply to Krzysztof Kozlowski
Quoted 7 lines · Krzysztof Kozlowski

From: Lihua Yao <[email protected]>

fin_pll is the parent of clock-controller@7e00f000, specify the dependency to ensure proper initialization order of clock providers.

Fixes 3f6d439f2022 ("clk: reverse default clk provider initialization order in of_clk_init()")

The patch looks good but I'm not sure above tag points to the right commit. That commit is just a regression fix for
1771b10d605d26cc "clk: respect the clock dependencies in of_clk_init"

How about picking some commit touching the dts files itself, e.g. a43736deb47d21bd "ARM: dts: Add dts file for S3C6410-based Mini6410 board" ?

Quoted 2 lines
Signature · 2 lines
Regards,
Sylwester
author maintainer
#3 lore raw
Quoted 7 lines · Sylwester Nawrocki
Quoted 5 lines · Krzysztof Kozlowski

From: Lihua Yao <[email protected]>

fin_pll is the parent of clock-controller@7e00f000, specify the dependency to ensure proper initialization order of clock providers.

Quoted 8 lines
Quoted 1 line
Fixes 3f6d439f2022 ("clk: reverse default clk provider initialization order in of_clk_init()")

The patch looks good but I'm not sure above tag points to the right commit. That commit is just a regression fix for
1771b10d605d26cc "clk: respect the clock dependencies in of_clk_init"

How about picking some commit touching the dts files itself, e.g. a43736deb47d21bd "ARM: dts: Add dts file for S3C6410-based Mini6410 board" ?

As I understood, the mentioned commit "reverse default clk provider" caused issue to appear, because of reversed order (first version of this patch played with the order). Even though that commit was not strictly the cause, but should come proably with proper DTS change. Therefore the fixes points to right moment of backports.

The DTS commit, at that time, was correct with bindings and with driver.

Quoted 5 lines
Quoted 3 lines

Thanks!

Best regards,
Krzysztof