arm64: amlogic: Rename spi pinmux group
Subsystems (2)
PATCH 1/1 arm64: amlogic: Rename spi pinmux group
From: Thierry Reding <[email protected]>
The name "spi" is reserved for nodes representing an SPI controller. Rename the "spi" pinmux group to "spi-miso" to avoid the issue and for consistency with other pinmux groups.
---
Rob,
do you think perhaps DTC is being a little too strict here? Seems to me like the check could be limited to nodes that have a name and a unit address, the assumption being that an SPI controller would always have some sort of register space that requires a reg property and therefore also a unit address.
Thierry
arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 2 +- arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi +1 -1
@@ -390,7 +390,7 @@ }; }; - spi_pins: spi { + spi_pins: spi-miso { mux { groups = "spi_miso", "spi_mosi",
arch/arm64/boot/dts/amlogic/meson-gxl.dtsi +1 -1
@@ -337,7 +337,7 @@ }; }; - spi_pins: spi { + spi_pins: spi-miso { mux { groups = "spi_miso", "spi_mosi",
Signature · 1 line
2.19.0
PATCH 1/1 arm64: amlogic: Rename spi pinmux group
Hi,
Quoted 16 lines · Thierry Reding
From: Thierry Reding <[email protected]>
The name "spi" is reserved for nodes representing an SPI controller. Rename the "spi" pinmux group to "spi-miso" to avoid the issue and for consistency with other pinmux groups.
Signed-off-by Thierry Reding <[email protected]>---
Rob,do you think perhaps DTC is being a little too strict here? Seems to me like the check could be limited to nodes that have a name and a unit address, the assumption being that an SPI controller would always have some sort of register space that requires a reg property and therefore also a unit address.
Quoted 5 lines
Thierry
arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 2 +- arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Rob has already submitted similar fix and was merged by kevin.
Neil
arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi line 393
Quoted 11 lines
arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi +1
-1@@ -390,7 +390,7 @@ }; }; - spi_pins: spi { + spi_pins: spi-miso {
The name "spi-miso" is wrong since it also has spi-mosi...
Quoted 17 lines
arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi +0
-0mux { groups = "spi_miso", "spi_mosi",arch/arm64/boot/dts/amlogic/meson-gxl.dtsi +1
-1@@ -337,7 +337,7 @@ }; }; - spi_pins: spi { + spi_pins: spi-miso { mux { groups = "spi_miso", "spi_mosi",