coccinelle: misc: add array_size_dup script to detect missed overflow checks
Quoted 1 line
Changes in v2:
…
Quoted 1 line
- assignment operator used
I would prefer the distinction for the application of corresponding metavariables.
Quoted 1 line
Changes in v3:
…
Quoted 1 line
- \(&E1\|&E2\) changed to &\(E1\|E2\)
Would it be more helpful to mention the movement of the ampersand before SmPL disjunctions?
…
Review
Quoted 3 lines
(quoted diff) +3
-0+virtual context +virtual report +virtual org
Can the following SmPL code variant become more attractive?
+virtual context, report, org
…
Review
Quoted 3 lines
(quoted diff) +3
-0+expression subE1 <= as.E1; +expression subE2 <= as.E2; +expression as.E1, as.E2, E3;
How do you think about the following SmPL code variant?
+expression subE1 <= as.E1,
+ subE2 <= as.E2, + as.E1, + as.E2, + E3;
…
Review
Quoted 2 lines
(quoted diff) +2
-0+coccilib.report.print_report(p2[0], +f"WARNING: same struct_size (line {p1[0].line})")
Please align such function parameters.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=5e857ce6eae7ca21b2055cca4885545e29228fe2#n93
+coccilib.report.print_report(p2[0],
+ f"WARNING: same struct_size (line {p1[0].line})")
Regards,
Markus