Skip to contentSkip to conversation

firmware: stratix10-svc: Fix some error handling paths in 'stratix10_svc_drv_probe()'

PATCH Markus Elfring 1 participant 1 message Apr 26, 2020 Kernel janitors

lore
Share & tools
lore
#0 lore raw
Quoted 3 lines

If an error occurs after calling 'kfifo_alloc()', the allocated memory should be freed with 'kfifo_free()', as already done in the remove function.

I suggest to reconsider software development consequences around another implementation detail for such exception handling.

…

Quoted 2 lines

+++ b/drivers/firmware/stratix10-svc.c

(quoted diff) +0 -0
@@ -1043,24 +1043,31 @@ static int stratix10_svc_drv_probe(struct platform_device *pdev)

…

Quoted 1 line

svc = devm_kzalloc(dev, sizeof(*svc), GFP_KERNEL);

…

Review

Quoted 4 lines
(quoted diff) +4 -0
+	if (!svc) {
+		ret = -ENOMEM;
+		goto err_free_kfifo;
+	}

Would you like to take the possibility into account to avoid the duplicate specification of this error code assignment by adding another jump target?

- return -ENOMEM;
+ goto e_nomem;

Review

Quoted 2 lines
(quoted diff) +2 -0
+	return 0;
+

+e_nomem:
+ ret = -ENOMEM;

Quoted 4 lines
(quoted diff) +2 -0
+err_free_kfifo:
+	kfifo_free(&controller->svc_fifo);
	return ret;

}

By the way:
How do you think about to omit the error message “failed to allocate FIFO” for a failed call of the function “kfifo_alloc”?

Regards,
Markus