ocfs2: remove unnecessary NULL check in ocfs2_grab_folios()
Subsystems (2)
PATCH 1/1 ocfs2: remove unnecessary NULL check in ocfs2_grab_folios()
Smatch complains that checking "folios" for NULL doesn't make sense because it has already been dereferenced at this point. Really passing a NULL "folios" pointer to ocfs2_grab_folios() doesn't make sense, and fortunately none of the callers do that. Delete the unnecessary NULL check.
--- fs/ocfs2/alloc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
fs/ocfs2/alloc.c +1 -2
@@ -6928,8 +6928,7 @@ static int ocfs2_grab_folios(struct inode *inode, loff_t start, loff_t end, out:if (ret !=0 ) { -if (folios) -ocfs2_unlock_and_free_folios (folios, numfolios); +ocfs2_unlock_and_free_folios (folios, numfolios); numfolios =0 ; }
Signature · 1 line
2.47.2
Re: [External] : [PATCH] ocfs2: remove unnecessary NULL check in ocfs2_grab_folios()
Quoted 16 lines · Dan Carpenter
Smatch complains that checking "folios" for NULL doesn't make sense because it has already been dereferenced at this point. Really passing a NULL "folios" pointer to
ocfs2_grab_folios()doesn't make sense, and fortunately none of the callers do that. Delete the unnecessary NULL check.Signed-off-by Dan Carpenter <[email protected]>--- fs/ocfs2/alloc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)fs/ocfs2/alloc.c +0
-0
fs/ocfs2/alloc.c static int ocfs2_grab_folios(struct inode *inode, loff_t start, loff_t end, · line 6934
Quoted 9 lines
fs/ocfs2/alloc.c +1
-2@@ -6928,8 +6928,7 @@ static int ocfs2_grab_folios(struct inode *inode, loff_t start, loff_t end, out:if (ret !=0 ) { -if (folios) -ocfs2_unlock_and_free_folios (folios, numfolios); +ocfs2_unlock_and_free_folios (folios, numfolios); numfolios =0 ; }
Quoted 7 lines · Dan Carpenter
Smatch complains that checking "folios" for NULL doesn't make sense because it has already been dereferenced at this point. Really passing a NULL "folios" pointer to
ocfs2_grab_folios()doesn't make sense, and fortunately none of the callers do that. Delete the unnecessary NULL check.Signed-off-by Dan Carpenter <[email protected]>
Quoted 18 lines
--- fs/ocfs2/alloc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)fs/ocfs2/alloc.c +1
-2@@ -6928,8 +6928,7 @@ static int ocfs2_grab_folios(struct inode *inode, loff_t start, loff_t end, out:if (ret !=0 ) { -if (folios) -ocfs2_unlock_and_free_folios (folios, numfolios); +ocfs2_unlock_and_free_folios (folios, numfolios); numfolios =0 ; }