Skip to contentSkip to conversation

generic/631: Add a check for extended attributes

PATCH Superseded Shreeya Patel 2 participants 3 messages Apr 30, 2021 VFS

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 generic/631: Add a check for extended attributes

Test case 631 fails for filesystems like exfat or vfat or any other which does not support extended attributes.

The main reason for failure is not being able to mount overlayfs with filesystems that do not support extended attributes. mount -t overlay overlay -o "$l,$u,$w,$i" $mergedir

Above command would return an error as -
/var/mnt/scratch/merged0: wrong fs type, bad option, bad superblock on overlay, missing codepage or helper program, or other error.

dmesg log reports the following -
overlayfs: filesystem on '/var/mnt/scratch/upperdir1' not supported

As per the overlayfs documentation -
"A wide range of filesystems supported by Linux can be the lower filesystem, but not all filesystems that are mountable by Linux have the features needed for OverlayFS to work. The lower filesystem does not need to be writable. The lower filesystem can even be another overlayfs.
The upper filesystem will normally be writable and if it is it must support the creation of trusted.* and/or user.* extended attributes, and must provide valid d_type in readdir responses, so NFS is not suitable.
A read-only overlay of two read-only filesystems may use any filesystem type."

As per the above statements from the overlayfs documentation, it is clear that filesystems that do not support extended attributes would not work with overlayfs. This is why we see the error in dmesg log for upperdir1 which had an exfat filesystem.

Hence, add a check for extended attributes which would avoid running this tests for filesystems that are not supported.

---
 tests/generic/631 | 2 ++
 1 file changed, 2 insertions(+)
tests/generic/631 +2 -0
index c43f3de3..c7f0190e 100755
@@ -39,10 +39,12 @@ _cleanup()
 
 # get standard environment, filters and checks
 . ./common/rc
+. ./common/attr
 
 # real QA test starts here
 _supported_fs generic
 _require_scratch
+_require_attrs
 test "$FSTYP" = "overlay" && _notrun "Test does not apply to overlayfs."
 _require_extra_fs overlay
 
Signature · 1 line
2.30.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 14 lines · Shreeya Patel

Test case 631 fails for filesystems like exfat or vfat or any other which does not support extended attributes.

The main reason for failure is not being able to mount overlayfs with filesystems that do not support extended attributes. mount -t overlay overlay -o "$l,$u,$w,$i" $mergedir

Above command would return an error as -
/var/mnt/scratch/merged0: wrong fs type, bad option, bad superblock on overlay, missing codepage or helper program, or other error.

dmesg log reports the following -
overlayfs: filesystem on '/var/mnt/scratch/upperdir1' not supported

Quoted 8 lines

As per the overlayfs documentation -
"A wide range of filesystems supported by Linux can be the lower filesystem, but not all filesystems that are mountable by Linux have the features needed for OverlayFS to work. The lower filesystem does not need to be writable. The lower filesystem can even be another overlayfs.
The upper filesystem will normally be writable and if it is it must support the creation of trusted.* and/or user.* extended attributes, and must provide valid d_type in readdir responses, so NFS is not suitable.

Does this test also need to check for d_type support?

Quoted 5 lines

A read-only overlay of two read-only filesystems may use any filesystem type."

As per the above statements from the overlayfs documentation, it is clear that filesystems that do not support extended attributes would not work with overlayfs. This is why we see the error in dmesg log for upperdir1 which had an exfat filesystem.

(Please wrap the commit messages at 75 columns, per SubmittingPatches.)

Quoted 4 lines

Hence, add a check for extended attributes which would avoid running this tests for filesystems that are not supported.

Regardless, this seems like a reasonable change, so:

--D

Quoted 24 lines
---
 tests/generic/631 | 2 ++
 1 file changed, 2 insertions(+)
tests/generic/631 +2 -0
index c43f3de3..c7f0190e 100755
@@ -39,10 +39,12 @@ _cleanup()
 
 # get standard environment, filters and checks
 . ./common/rc
+. ./common/attr
 
 # real QA test starts here
 _supported_fs generic
 _require_scratch
+_require_attrs
 test "$FSTYP" = "overlay" && _notrun "Test does not apply to overlayfs."
 _require_extra_fs overlay
 
Signature · 1 line
2.30.2
#2 lore raw
Quoted 23 lines · Darrick J. Wong
Quoted 14 lines · Shreeya Patel

Test case 631 fails for filesystems like exfat or vfat or any other which does not support extended attributes.

The main reason for failure is not being able to mount overlayfs with filesystems that do not support extended attributes. mount -t overlay overlay -o "$l,$u,$w,$i" $mergedir

Above command would return an error as -
/var/mnt/scratch/merged0: wrong fs type, bad option, bad superblock on overlay, missing codepage or helper program, or other error.

dmesg log reports the following -
overlayfs: filesystem on '/var/mnt/scratch/upperdir1' not supported

Quoted 8 lines

As per the overlayfs documentation -
"A wide range of filesystems supported by Linux can be the lower filesystem, but not all filesystems that are mountable by Linux have the features needed for OverlayFS to work. The lower filesystem does not need to be writable. The lower filesystem can even be another overlayfs.
The upper filesystem will normally be writable and if it is it must support the creation of trusted.* and/or user.* extended attributes, and must provide valid d_type in readdir responses, so NFS is not suitable.

Quoted 1 line

Does this test also need to check for d_type support?

It already does that.

Quoted 6 lines
Quoted 5 lines

A read-only overlay of two read-only filesystems may use any filesystem type."

As per the above statements from the overlayfs documentation, it is clear that filesystems that do not support extended attributes would not work with overlayfs. This is why we see the error in dmesg log for upperdir1 which had an exfat filesystem.

(Please wrap the commit messages at 75 columns, per SubmittingPatches.)

Sure, will send a v2.

Quoted 7 lines
Quoted 4 lines

Hence, add a check for extended attributes which would avoid running this tests for filesystems that are not supported.

Regardless, this seems like a reasonable change, so:

Thanks

Quoted 26 lines

--D

Quoted 24 lines
---
  tests/generic/631 | 2 ++
  1 file changed, 2 insertions(+)
tests/generic/631 +2 -0
index c43f3de3..c7f0190e 100755
@@ -39,10 +39,12 @@ _cleanup()
 
  # get standard environment, filters and checks
  . ./common/rc
+. ./common/attr
 
  # real QA test starts here
  _supported_fs generic
  _require_scratch
+_require_attrs
  test "$FSTYP" = "overlay" && _notrun "Test does not apply to overlayfs."
  _require_extra_fs overlay
 
Signature · 1 line
2.30.2