selftests/exec: execveat: Improve debug reporting
Subsystems (3)
PATCH 1/1 selftests/exec: execveat: Improve debug reporting
Children processes were reporting their status, duplicating the parent's. Remove that, and add some additional details about the test execution.
---
Cc: Eric Biederman <[email protected]>
Cc: Shuah Khan <[email protected]>
Cc: Mark Brown <[email protected]>
Cc: Muhammad Usama Anjum <[email protected]>
Cc: [email protected]
Cc: [email protected]
--- tools/testing/selftests/exec/execveat.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)
tools/testing/selftests/exec/execveat.c +7 -5
@@ -98,10 +98,9 @@ static int check_execveat_invoked_rc(int fd, const char *path, int flags,if (child ==0 ) {/* Child: do execveat(). */ rc =execveat_ (fd, path, argv, envp, flags); -ksft_print_msg ("execveat() failed, rc=%d errno=%d (%s)\n" , +ksft_print_msg ("child execveat() failed, rc=%d errno=%d (%s)\n" , rc, errno,strerror (errno)); -ksft_test_result_fail ("%s\n" , test_name); -exit (1 );/* should not reach here */ +exit (errno); }/* Parent: wait for & check child's exit status. */ rc =waitpid (child, &status,0 );
@@ -226,11 +225,14 @@ static int check_execveat_pathmax(int root_dfd, const char *src, int is_script)* "If the command name is found, but it is not an executable utility, * the exit status shall be 126."), so allow either. */ -if (is_script) +if (is_script) { +ksft_print_msg ("Invoke script via root_dfd and relative filename\n" ); fail +=check_execveat_invoked_rc (root_dfd, longpath +1 ,0 ,127 ,126 ); -else + }else { +ksft_print_msg ("Invoke exec via root_dfd and relative filename\n" ); fail +=check_execveat (root_dfd, longpath +1 ,0 ); + }return fail; }
Signature · 1 line
2.34.1
Quoted 4 lines · Kees Cook
Children processes were reporting their status, duplicating the parent's. Remove that, and add some additional details about the test execution.
Quoted 8 lines
Signed-off-by Kees Cook <[email protected]>---
Cc: Eric Biederman <[email protected]>
Cc: Shuah Khan <[email protected]>
Cc: Mark Brown <[email protected]>
Cc: Muhammad Usama Anjum <[email protected]>
Cc: [email protected]
Cc: [email protected]
Quoted 38 lines
--- tools/testing/selftests/exec/execveat.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-)tools/testing/selftests/exec/execveat.c +7
-5@@ -98,10 +98,9 @@ static int check_execveat_invoked_rc(int fd, const char *path, int flags,if (child ==0 ) {/* Child: do execveat(). */ rc =execveat_ (fd, path, argv, envp, flags); -ksft_print_msg ("execveat() failed, rc=%d errno=%d (%s)\n" , +ksft_print_msg ("child execveat() failed, rc=%d errno=%d (%s)\n" , rc, errno,strerror (errno)); -ksft_test_result_fail ("%s\n" , test_name); -exit (1 );/* should not reach here */ +exit (errno); }/* Parent: wait for & check child's exit status. */ rc =waitpid (child, &status,0 );@@ -226,11 +225,14 @@ static int check_execveat_pathmax(int root_dfd, const char *src, int is_script)* "If the command name is found, but it is not an executable utility, * the exit status shall be 126."), so allow either. */ -if (is_script) +if (is_script) { +ksft_print_msg ("Invoke script via root_dfd and relative filename\n" ); fail +=check_execveat_invoked_rc (root_dfd, longpath +1 ,0 ,127 ,126 ); -else + }else { +ksft_print_msg ("Invoke exec via root_dfd and relative filename\n" ); fail +=check_execveat (root_dfd, longpath +1 ,0 ); + }return fail; }
Signature · 2 lines
BR, Muhammad Usama Anjum
Shuah Khan
maintainerQuoted 13 lines · Muhammad Usama Anjum
Quoted 4 lines · Kees Cook
Children processes were reporting their status, duplicating the parent's. Remove that, and add some additional details about the test execution.
Quoted 8 lines
Signed-off-by Kees Cook <[email protected]>---
Cc: Eric Biederman <[email protected]>
Cc: Shuah Khan <[email protected]>
Cc: Mark Brown <[email protected]>
Cc: Muhammad Usama Anjum <[email protected]>
Cc: [email protected]
Cc: [email protected]
Quoted 2 lines
Reviewed-by Muhammad Usama Anjum <[email protected]>
Applied to linux-kselftest fixes for the next rc.
thanks,
-- Shuah
Quoted 14 lines · Shuah Khan
Quoted 13 lines · Muhammad Usama Anjum
Quoted 12 lines · Kees Cook
Children processes were reporting their status, duplicating the parent's. Remove that, and add some additional details about the test execution.
Signed-off-by Kees Cook <[email protected]>---
Cc: Eric Biederman <[email protected]>
Cc: Shuah Khan <[email protected]>
Cc: Mark Brown <[email protected]>
Cc: Muhammad Usama Anjum <[email protected]>
Cc: [email protected]
Cc: [email protected]
Quoted 4 lines
Quoted 2 lines
Reviewed-by Muhammad Usama Anjum <[email protected]>Applied to linux-kselftest fixes for the next rc.
This is already part of the execve tree...
Signature · 1 line
Kees Cook
Shuah Khan
maintainerQuoted 15 lines · Kees Cook
Quoted 14 lines · Shuah Khan
Quoted 13 lines · Muhammad Usama Anjum
Quoted 12 lines · Kees Cook
Children processes were reporting their status, duplicating the parent's. Remove that, and add some additional details about the test execution.
Signed-off-by Kees Cook <[email protected]>---
Cc: Eric Biederman <[email protected]>
Cc: Shuah Khan <[email protected]>
Cc: Mark Brown <[email protected]>
Cc: Muhammad Usama Anjum <[email protected]>
Cc: [email protected]
Cc: [email protected]
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Reviewed-by Muhammad Usama Anjum <[email protected]>Applied to linux-kselftest fixes for the next rc.
This is already part of the execve tree...
Thanks. I will go drop it.
thanks,
-- Shuah