Skip to contentSkip to conversation

Rationale for paccept() sigset argument?

DISCUSSION Michael Kerrisk 2 participants 6 messages Aug 20, 2008 – Sep 11, 2008

lore
Share & tools
lore
#0 lore raw

Ulrich,

I'll need to cover this point in the man pages, and the rationale still isn't clear to me, so I'll check it with you...

2.6.27-rc has paccept():

int paccept(int fd, struct sockaddr *sockaddr, socklen_t *addrlen,
const sigset_t *sigmask, int setsize, int flags)

paccept() blocks until either a connection is received on fd, or a signal is sigmask() is caught.

What is the rationale for the sigset argument of paccept()?

For pselect()/ppoll()/epoll_pwait(), the sigset argument allows us to deal with a not uncommon situation: waiting for both signals and (multiple) file descriptors. (The alternative is the self-pipe trick, which requires more programming effort.)

However, do we really need this argument for paccept()? I ask this for the following reasons:

* This seems to be special casing for accept(). But there are other system calls (e.g., open(), connect(), recvfrom()) that are similar, in the sense that they may wait on a file descriptor, for which there is no [perceived need for a] sigset argument.

* It seems to me that any case where we might want to use paccept() could be equivalently dealt with using the existing pselect()/ppoll()/epoll_pwait() followed by a conventional accept() if the listening file descriptor indicates as ready. (But perhaps I missed something?)

Can you please explain why we need this special case for [p]accept()?

Cheers,

Michael

Signature · 4 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
man-pages online: http://www.kernel.org/doc/man-pages/online_pages.html
Found a bug? http://www.kernel.org/doc/man-pages/reporting_bugs.html
#1 lore raw

Ulrich -- Ping!

Quoted 48 lines · Michael Kerrisk

Ulrich,

I'll need to cover this point in the man pages, and the rationale still isn't
clear to me, so I'll check it with you...

2.6.27-rc has paccept():

int paccept(int fd, struct sockaddr *sockaddr, socklen_t *addrlen,
const sigset_t *sigmask, int setsize, int flags)

paccept() blocks until either a connection is received on fd, or a signal is sigmask() is caught.

What is the rationale for the sigset argument of paccept()?

For pselect()/ppoll()/epoll_pwait(), the sigset argument allows us to deal with a not uncommon situation: waiting for both signals and (multiple) file descriptors. (The alternative is the self-pipe trick, which requires more programming effort.)

However, do we really need this argument for paccept()? I ask this for the following reasons:

* This seems to be special casing for accept(). But there are other system calls (e.g., open(), connect(), recvfrom()) that are similar, in the sense that they may wait on a file descriptor, for which there is no [perceived need for a] sigset argument.

* It seems to me that any case where we might want to use paccept() could be equivalently dealt with using the existing pselect()/ppoll()/epoll_pwait() followed by a conventional accept() if the listening file descriptor indicates as ready. (But perhaps I missed something?)

Can you please explain why we need this special case for [p]accept()?

Cheers,

Michael

--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
man-pages online: http://www.kernel.org/doc/man-pages/online_pages.html
Found a bug? http://www.kernel.org/doc/man-pages/reporting_bugs.html

Signature · 4 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
man-pages online: http://www.kernel.org/doc/man-pages/online_pages.html
Found a bug? http://www.kernel.org/doc/man-pages/reporting_bugs.html
#2 lore raw
In reply to Michael Kerrisk
Quoted 1 line · Michael Kerrisk

What is the rationale for the sigset argument of paccept()?

accept, like select/poll, is used often as a function to dealy operation. Unlike read, recv, etc, which are handled using O_NONBLOCK and select/poll. pselect/ppoll do not really have a sigset parameter to handle signals in general. You use it to enable special handling in case of blocking. Example: if you want to implement userlevel context switching, you dedicate a signal to wake up any blocked thread. Since accept falls more into the same category than poll, this means the sigset parameter is justified. In theory we could add it to all functions but there is no reason to do this without any other reason to change the interface.

#3 lore raw
Quoted 4 lines · Ulrich Drepper
Quoted 1 line · Michael Kerrisk

What is the rationale for the sigset argument of paccept()?

Quoted 10 lines

accept, like select/poll, is used often as a function to dealy operation. Unlike read, recv, etc, which are handled using O_NONBLOCK and select/poll. pselect/ppoll do not really have a sigset parameter to handle signals in general. You use it to enable special handling in case of blocking. Example: if you want to implement userlevel context switching, you dedicate a signal to wake up any blocked thread. Since accept falls more into the same category than poll, this means the sigset parameter is justified. In theory we could add it to all functions but there is no reason to do this without any other reason to change the interface.

Ulrich, you snipped a relevant piece of my earlier message:

[[

Quoted 4 lines

* It seems to me that any case where we might want to use paccept() could be equivalently dealt with using the existing pselect()/ppoll()/epoll_pwait() followed by a conventional accept() if the listening file descriptor indicates as ready.

]]

So I'll rephrase: what use case does the sigset argument of paccept() allow us to handle that couldn't equally have been handled by pselect()/ppoll()/epoll_pwait() + traditional accept()?

Cheers,

Michael

Signature · 4 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
man-pages online: http://www.kernel.org/doc/man-pages/online_pages.html
Found a bug? http://www.kernel.org/doc/man-pages/reporting_bugs.html
#4 lore raw

Ulrich -- ping!

---------- Forwarded message ----------
From: Michael Kerrisk <[email protected]>
Date: Sep 2, 2008 9:58 AM
Subject: Re: Rationale for paccept() sigset argument?
To: Ulrich Drepper <[email protected]>
Cc: Michael Kerrisk <[email protected]>, Ulrich Drepper <[email protected]>, Davide Libenzi <[email protected]>, lkml <[email protected]>, Andrew Morton <[email protected]>, Jakub Jelinek <[email protected]>, Linus Torvalds <[email protected]>

Quoted 6 lines · Ulrich Drepper
Quoted 2 lines · Michael Kerrisk

What is the rationale for the sigset argument of paccept()?

Quoted 11 lines

accept, like select/poll, is used often as a function to dealy operation. Unlike read, recv, etc, which are handled using O_NONBLOCK and select/poll. pselect/ppoll do not really have a sigset parameter to handle signals in general. You use it to enable special handling in case of blocking. Example: if you want to implement userlevel context switching, you dedicate a signal to wake up any blocked thread. Since accept falls more into the same category than poll, this means the sigset parameter is justified. In theory we could add it to all functions but there is no reason to do this without any other reason to change the interface.

Ulrich, you snipped a relevant piece of my earlier message:

[[

Quoted 4 lines

* It seems to me that any case where we might want to use paccept() could be equivalently dealt with using the existing pselect()/ppoll()/epoll_pwait() followed by a conventional accept() if the listening file descriptor indicates as ready.

]]

So I'll rephrase: what use case does the sigset argument of paccept() allow us to handle that couldn't equally have been handled by pselect()/ppoll()/epoll_pwait() + traditional accept()?

Cheers,

Michael

#5 lore raw
In reply to Michael Kerrisk

[CC+=Roland]

Quoted 48 lines · Michael Kerrisk
Quoted 6 lines · Ulrich Drepper
Quoted 2 lines · Michael Kerrisk

What is the rationale for the sigset argument of paccept()?

Quoted 11 lines

accept, like select/poll, is used often as a function to dealy operation. Unlike read, recv, etc, which are handled using O_NONBLOCK and select/poll. pselect/ppoll do not really have a sigset parameter to handle signals in general. You use it to enable special handling in case of blocking. Example: if you want to implement userlevel context switching, you dedicate a signal to wake up any blocked thread. Since accept falls more into the same category than poll, this means the sigset parameter is justified. In theory we could add it to all functions but there is no reason to do this without any other reason to change the interface.

Ulrich, you snipped a relevant piece of my earlier message:

[[

Quoted 1 line

* It seems to me that any case where we might want to use paccept() could

be

Quoted 1 line

equivalently dealt with using the existing

pselect()/ppoll()/epoll_pwait()

Quoted 2 lines

followed by a conventional accept() if the listening file descriptor indicates as ready.

]]

So I'll rephrase: what use case does the sigset argument of paccept() allow us to handle that couldn't equally have been handled by pselect()/ppoll()/epoll_pwait() + traditional accept()?

Cheers,

Michael

--
Michael Kerrisk
Linux man-pages maintainer;
http://www.kernel.org/doc/man-pages/
man-pages online:
http://www.kernel.org/doc/man-pages/online_pages.html
Found a bug?
http://www.kernel.org/doc/man-pages/reporting_bugs.html