qt5base: Qt KMS support does not depend on opengl
PATCH v3 1/1 qt5base: Qt KMS support does not depend on opengl
Qt KMS support should not explicitly depend on the availability of opengl. Don't explicitly disable KMS if opengl is not available and fallback to detecting if libdrm is available before disabling kms.
The scenario where this is necessary involves using the Qt linuxfb backend "dumb buffer" support via the DRM API. This is new in Qt 5.9 [1] and only requires KMS, but not opengl.
[1] http://doc.qt.io/qt-5/embedded-linux.html#linuxfb
---
v3:
- Reorganize libdrm/egl make condition to be more clear.
v2:
- If libdrm is configured, make it an explicit dependency.
--- package/qt5/qt5base/qt5base.mk | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
package/qt5/qt5base/qt5base.mk +9 -2
@@ -35,12 +35,19 @@ endif QT5BASE_CONFIGURE_OPTS += $(call qstrip,$(BR2_PACKAGE_QT5BASE_CUSTOM_CONF_OPTS)) +ifeq ($(BR2_PACKAGE_LIBDRM),y) +QT5BASE_CONFIGURE_OPTS += -kms +QT5BASE_DEPENDENCIES += libdrm +else +QT5BASE_CONFIGURE_OPTS += -no-kms +endif + # Uses libgbm from mesa3d ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_EGL),y) -QT5BASE_CONFIGURE_OPTS += -kms -gbm +QT5BASE_CONFIGURE_OPTS += -gbm QT5BASE_DEPENDENCIES += mesa3d else -QT5BASE_CONFIGURE_OPTS += -no-kms +QT5BASE_CONFIGURE_OPTS += -no-gbm endif ifeq ($(BR2_ENABLE_DEBUG),y)
Signature · 1 line
2.7.4
PATCH v3 1/1 qt5base: Qt KMS support does not depend on opengl
Thomas,
Quoted 42 lines · Joshua Henderson
Qt KMS support should not explicitly depend on the availability of opengl. Don't explicitly disable KMS if opengl is not available and fallback to detecting if libdrm is available before disabling kms.
The scenario where this is necessary involves using the Qt linuxfb backend "dumb buffer" support via the DRM API. This is new in Qt 5.9 [1] and only requires KMS, but not opengl.
[1] http://doc.qt.io/qt-5/embedded-linux.html#linuxfb
Cc Peter Seiderer <[email protected]>Cc Julien Corjon <[email protected]>Signed-off-by Joshua Henderson <[email protected]>---
v3:
- Reorganize libdrm/egl make condition to be more clear.v2:
- If libdrm is configured, make it an explicit dependency.--- package/qt5/qt5base/qt5base.mk | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)package/qt5/qt5base/qt5base.mk +7
-0@@ -35,12 +35,19 @@ endif QT5BASE_CONFIGURE_OPTS += $(call qstrip,$(BR2_PACKAGE_QT5BASE_CUSTOM_CONF_OPTS)) +ifeq ($(BR2_PACKAGE_LIBDRM),y) +QT5BASE_CONFIGURE_OPTS += -kms +QT5BASE_DEPENDENCIES += libdrm +else +QT5BASE_CONFIGURE_OPTS += -no-kms +endif + # Uses libgbm from mesa3d
package/qt5/qt5base/qt5base.mk endif · line 53
Quoted 10 lines
package/qt5/qt5base/qt5base.mk +2
-2ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_EGL),y) -QT5BASE_CONFIGURE_OPTS += -kms -gbm +QT5BASE_CONFIGURE_OPTS += -gbm QT5BASE_DEPENDENCIES += mesa3d else -QT5BASE_CONFIGURE_OPTS += -no-kms +QT5BASE_CONFIGURE_OPTS += -no-gbm endif ifeq ($(BR2_ENABLE_DEBUG),y)
Ping. Have you had a chance to review this latest version in response to your feedback? What are the chances this can make it into a rev of 2018.02?
Josh
PATCH v3 1/1 qt5base: Qt KMS support does not depend on opengl
In reply to Joshua HendersonQuoted 7 lines · Joshua Henderson
Qt KMS support should not explicitly depend on the availability of opengl. Don't explicitly disable KMS if opengl is not available and fallback to detecting if libdrm is available before disabling kms.
The scenario where this is necessary involves using the Qt linuxfb backend "dumb buffer" support via the DRM API. This is new in Qt 5.9 [1] and only requires KMS, but not opengl.
?This sounds like we should handle the Qt 5.6 case specially.
?However, on Qt 5.6, it builds fine with the -kms option, it just ends up not being used. That means we have a redundant dependency on libdrm, but that doesn't matter that much. Handling the Qt 5.6 case differently would make the code quite a bit more complicated.
?Therefore, I explained the above in the commit log an applied to master, thanks.
?Sorry it took so long.
?Regards,
?Arnout
Quoted 41 lines
[1] http://doc.qt.io/qt-5/embedded-linux.html#linuxfb
Cc Peter Seiderer <[email protected]>Cc Julien Corjon <[email protected]>Signed-off-by Joshua Henderson <[email protected]>---
v3:
- Reorganize libdrm/egl make condition to be more clear.v2:
- If libdrm is configured, make it an explicit dependency.
---package/qt5/qt5base/qt5base.mk| 11 +++++++++--1 file changed, 9 insertions(+), 2 deletions(-)package/qt5/qt5base/qt5base.mk +8
-1@@ -35,12 +35,19 @@ endif QT5BASE_CONFIGURE_OPTS += $(call qstrip,$(BR2_PACKAGE_QT5BASE_CUSTOM_CONF_OPTS)) +ifeq ($(BR2_PACKAGE_LIBDRM),y) +QT5BASE_CONFIGURE_OPTS += -kms +QT5BASE_DEPENDENCIES += libdrm +else +QT5BASE_CONFIGURE_OPTS += -no-kms +endif + # Uses libgbm from mesa3d ifeq ($(BR2_PACKAGE_MESA3D_OPENGL_EGL),y) -QT5BASE_CONFIGURE_OPTS += -kms -gbm +QT5BASE_CONFIGURE_OPTS += -gbm
QT5BASE_DEPENDENCIES+= mesa3d
elsepackage/qt5/qt5base/qt5base.mk +1
-1-QT5BASE_CONFIGURE_OPTS += -no-kms +QT5BASE_CONFIGURE_OPTS += -no-gbmendif
ifeq ($(BR2_ENABLE_DEBUG),y)
PATCH v3 1/1 qt5base: Qt KMS support does not depend on opengl
Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnout" == Arnout Vandecappelle <[email protected]> writes:
Quoted 7 lines · Joshua Henderson
Qt KMS support should not explicitly depend on the availability of opengl. Don't explicitly disable KMS if opengl is not available and fallback to detecting if libdrm is available before disabling kms.
The scenario where this is necessary involves using the Qt linuxfb backend "dumb buffer" support via the DRM API. This is new in Qt 5.9 [1] and only requires KMS, but not opengl.
?This sounds like we should handle the Qt 5.6 case specially.
Quoted 8 lines
?However, on Qt 5.6, it builds fine with the -kms option, it just ends up not being used. That means we have a redundant dependency on libdrm, but that doesn't matter that much. Handling the Qt 5.6 case differently would make the code quite a bit more complicated.
?Therefore, I explained the above in the commit log an applied to master, thanks.
?Sorry it took so long.
Committed to 2018.02.x and 2018.08.x with the extended commit message, thanks.
Signature · 1 line
Bye, Peter Korsgaard
PATCH v3 1/1 qt5base: Qt KMS support does not depend on opengl
In reply to Arnout VandecappelleArnout,
Quoted 12 lines · Arnout Vandecappelle
Quoted 7 lines · Joshua Henderson
Qt KMS support should not explicitly depend on the availability of opengl. Don't explicitly disable KMS if opengl is not available and fallback to detecting if libdrm is available before disabling kms.
The scenario where this is necessary involves using the Qt linuxfb backend "dumb buffer" support via the DRM API. This is new in Qt 5.9 [1] and only requires KMS, but not opengl.
?This sounds like we should handle the Qt 5.6 case specially.
Quoted 8 lines
?However, on Qt 5.6, it builds fine with the -kms option, it just ends up not being used. That means we have a redundant dependency on libdrm, but that doesn't matter that much. Handling the Qt 5.6 case differently would make the code quite a bit more complicated.
?Therefore, I explained the above in the commit log an applied to master, thanks.
?Sorry it took so long.
No problem. Thanks Arnout.
Josh