Skip to contentSkip to conversation

block2mtd: logging typo fixes

PATCH In review Stephane Chazelas 2 participants 2 messages Feb 20, 2008 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 block2mtd: logging typo fixes

Hi joern,

this patch addresses a number of small issues mainly regarding the output made by this driver to dmesg:
- Some of the blkmtd's had not been changed to block2mtd which caused display problem
- the parse_err() macro was displaying "block2mtd: " twice

mtd/devices/block2mtd.c renamed from mtd/devices/block2mtd.c~ +5 -5
@@ -305,7 +305,7 @@ static struct block2mtd_dev *add_device(
 	}
 	list_add(&dev->list, &blkmtd_device_list);
 	INFO("mtd%d: [%s] erase_size = %dKiB [%d]", dev->mtd.index,
-			dev->mtd.name + strlen("blkmtd: "),
+			dev->mtd.name + strlen("block2mtd: "),
 			dev->mtd.erasesize >> 10, dev->mtd.erasesize);
 	return dev;
 
@@ -366,9 +366,9 @@ static inline void kill_final_newline(ch
 }
 
 
-#define parse_err(fmt, args...) do {		\
-	ERROR("block2mtd: " fmt "\n", ## args);	\
-	return 0;				\
+#define parse_err(fmt, args...) do {	\
+	ERROR(fmt, ## args);		\
+	return 0;			\
 } while (0)
 
 #ifndef MODULE
@@ -474,7 +474,7 @@ static void __devexit block2mtd_exit(voi
 		block2mtd_sync(&dev->mtd);
 		del_mtd_device(&dev->mtd);
 		INFO("mtd%d: [%s] removed", dev->mtd.index,
-				dev->mtd.name + strlen("blkmtd: "));
+				dev->mtd.name + strlen("block2mtd: "));
 		list_del(&dev->list);
 		block2mtd_free_device(dev);
 	}
Acked-by Joern Engel on v1 1/1
#1 lore raw
Quoted 8 lines · Stephane Chazelas

this patch addresses a number of small issues mainly regarding the output made by this driver to dmesg:
- Some of the blkmtd's had not been changed to block2mtd which caused display problem
- the parse_err() macro was displaying "block2mtd: " twice

David, please apply.

Jörn

Signature · 2 lines
"Error protection by error detection and correction."
-- from a university class