Skip to contentSkip to conversation

Fix failures of LSB.

PATCH In review Jingdong Lu 3 participants 8 messages Dec 21, 2010 – Dec 22, 2010

lore
Share & tools
lore
#0 lore raw

cover Fix failures of LSB.

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: jingdonglu/distro
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jingdonglu/distro

Thanks,
Jingdong Lu <[email protected]>
---

Jingdong Lu (3):
perl: Add GDBM_File into perl extension
gcc: Add "--enable-clocale=gnu" option explicitly
mailx: Add mailx

 meta/recipes-devtools/gcc/gcc-configure-common.inc |    2 +-
 meta/recipes-devtools/perl/perl-5.8.8/config.sh    |    2 +-
 meta/recipes-extended/mailx/mailx_12.4.bb          |   18 ++++++++++++++++++
 3 files changed, 20 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-extended/mailx/mailx_12.4.bb
#1 lore raw

PATCH 1/3 perl: Add GDBM_File into perl extension

Add GDBM_File into perl extension in config.sh in order to fix failure of lsb-perl-test.

---
 meta/recipes-devtools/perl/perl-5.8.8/config.sh |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta/recipes-devtools/perl/perl-5.8.8/config.sh +1 -1
index 3d4c193..49d5ab7 100644
@@ -522,7 +522,7 @@ endservent_r_proto='0'
 eunicefix=':'
 exe_ext=''
 expr='expr'
-extensions='attrs B ByteLoader Cwd Data/Dumper Devel/DProf Devel/Peek Devel/PPPort Digest/MD5 Encode Fcntl File/Glob Filter/Util/Call I18N/Langinfo IO IPC/SysV List/Util MIME/Base64 Opcode PerlIO/encoding PerlIO/scalar PerlIO/via POSIX re SDBM_File Socket Storable Sys/Hostname Sys/Syslog threads Time/HiRes Unicode/Normalize XS/APItest XS/Typemap threads/shared Errno'
+extensions='attrs B ByteLoader Cwd Data/Dumper Devel/DProf Devel/Peek Devel/PPPort Digest/MD5 Encode Fcntl File/Glob Filter/Util/Call I18N/Langinfo IO IPC/SysV List/Util MIME/Base64 Opcode PerlIO/encoding PerlIO/scalar PerlIO/via POSIX re GDBM_File SDBM_File Socket Storable Sys/Hostname Sys/Syslog threads Time/HiRes Unicode/Normalize XS/APItest XS/Typemap threads/shared Errno'
 extras=''
 fflushNULL='define'
 fflushall='undef'
Signature · 1 line
1.7.0.4
#2 lore raw

PATCH 2/3 gcc: Add "--enable-clocale=gnu" option explicitly

In reply to Jingdong Lu

Add "--enable-clocale=gun" option for gcc configuration explicitly in order to make sure C++ library can use correct locale module.

---
 meta/recipes-devtools/gcc/gcc-configure-common.inc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta/recipes-devtools/gcc/gcc-configure-common.inc +1 -1
index 4393777..b212fdc 100644
@@ -27,7 +27,7 @@ EXTRA_OECONF_INTERMEDIATE ?= ""
 
 GCCMULTILIB = "--disable-multilib"
 
-EXTRA_OECONF = "${@['--enable-clocale=generic', ''][bb.data.getVar('USE_NLS', d, 1) != 'no']} \
+EXTRA_OECONF = "${@['--enable-clocale=generic', ' --enable-clocale=gnu'][bb.data.getVar('USE_NLS', d, 1) != 'no']} \
                 --with-gnu-ld \
                 --enable-shared \
                 --enable-languages=${LANGUAGES} \
Signature · 1 line
1.7.0.4
#3 lore raw

PATCH 3/3 mailx: Add mailx

In reply to Jingdong Lu
---
 meta/recipes-extended/mailx/mailx_12.4.bb |   18 ++++++++++++++++++
 1 files changed, 18 insertions(+), 0 deletions(-)
 create mode 100644 meta/recipes-extended/mailx/mailx_12.4.bb
meta/recipes-extended/mailx/mailx_12.4.bb new file +18 -0
new file mode 100644
index 0000000..eb8109a
@@ -0,0 +1,18 @@
+DESCRIPTION = "Mailx is an enhanced mail command, which provides the functionality \
+of the POSIX mailx command, as well as SysV mail and Berkeley Mail \
+(from which it is derived)."
+HOMEPAGE = "http://heirloom.sourceforge.net/mailx.html"
+SECTION = "console/network"
+
+PRIORITY = "required"
+LICENSE = "BSD with advertising and MPLv1.1"
+PR = "r0"
+
+#COPYING or Licence
+LIC_FILES_CHKSUM = "file://COPYING;md5=4202a0a62910cf94f7af8a3436a2a2dd"
+
+SRC_URI = "http://downloads.sourceforge.net/heirloom/mailx-12.4.tar.bz2 \
+          "
+do_install() {
+       make DESTDIR=${D} PREFIX=/usr UCBINSTALL=install install
+}
Signature · 1 line
1.7.0.4
#4 lore raw
In reply to Jingdong Lu
Quoted 8 lines · Jingdong Lu

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: jingdonglu/distro
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jingdonglu/distro

Thanks,
Jingdong Lu<[email protected]>
---

Jingdong,

Why do you need the do_install? Can the standard do_install not work correctly for this recipe?

Thanks
Sau!

Quoted 7 lines

Jingdong Lu (3):
perl: Add GDBM_File into perl extension
gcc: Add "--enable-clocale=gnu" option explicitly
mailx: Add mailx

  meta/recipes-devtools/gcc/gcc-configure-common.inc |    2 +-

We are reviewing the impact of the gcc clocale=gnu

Quoted 1 line
  meta/recipes-devtools/perl/perl-5.8.8/config.sh    |    2 +-

This on is OK

Quoted 1 line
  meta/recipes-extended/mailx/mailx_12.4.bb          |   18 ++++++++++++++++++

Can you please add a SUMMARY and SRC_URI checksums to the mailx recipe.

Is the PREFIX=/usr correct? I note in other there is a ${D} or ${D}${prefix}, please make sure you have the correct location here.

Please re-sumbit a v2 patch set.

Sau!

Quoted 8 lines
  3 files changed, 20 insertions(+), 2 deletions(-)

create mode 100644 meta/recipes-extended/mailx/mailx_12.4.bb

_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky

#5 lore raw
Quoted 11 lines · Saul Wold
Quoted 9 lines · Jingdong Lu

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: jingdonglu/distro
Browse:
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jingdonglu/distro

Thanks,
Jingdong Lu<[email protected]>
---

Quoted 5 lines

Jingdong,

Why do you need the do_install? Can the standard do_install not work correctly for this recipe?

Because we need add some options to make install, eg, UCBINSTALL=install, I didn't use standard do_install.

Quoted 5 lines
  meta/recipes-extended/mailx/mailx_12.4.bb          |   18 

++++++++++++++++++
Can you please add a SUMMARY and SRC_URI checksums to the mailx recipe.

Is the PREFIX=/usr correct? I note in other there is a ${D} or ${D}${prefix}, please make sure you have the correct location here.

Because the default value of PREFIX is /usr/local in Makefile, I change it into /usr and give this option.

Quoted 2 lines

Please re-sumbit a v2 patch set.

I re-submit patch set.
Thank you!

Quoted 2 lines
Signature · 3 lines
Lu Jingdong
[email protected]
China, Wind River
#6 lore raw
Quoted 4 lines · Lu Jingdong
Quoted 2 lines

Is the PREFIX=/usr correct? I note in other there is a ${D} or ${D}${prefix}, please make sure you have the correct location here.

Because the default value of PREFIX is /usr/local in Makefile, I change it into /usr and give this option.

I'd suggest using PREFIX=${prefix} and then if someone wants the change the layout using our standard variables, they can.

Cheers,

Richard

#7 lore raw
In reply to Lu Jingdong
Quoted 12 lines · Lu Jingdong
Quoted 11 lines · Saul Wold
Quoted 9 lines · Jingdong Lu

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: jingdonglu/distro
Browse:
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jingdonglu/distro

Thanks,
Jingdong Lu<[email protected]>
---

Quoted 12 lines
Quoted 6 lines

Jingdong,

Why do you need the do_install? Can the standard do_install not work correctly for this recipe?

Because we need add some options to make install, eg, UCBINSTALL=install, I didn't use standard do_install.

Quoted 3 lines

meta/recipes-extended/mailx/mailx_12.4.bb | 18 ++++++++++++++++++ Can you please add a SUMMARY and SRC_URI checksums to the mailx recipe.

Jingdong,

You added SRC_URI Checksums, but not the SUMMARY, also see Richard's comments about using ${prefix}, please re-submit a v3 of this patch.

Sau!

Quoted 12 lines
Quoted 2 lines

Is the PREFIX=/usr correct? I note in other there is a ${D} or ${D}${prefix}, please make sure you have the correct location here.

Because the default value of PREFIX is /usr/local in Makefile, I change it into /usr and give this option.

Quoted 2 lines

Please re-sumbit a v2 patch set.

I re-submit patch set.
Thank you!

Quoted 2 lines