Skip to contentSkip to conversation

Remove sanity check for i686

PATCH In review Jessica Zhang 2 participants 3 messages Jan 17, 2011 – Jan 18, 2011

lore
Share & tools
lore
#0 lore raw

cover Remove sanity check for i686

I've tested against a newly built toolchain with host as i686 and target as i586 and used the toolchain cross compile cvs(c) and suduku(c++) applications and ran them on the target without issues.

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: jzhang/bitbake_i686
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jzhang/bitbake_i686

Thanks,
Jessica Zhang <[email protected]>
---

Jessica Zhang (1):
remove sanity check for SDK_ARCH=i686 due to recent fixes in cross
toolchain areas, etc. the old issue no longer exists

 meta/classes/sanity.bbclass |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
#1 lore raw

PATCH 1/1 remove sanity check for SDK_ARCH=i686 due to recent fixes in cross toolchain areas, etc. the old issue no longer exists

---
 meta/classes/sanity.bbclass |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
meta/classes/sanity.bbclass +0 -3
index 9d183e3..c66015e 100644
@@ -196,9 +196,6 @@ def check_sanity(e):
     if not oes_bb_conf:
         messages = messages + 'You do not include OpenEmbeddeds version of conf/bitbake.conf. This means your environment is misconfigured, in particular check BBPATH.\n'
 
-    if data.getVar('SDK_ARCH', e.data, True) == 'i686':
-        messages = messages + '"Please set SDKMACHINE to i586. It is currently defaulting to the build machine architecture of i686 and this is known to have issues (see local.conf).\n'
-
     nolibs = data.getVar('NO32LIBS', e.data, True)
     if not nolibs:
         lib32path = '/lib'
Signature · 1 line
1.7.0.4
#2 lore raw
In reply to Jessica Zhang
Quoted 6 lines · Jessica Zhang

I've tested against a newly built toolchain with host as i686 and target as i586 and used the toolchain cross compile cvs(c) and suduku(c++) applications and ran them on the target without issues.

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: jzhang/bitbake_i686
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jzhang/bitbake_i686

Quoted 9 lines

Thanks,
Jessica Zhang<[email protected]>
---

Jessica Zhang (1):
remove sanity check for SDK_ARCH=i686 due to recent fixes in cross
toolchain areas, etc. the old issue no longer exists

Jessica:

Can you re-submit this with a more correct subject line, the format is typically:

<recipe/bbclass>: short synopsis
[Blank Line]
Longer Description of fix if needed

Signed-off-by ...

For example this one might be:

sanity.bbclass: remove SDK_ARCH Check

remove sanity check for SDK_ARCH=i686 due to recent fixes in cross toolchain areas, etc. the old issue no longer exists

Thanks
Sau!

Quoted 8 lines
  meta/classes/sanity.bbclass |    3 ---
  1 files changed, 0 insertions(+), 3 deletions(-)

_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky