Skip to contentSkip to conversation

send-pull-request bugfix

PATCH In review Scott Garman 3 participants 4 messages Jan 22, 2011 – Jan 28, 2011

lore
Share & tools
lore

Scott Garman

author
#0 lore raw

cover send-pull-request bugfix

Hi Saul,

Darren Hart and I discovered that when $CC is set (which our meta-toolchain environment script sets up), the value leaks into the use of this script. Unsetting $TO as well just to be thorough. This pull request fixes that.

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: sgarman/pull-request-fix
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=sgarman/pull-request-fix

Thanks,
Scott Garman <[email protected]>
---

Scott Garman (1):
send-pull-request: unset $TO and $CC from environment

 scripts/send-pull-request |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
author
#1 lore raw

PATCH 1/1 send-pull-request: unset $TO and $CC from environment

Darren Hart and I discovered that when $CC is set (which our meta-toolchain environment script sets up), the value leaks into the use of this script. Unsetting $TO as well just to be thorough.

Signed-off-by Scott Garman <[email protected]>
---
 scripts/send-pull-request |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
scripts/send-pull-request +4 -0
index 9872c0d..a66d4dc 100755
@@ -6,6 +6,10 @@ if [ -z "$PULL_MTA" ]; then
     PULL_MTA="sendmail"
 fi
 
+# Prevent environment leakage to these vars.
+unset TO
+unset CC
+
 usage()
 {
 cat <<EOM
Signature · 1 line
1.7.1
Acked-by on v1 1/1
#2 lore raw

Re: [PATCH 1/1] send-pull-request: unset $TO and $CC from environment

Quoted 6 lines · Scott Garman

Darren Hart and I discovered that when $CC is set (which our meta-toolchain environment script sets up), the value leaks into the use of this script. Unsetting $TO as well just to be thorough.

Signed-off-by Scott Garman<[email protected]>

Thanks Scott!

Acked-by Darren Hart <[email protected]>
Quoted 19 lines
---
  scripts/send-pull-request |    4 ++++
  1 files changed, 4 insertions(+), 0 deletions(-)
scripts/send-pull-request +4 -0
index 9872c0d..a66d4dc 100755
@@ -6,6 +6,10 @@ if [ -z "$PULL_MTA" ]; then
      PULL_MTA="sendmail"
  fi
 
+# Prevent environment leakage to these vars.
+unset TO
+unset CC
+
  usage()
  {
  cat<<EOM
Signature · 3 lines
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
#3 lore raw
In reply to Scott Garman
Quoted 19 lines · Scott Garman

Hi Saul,

Darren Hart and I discovered that when $CC is set (which our meta-toolchain environment script sets up), the value leaks into the use of this script. Unsetting $TO as well just to be thorough. This pull request fixes that.

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: sgarman/pull-request-fix
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=sgarman/pull-request-fix

Thanks,
Scott Garman<[email protected]>
---

Scott Garman (1):
send-pull-request: unset $TO and $CC from environment

Quoted 8 lines
  scripts/send-pull-request |    4 ++++
  1 files changed, 4 insertions(+), 0 deletions(-)

_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky

Pulled into Master

Thanks
Sau!