Skip to contentSkip to conversation

ADT: bug fix for nameing and do_patch sequence

PATCH In review Liping Ke 1 participant 3 messages Mar 17, 2011

lore
Share & tools
lore

Liping Ke

author
#0 lore raw

cover ADT: bug fix for nameing and do_patch sequence

From: Liping Ke <[email protected]>

This patch is for fixing the x86-64 image name bug and also, do_patch must be down before do_deploy.

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: lke/seq_fix
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=lke/seq_fix

Thanks,
Liping Ke <[email protected]>
---

Liping Ke (1):
ADT: bug fix for nameing and do_patch sequence

 .../installer/adt-installer/adt_installer          |   13 ++++++++-----
 .../adt-installer/scripts/adt_installer_internal   |    6 +++---
 .../installer/adt-installer_1.0.bb                 |    2 +-
 3 files changed, 12 insertions(+), 9 deletions(-)
author
#1 lore raw

PATCH 1/1 ADT: bug fix for nameing and do_patch sequence

From: Liping Ke <[email protected]>

This patch is for fixing the x86-64 image name bug and also, do_patch must be down before do_deploy.

Signed-off-by Liping Ke <[email protected]>
---
 .../installer/adt-installer/adt_installer          |   13 ++++++++-----
 .../adt-installer/scripts/adt_installer_internal   |    6 +++---
 .../installer/adt-installer_1.0.bb                 |    2 +-
 3 files changed, 12 insertions(+), 9 deletions(-)
meta/recipes-devtools/installer/adt-installer/adt_installer +8 -5
index b1b4970..d7a40c2 100755
@@ -236,12 +236,15 @@ wget "$YOCTOADT_IPKG_REPO/$1" -P $LOCAL_DOWNLOAD --progress=bar:force 2>&1 | tee
 #Need two input params, $1 -- arch_type(arm powerpc x86 mips) $2 rootfs_image_type (a list of sdk sato minimal lsb)
 get_qemu_image()
 {
-  if [ "$1" == "x86" ]; then
-    qemu_kernel="bzImage-qemu$1.bin"
+ 
+  local target=`echo "$1" | sed -e 's/x86_64/x86-64/'`
+
+  if [ "$1" == "x86" ] || [ "$1" == "x86_64" ]; then
+    qemu_kernel="bzImage-qemu$target.bin"
   elif [ "$1" == "mips" ]; then
-    qemu_kernel="vmlinux-qemu$1.bin"
+    qemu_kernel="vmlinux-qemu$target.bin"
   else
-    qemu_kernel="zImage-qemu$1.bin"
+    qemu_kernel="zImage-qemu$target.bin"
   fi
 
   #echo_info "[ADT_INST] Downloading qemu kernel binary: $qemu_kernel"

@@ -250,7 +253,7 @@ get_qemu_image()
   
   for image_type in $select_rootfs; do
     #echo_info "[ADT_INST] Downloading rootfs file: poky-image-$image_type-qemu$1.tar.bz2"
-    filename="poky-image-$image_type-qemu$1.tar.bz2"
+    filename="poky-image-$image_type-qemu$target.tar.bz2"
     download_file qemu$1/$filename
     check_result
   done
meta/recipes-devtools/installer/adt-installer/scripts/adt_installer_internal +3 -3
index e1d4e63..65b1b54 100755
@@ -170,7 +170,9 @@ fi
 
 echo_info "Installing target sysroot for arch: $1, rootfs type: $target_sysroot_image, location: $target_sysroot"
 
-sysroot_image_name="poky-image-$target_sysroot_image-qemu$1.tar.bz2"
+
+qemu_type=`echo "$1" | sed -e 's/x86_64/x86-64/'`
+sysroot_image_name="poky-image-$target_sysroot_image-qemu$qemu_type.tar.bz2"
     #echo_info "Extracting rootfs: $sysroot_image_name, using pseudo..."
 
 scripts/extract_rootfs $sysroot_image_name $target_sysroot $POKY_NATIVE_SYSROOT $user_inst_type

@@ -179,8 +181,6 @@ check_result
 echo_info "Updating environment script with target sysroot location."
 if [ "$1" == "x86"  ]; then
   env_filename=`ls $INSTALL_FOLDER/environment-setup-i586*`
-elif [ "$1" == "ppc"  ]; then
-  env_filename=`ls $INSTALL_FOLDER/environment-setup-powerpc*`
 else
   env_filename=`ls $INSTALL_FOLDER/environment-setup-$1*`
 fi
meta/recipes-devtools/installer/adt-installer_1.0.bb +1 -1
index ff7afe6..7e82c92 100644
@@ -82,4 +82,4 @@ do_package_write_rpm[noexec] = "1"
 do_package_write_deb[noexec] = "1"
 do_poplulate_sysroot[noexec] = "1"
 
-addtask deploy before do_populate_sysroot after do_unpack
+addtask deploy before do_populate_sysroot after do_patch
Signature · 1 line
1.7.0.4
author
#2 lore raw
In reply to Liping Ke

Hi, Saul

Now adt-installer tarball has been tested under both x86 and x86-64 host for all target archs (arm, x86, x86_64, arm, ppc). So all naming problems should have been fixed and tested.

There is a typo in the comment line "down->done". The patch in the contrib tree was already corrected. So just skip this typo in the patch notification mail.

Thanks a lot!
criping

Quoted 37 lines

-----Original Message-----
From: [email protected] [mailto:poky- [email protected]] On Behalf Of Liping Ke
Sent: Thursday, March 17, 2011 1:21 PM
To: [email protected]
Subject: [poky] [PATCH 0/1] ADT: bug fix for nameing and do_patch sequence

From: Liping Ke <[email protected]>

This patch is for fixing the x86-64 image name bug and also, do_patch must be down before do_deploy.

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: lke/seq_fix
Browse: http://git.pokylinux.org/cgit.cgi/poky-
contrib/log/?h=lke/seq_fix

Thanks,
Liping Ke <[email protected]>
---

Liping Ke (1):
ADT: bug fix for nameing and do_patch sequence

 .../installer/adt-installer/adt_installer          |   13 ++++++++----
-
 .../adt-installer/scripts/adt_installer_internal   |    6 +++---
 .../installer/adt-installer_1.0.bb                 |    2 +-
 3 files changed, 12 insertions(+), 9 deletions(-)

_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky