Skip to contentSkip to conversation

bonding:delete two unused variables

PATCH Applied Weiping Pan(潘卫平) 3 participants 5 messages Apr 11, 2011

Subsystems (3)
Networking Network drivers Bonding driver
lore
Share & tools
lore

Weiping Pan(潘卫平)

author
#0 lore raw

cover bonding:delete two unused variables

I found that variable alb_timer and rlb_interval_counter in struct alb_bond_info are not used by other codes any more, so delete them.

Weiping Pan(潘卫平) (2):
bonding:delete unused alb_timer
bonding:delete unused rlb_interval_counter

 drivers/net/bonding/bond_alb.h |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.4
author
#1 lore raw

PATCH 1/2 bonding:delete unused alb_timer

Now bonding-alb uses delayed_work instead of timer_list.

Signed-off-by Weiping Pan(潘卫平) <[email protected]>
---
 drivers/net/bonding/bond_alb.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/bonding/bond_alb.h +0 -1
index 86861f0..f2a1d0a 100644
@@ -122,7 +122,6 @@ struct tlb_slave_info {
 };
 
 struct alb_bond_info {
-	struct timer_list	alb_timer;
 	struct tlb_client_info	*tx_hashtbl; /* Dynamically allocated */
 	spinlock_t		tx_hashtbl_lock;
 	u32			unbalanced_load;
Signature · 1 line
1.7.4
author
#2 lore raw

PATCH 2/2 bonding:delete unused rlb_interval_counter

In reply to Weiping Pan(潘卫平)

Now, alb_bond_info uses rx_ntt,rlb_update_delay_counter and rlb_update_retry_counter to decide when to call rlb_update_rx_clients().

Signed-off-by Weiping Pan(潘卫平) <[email protected]>
---
 drivers/net/bonding/bond_alb.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/bonding/bond_alb.h +0 -1
index f2a1d0a..01ed1fb 100644
@@ -139,7 +139,6 @@ struct alb_bond_info {
 	struct slave		*next_rx_slave;/* next slave to be assigned
 						* to a new rx client for
 						*/
-	u32			rlb_interval_counter;
 	u8			primary_is_promisc;	   /* boolean */
 	u32			rlb_promisc_timeout_counter;/* counts primary
 							     * promiscuity time
Signature · 1 line
1.7.4
#3 lore raw
In reply to Weiping Pan(潘卫平)
Quoted 7 lines

I found that variable alb_timer and rlb_interval_counter in struct alb_bond_info are not used by other codes any more, so delete them.

Weiping Pan(潘卫平) (2):
bonding:delete unused alb_timer
bonding:delete unused rlb_interval_counter

For both patches.

Signed-off-by Jay Vosburgh <[email protected]>
Quoted 10 lines

drivers/net/bonding/bond_alb.h | 2 --

1 files changed, 0 insertions(+), 2 deletions(-)
Signature · 6 lines
1.7.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
maintainer Applied
#4 lore raw

From: Jay Vosburgh <[email protected]>
Date: Mon, 11 Apr 2011 12:02:09 -0700

Quoted 11 lines
Quoted 7 lines

I found that variable alb_timer and rlb_interval_counter in struct alb_bond_info are not used by other codes any more, so delete them.

Weiping Pan(潘卫平) (2):
bonding:delete unused alb_timer
bonding:delete unused rlb_interval_counter

For both patches.

Signed-off-by Jay Vosburgh <[email protected]>

Applied.