Skip to contentSkip to conversation

qt4: Fix [# 1020]

PATCH In review Xiaofeng Yan 3 participants 5 messages May 4, 2011 – May 9, 2011

lore
Share & tools
lore
#0 lore raw

cover qt4: Fix [# 1020]

From: Xiaofeng Yan <[email protected]>

libQtOpenGL.so is needed by lsb test for mpc8315e-rdb

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: xiaofeng/distro
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/distro

Thanks,
Xiaofeng Yan <[email protected]>
---

Xiaofeng Yan (1):
qt4: Enable qt4 opengl for ppc

 meta/recipes-qt/qt4/qt4-x11-free.inc |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
#1 lore raw

PATCH 1/1 qt4: Enable qt4 opengl for ppc

From: Xiaofeng Yan <[email protected]>

Fix [# 1020]

---
 meta/recipes-qt/qt4/qt4-x11-free.inc |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
meta/recipes-qt/qt4/qt4-x11-free.inc +1 -0
index ba08dc8..a711288 100644
@@ -13,6 +13,7 @@ QT_GLFLAGS_qemux86 = "-opengl"
 QT_GLFLAGS_emenlow = "-opengl"
 QT_GLFLAGS_atom-pc = "-opengl"
 QT_GLFLAGS_qemuppc = "-opengl"
+QT_GLFLAGS_mpc8315e-rdb = "-opengl"
 QT_CONFIG_FLAGS += "-no-xinerama -no-xkb ${QT_GLFLAGS}"
 QT_BASE_NAME ?= "qt4"
 QT_BASE_LIB  ?= "libqt"
Signature · 1 line
1.7.0.4
#2 lore raw

Re: [PATCH 1/1] qt4: Enable qt4 opengl for ppc

Quoted 14 lines · Xiaofeng Yan

From: Xiaofeng Yan <[email protected]>

Fix [# 1020]

---
 meta/recipes-qt/qt4/qt4-x11-free.inc |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
meta/recipes-qt/qt4/qt4-x11-free.inc +0 -0
index ba08dc8..a711288 100644

meta/recipes-qt/qt4/qt4-x11-free.inc QT_GLFLAGS_qemux86 = "-opengl" · line 19

Quoted 7 lines
meta/recipes-qt/qt4/qt4-x11-free.inc +1 -0
@@ -13,6 +13,7 @@ QT_GLFLAGS_qemux86 = "-opengl"
 QT_GLFLAGS_emenlow = "-opengl"
 QT_GLFLAGS_atom-pc = "-opengl"
 QT_GLFLAGS_qemuppc = "-opengl"
+QT_GLFLAGS_mpc8315e-rdb = "-opengl"
 QT_CONFIG_FLAGS += "-no-xinerama -no-xkb ${QT_GLFLAGS}"
 QT_BASE_NAME ?= "qt4"
 QT_BASE_LIB  ?= "libqt"

Can we use more generic overrides here? Otherwise we'll just fail on the next powerpc board.

Signature · 2 lines
Tom Rini
Mentor Graphics Corporation
#3 lore raw

Re: [PATCH 1/1] qt4: Enable qt4 opengl for ppc

Quoted 10 lines · Tom Rini
Quoted 9 lines · Xiaofeng Yan

From: Xiaofeng Yan<[email protected]>

Fix [# 1020]

---
  meta/recipes-qt/qt4/qt4-x11-free.inc |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 16 lines

meta/recipes-qt/qt4/qt4-x11-free.inc QT_GLFLAGS_qemux86 = "-opengl" · line 19

Quoted 12 lines
meta/recipes-qt/qt4/qt4-x11-free.inc +1 -0
index ba08dc8..a711288 100644
@@ -13,6 +13,7 @@ QT_GLFLAGS_qemux86 = "-opengl"
  QT_GLFLAGS_emenlow = "-opengl"
  QT_GLFLAGS_atom-pc = "-opengl"
  QT_GLFLAGS_qemuppc = "-opengl"
+QT_GLFLAGS_mpc8315e-rdb = "-opengl"
  QT_CONFIG_FLAGS += "-no-xinerama -no-xkb ${QT_GLFLAGS}"
  QT_BASE_NAME ?= "qt4"
  QT_BASE_LIB  ?= "libqt"

Can we use more generic overrides here? Otherwise we'll just fail on the next powerpc board.

Xiaofeng,

Now that we have re-factored and these changes will meta-yocto or in BSP .bbappend files. Can you make a more appropriate change that also take the above comment into account.

Thanks
Sau!

#4 lore raw

Re: [PATCH 1/1] qt4: Enable qt4 opengl for ppc

In reply to Xiaofeng Yan
Quoted 4 lines · Xiaofeng Yan

From: Xiaofeng Yan<[email protected]>

Fix [# 1020]

I am going to hold this one for a little while due to some other work in refactoring where hardware specific changes go.

Also your comment should include [YOCTO #1020], not just the bug number.

Quoted 17 lines
---
  meta/recipes-qt/qt4/qt4-x11-free.inc |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
meta/recipes-qt/qt4/qt4-x11-free.inc +1 -0
index ba08dc8..a711288 100644
@@ -13,6 +13,7 @@ QT_GLFLAGS_qemux86 = "-opengl"
  QT_GLFLAGS_emenlow = "-opengl"
  QT_GLFLAGS_atom-pc = "-opengl"
  QT_GLFLAGS_qemuppc = "-opengl"
+QT_GLFLAGS_mpc8315e-rdb = "-opengl"
  QT_CONFIG_FLAGS += "-no-xinerama -no-xkb ${QT_GLFLAGS}"
  QT_BASE_NAME ?= "qt4"
  QT_BASE_LIB  ?= "libqt"