kern-tools: error if features are not found

PATCH Applied Bruce Ashfield 3 participants 4 messages May 12, 2011 – May 13, 2011

lore

Share & tools

lore

Bruce Ashfield

author

2011-05-12 20:19 UTC #0 lore raw

cover kern-tools: error if features are not found

Richard/Saul,

I'll repeat the patch contents here, since they explain the change

---->---->---->---->---->---->
Fixes bug: [YOCTO #955]

Updating the SRCREV to pickup the kern-tools change:

[
updateme: error if features are not found

Rather than silently dropping addon features, we emit a warning and then exit with a failure code. The caller can then abort a build and not simply miss features.

Passing --no-strict to the script disables this new functionality if for some reason a feature description is missing on purpose.
]
---->---->---->---->---->---->

This takes care of one thing we hit during 1.0 development, and provides a clear message about features that are not part of the kernel being built.

In a test of a forced invalid feature, the output is:

| WARNING: addon feature "cfg/non-exisistent" was not found | ERROR: required features were not found. aborting

.. and the build stops.

Thanks,
Bruce Ashfield <[email protected]>

Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: zedd/kernel
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/kernel

---

Bruce Ashfield (1):
kern-tools: error if features are not found

 .../kern-tools/kern-tools-native_git.bb            |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Bruce Ashfield

author

2011-05-12 20:19 UTC #1 lore raw

PATCH 1/1 kern-tools: error if features are not found

Richard/Saul,

I'll just repeat the patch contents here:

Fixes bug: [YOCTO #955]

Updating the SRCREV to pickup the kern-tools change:

[
updateme: error if features are not found

Rather than silently dropping addon features, we emit a warning and then exit with a failure code. The caller can then abort a build and not simply miss features.

Passing --no-strict to the script disables this new functionality if for some reason a feature description is missing on purpose.
]

We ran into this during 1.0 development, if someone tags an extra feature into a bbapend (or wherever) and that feature isn't valid they get a log to the console, and the build stops.

Signed-off-by Bruce Ashfield <[email protected]>

---
 .../kern-tools/kern-tools-native_git.bb            |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

meta/recipes-kernel/kern-tools/kern-tools-native_git.bb +1 -1

index c808e17..829d105 100644
@@ -4,7 +4,7 @@ LIC_FILES_CHKSUM = "file://git/tools/kgit;beginline=5;endline=9;md5=e2bf4415f3d8
 
 DEPENDS = "git-native guilt-native"
 
-SRCREV = "ab49d8e48b7e66d1b4f924385d65d062d25e44f7"
+SRCREV = "ecbdf3cdf6705a63dcb3c50bb24c311046f0b35c"
 PR = r10
 PV = "0.1+git${SRCPV}"

Signature · 1 line

1.7.0.4

Bruce Ashfield

2011-05-12 20:22 UTC #2 lore raw

Quoted 15 lines · Bruce Ashfield

Richard/Saul,
I'll just repeat the patch contents here:
Fixes bug: [YOCTO #955]
Updating the SRCREV to pickup the kern-tools change:
[
updateme: error if features are not found
Rather than silently dropping addon features, we emit a warning and then exit with a failure code. The caller can then abort a build and not simply miss features.

Quoted 7 lines

Passing --no-strict to the script disables this new functionality if for some reason a feature description is missing on purpose. ]
We ran into this during 1.0 development, if someone tags an extra feature into a bbapend (or wherever) and that feature isn't valid they get a log to the console, and the build stops.

Urk. I have no idea what happened here :) This is NOT the real content of the patch commit message.

Bruce

Quoted 28 lines

Signed-off-by Bruce Ashfield <[email protected]>
---
.../kern-tools/kern-tools-native_git.bb | 2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta/recipes-kernel/kern-tools/kern-tools-native_git.bb +0 -0
index c808e17..829d105 100644
@@ -4,7 +4,7 @@ LIC_FILES_CHKSUM = "file://git/tools/kgit;beginline=5;endline=9;md5=e2bf4415f3d8
 
DEPENDS = "git-native guilt-native"
meta/recipes-kernel/kern-tools/kern-tools-native_git.bb +1 -1
-SRCREV = "ab49d8e48b7e66d1b4f924385d65d062d25e44f7"
+SRCREV = "ecbdf3cdf6705a63dcb3c50bb24c311046f0b35c"
PR = r10
PV = "0.1+git${SRCPV}"
--
1.7.0.4
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Signature · 2 lines

"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"

Saul Wold

Applied

2011-05-13 22:16 UTC #3 lore raw

In reply to Bruce Ashfield

Quoted 46 lines · Bruce Ashfield

Richard/Saul,
I'll repeat the patch contents here, since they explain the change
---->---->---->---->---->---->
Fixes bug: [YOCTO #955]
Updating the SRCREV to pickup the kern-tools change:
[
updateme: error if features are not found
Rather than silently dropping addon features, we emit a warning and then exit with a failure code. The caller can then abort a build and not simply miss features.
Passing --no-strict to the script disables this new functionality if for some reason a feature description is missing on purpose.
]
---->---->---->---->---->---->
This takes care of one thing we hit during 1.0 development, and provides a clear message about features that are not part of the kernel being built.
In a test of a forced invalid feature, the output is:
| WARNING: addon feature "cfg/non-exisistent" was not found | ERROR: required features were not found. aborting
.. and the build stops.
Thanks,
Bruce Ashfield<[email protected]>
Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: zedd/kernel
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/kernel
---
Bruce Ashfield (1):
kern-tools: error if features are not found

Quoted 9 lines

  .../kern-tools/kern-tools-native_git.bb            |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Merged into oe-core and master.

Thanks
Sau!