crownbay fixes
cover crownbay fixes
From: Tom Zanussi <[email protected]>
This fixes bug 986 for crownbay, crownbay-noemgd and fishriver - thanks to Saul Wold for pointing out a fix for it.
It also adds a missing COMPATIBLE_MACHINE entry for crownbay-noemgd.
Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: tzanussi/bugfix-986
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=tzanussi/bugfix-986
Thanks,
Tom Zanussi <[email protected]>
---
Tom Zanussi (4):
crownbay: remove custom BASE_PACKAGE_ARCH and PACKAGE_EXTRA_ARCHS
crownbay-noemgd: remove custom BASE_PACKAGE_ARCH and
PACKAGE_EXTRA_ARCHS
fishriver: remove custom BASE_PACKAGE_ARCH and PACKAGE_EXTRA_ARCHS
crownbay-noemgd: add crownbay-noemgd as COMPATIBLE_MACHINE to
linux-yocto bbappend
meta-crownbay/conf/machine/crownbay-noemgd.conf | 3 --- meta-crownbay/conf/machine/crownbay.conf | 3 --- .../recipes-kernel/linux/linux-yocto_git.bbappend | 4 ++++ meta-fishriver/conf/machine/fishriver.conf | 3 --- 4 files changed, 4 insertions(+), 9 deletions(-)
PATCH 1/4 crownbay: remove custom BASE_PACKAGE_ARCH and PACKAGE_EXTRA_ARCHS
From: Tom Zanussi <[email protected]>
PACKAGE_EXTRA_ARCHS in the conf file gets overwritten by the tune-atom include following it, preventing the atom BASE_PACKAGE_ARCH from being included in the final PACKAGE_ARCHS and causing do_rootfs to fail. Remove the atom BASE_PACKAGE_ARCH and PACKAGE_EXTRA_ARCHS in the conf file and allow the values in tune-atom to be used as intended.
Fixes [BUGID #986].
--- meta-crownbay/conf/machine/crownbay.conf | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)
meta-crownbay/conf/machine/crownbay.conf +0 -3
@@ -5,12 +5,9 @@ # i.e. E660 + EG20T TARGET_ARCH = "i586" -PACKAGE_EXTRA_ARCHS = "x86 atom" include conf/machine/include/tune-atom.inc -BASE_PACKAGE_ARCH="atom" - MACHINE_FEATURES = "kernel26 screen keyboard pci usbhost ext2 ext3 x86 \ acpi serial usbgadget"
Signature · 1 line
1.7.0.4
Re: [PATCH 1/4] crownbay: remove custom BASE_PACKAGE_ARCH and PACKAGE_EXTRA_ARCHS
Quoted 8 lines · Tom Zanussi
From: Tom Zanussi<[email protected]>
PACKAGE_EXTRA_ARCHSin the conf file gets overwritten by the tune-atom include following it, preventing the atomBASE_PACKAGE_ARCHfrom being included in the finalPACKAGE_ARCHSand causingdo_rootfsto fail. Remove the atomBASE_PACKAGE_ARCHandPACKAGE_EXTRA_ARCHSin the conf file and allow the values in tune-atom to be used as intended.
I think we may still want to change the tune-atom PACKAGE_EXTRA_ARCHS to ?=.
Quoted 2 lines
Fixes [BUGID #986].
Should be [YOCTO #986]
Quoted 22 lines
Signed-off-by Tom Zanussi<[email protected]>--- meta-crownbay/conf/machine/crownbay.conf | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)meta-crownbay/conf/machine/crownbay.conf +0
-3@@ -5,12 +5,9 @@ # i.e. E660 + EG20T TARGET_ARCH = "i586" -PACKAGE_EXTRA_ARCHS = "x86 atom" include conf/machine/include/tune-atom.inc -BASE_PACKAGE_ARCH="atom" - MACHINE_FEATURES = "kernel26 screen keyboard pci usbhost ext2 ext3 x86 \ acpi serial usbgadget"
Re: [PATCH 1/4] crownbay: remove custom BASE_PACKAGE_ARCH and PACKAGE_EXTRA_ARCHS
Quoted 11 lines · Saul
Quoted 8 lines · Tom Zanussi
From: Tom Zanussi<[email protected]>
PACKAGE_EXTRA_ARCHSin the conf file gets overwritten by the tune-atom include following it, preventing the atomBASE_PACKAGE_ARCHfrom being included in the finalPACKAGE_ARCHSand causingdo_rootfsto fail. Remove the atomBASE_PACKAGE_ARCHandPACKAGE_EXTRA_ARCHSin the conf file and allow the values in tune-atom to be used as intended.I think we may still want to change the tune-atom
PACKAGE_EXTRA_ARCHSto ?=.
Yeah, I'll change that along with a couple other changes to that file, such as switching -march=core2 to -march=atom, soon...
Tom
Quoted 27 lines
Quoted 2 lines
Fixes [BUGID #986].
Should be [YOCTO #986]
Quoted 22 lines
Signed-off-by Tom Zanussi<[email protected]>--- meta-crownbay/conf/machine/crownbay.conf | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)meta-crownbay/conf/machine/crownbay.conf +0
-3@@ -5,12 +5,9 @@ # i.e. E660 + EG20T TARGET_ARCH = "i586" -PACKAGE_EXTRA_ARCHS = "x86 atom" include conf/machine/include/tune-atom.inc -BASE_PACKAGE_ARCH="atom" - MACHINE_FEATURES = "kernel26 screen keyboard pci usbhost ext2 ext3 x86 \ acpi serial usbgadget"
Re: [PATCH 1/4] crownbay: remove custom BASE_PACKAGE_ARCH and PACKAGE_EXTRA_ARCHS
Quoted 10 lines · Tom Zanussi
Quoted 9 lines · Saul
Quoted 8 lines · Tom Zanussi
From: Tom Zanussi<[email protected]>
PACKAGE_EXTRA_ARCHSin the conf file gets overwritten by the tune-atom include following it, preventing the atomBASE_PACKAGE_ARCHfrom being included in the finalPACKAGE_ARCHSand causingdo_rootfsto fail. Remove the atomBASE_PACKAGE_ARCHandPACKAGE_EXTRA_ARCHSin the conf file and allow the values in tune-atom to be used as intended.
Quoted 5 lines
Quoted 2 lines
I think we may still want to change the tune-atom
PACKAGE_EXTRA_ARCHSto ?=.Yeah, I'll change that along with a couple other changes to that file, such as switching -march=core2 to -march=atom, soon...
Does that actually make any difference to gcc? It never used to but I'm wondering if anything has changed?
Cheers,
Richard
Re: [PATCH 1/4] crownbay: remove custom BASE_PACKAGE_ARCH and PACKAGE_EXTRA_ARCHS
Quoted 11 lines · Richard Purdie
Quoted 10 lines · Tom Zanussi
Quoted 9 lines · Saul
Quoted 8 lines · Tom Zanussi
From: Tom Zanussi<[email protected]>
PACKAGE_EXTRA_ARCHSin the conf file gets overwritten by the tune-atom include following it, preventing the atomBASE_PACKAGE_ARCHfrom being included in the finalPACKAGE_ARCHSand causingdo_rootfsto fail. Remove the atomBASE_PACKAGE_ARCHandPACKAGE_EXTRA_ARCHSin the conf file and allow the values in tune-atom to be used as intended.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
I think we may still want to change the tune-atom
PACKAGE_EXTRA_ARCHSto ?=.Yeah, I'll change that along with a couple other changes to that file, such as switching -march=core2 to -march=atom, soon...
Does that actually make any difference to gcc? It never used to but I'm wondering if anything has changed?
I don't know yet, which is why I didn't just make the change straightaway - it would need some benchmarking first, at least.
I would be kind of surprised though if it didn't have some effect - otherwise why would it exist at all? It sounds like you've tested this before and it didn't make any difference - how did you test, and do you have any benchmarking suggestions that would help decide one way or the other?
Thanks,
Tom
Quoted 5 lines
Cheers,
Richard
Re: [PATCH 1/4] crownbay: remove custom BASE_PACKAGE_ARCH and PACKAGE_EXTRA_ARCHS
Quoted 21 lines · Tom Zanussi
Quoted 11 lines · Richard Purdie
Quoted 10 lines · Tom Zanussi
Quoted 9 lines · Saul
Quoted 8 lines · Tom Zanussi
From: Tom Zanussi<[email protected]>
PACKAGE_EXTRA_ARCHSin the conf file gets overwritten by the tune-atom include following it, preventing the atomBASE_PACKAGE_ARCHfrom being included in the finalPACKAGE_ARCHSand causingdo_rootfsto fail. Remove the atomBASE_PACKAGE_ARCHandPACKAGE_EXTRA_ARCHSin the conf file and allow the values in tune-atom to be used as intended.Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
I think we may still want to change the tune-atom
PACKAGE_EXTRA_ARCHSto ?=.Yeah, I'll change that along with a couple other changes to that file, such as switching -march=core2 to -march=atom, soon...
Does that actually make any difference to gcc? It never used to but I'm wondering if anything has changed?
Quoted 8 lines
I don't know yet, which is why I didn't just make the change straightaway - it would need some benchmarking first, at least.
I would be kind of surprised though if it didn't have some effect - otherwise why would it exist at all? It sounds like you've tested this before and it didn't make any difference - how did you test, and do you have any benchmarking suggestions that would help decide one way or the other?
I think I looked at the gcc codebase and found it didn't do anything. Its more common that you'd have thought in gcc :/
Cheers,
Richard
Re: [PATCH 1/4] crownbay: remove custom BASE_PACKAGE_ARCH and PACKAGE_EXTRA_ARCHS
Quoted 25 lines · Richard Purdie
Quoted 24 lines · Tom Zanussi
Quoted 11 lines · Richard Purdie
Quoted 10 lines · Tom Zanussi
Quoted 9 lines · Saul
Quoted 8 lines · Tom Zanussi
From: Tom Zanussi<[email protected]>
PACKAGE_EXTRA_ARCHSin the conf file gets overwritten by the tune-atom include following it, preventing the atomBASE_PACKAGE_ARCHfrom being included in the finalPACKAGE_ARCHSand causingdo_rootfsto fail. Remove the atomBASE_PACKAGE_ARCHandPACKAGE_EXTRA_ARCHSin the conf file and allow the values in tune-atom to be used as intended.Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
I think we may still want to change the tune-atom
PACKAGE_EXTRA_ARCHSto ?=.Yeah, I'll change that along with a couple other changes to that file, such as switching -march=core2 to -march=atom, soon...
Does that actually make any difference to gcc? It never used to but I'm wondering if anything has changed?
I don't know yet, which is why I didn't just make the change straightaway - it would need some benchmarking first, at least.
Quoted 9 lines
Quoted 5 lines
I would be kind of surprised though if it didn't have some effect - otherwise why would it exist at all? It sounds like you've tested this before and it didn't make any difference - how did you test, and do you have any benchmarking suggestions that would help decide one way or the other?
I think I looked at the gcc codebase and found it didn't do anything. Its more common that you'd have thought in gcc :/
OK, good to know. I'll take a look when I get a chance and see if anything's changed in that area lately...
Tom
Quoted 4 lines
Cheers,
Richard
Re: [PATCH 1/4] crownbay: remove custom BASE_PACKAGE_ARCH and PACKAGE_EXTRA_ARCHS
In reply to Saul WoldQuoted 10 lines · Saul Wold
Quoted 8 lines · Tom Zanussi
From: Tom Zanussi<[email protected]>
PACKAGE_EXTRA_ARCHSin the conf file gets overwritten by the tune-atom include following it, preventing the atomBASE_PACKAGE_ARCHfrom being included in the finalPACKAGE_ARCHSand causingdo_rootfsto fail. Remove the atomBASE_PACKAGE_ARCHandPACKAGE_EXTRA_ARCHSin the conf file and allow the values in tune-atom to be used as intended.I think we may still want to change the tune-atom
PACKAGE_EXTRA_ARCHSto ?=.
No, we really don't want to do that ;-).
The whole point behind the tune-* include files is they are the one correct place where these architecture specific flags get setup correctly. Experience shows people trying to do it in each machine file get it wrong more often than right, this machine file being a perfect example.
If some different flags are needed, we create a new tune-xxx file which can either inherit another and customise or set the correct values itself.
Cheers,
Richard
Quoted 31 lines
Quoted 2 lines
Fixes [BUGID #986].
Should be [YOCTO #986]
Quoted 12 lines
Signed-off-by Tom Zanussi<[email protected]>--- meta-crownbay/conf/machine/crownbay.conf | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)meta-crownbay/conf/machine/crownbay.conf +0
-0@@ -5,12 +5,9 @@ # i.e. E660 + EG20Tmeta-crownbay/conf/machine/crownbay.conf line 13
Quoted 10 lines
meta-crownbay/conf/machine/crownbay.conf +0
-3TARGET_ARCH = "i586" -PACKAGE_EXTRA_ARCHS = "x86 atom" include conf/machine/include/tune-atom.inc -BASE_PACKAGE_ARCH="atom" - MACHINE_FEATURES = "kernel26 screen keyboard pci usbhost ext2 ext3 x86 \ acpi serial usbgadget"_______________________________________________
poky mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/poky
PATCH 2/4 crownbay-noemgd: remove custom BASE_PACKAGE_ARCH and PACKAGE_EXTRA_ARCHS
In reply to Tom ZanussiFrom: Tom Zanussi <[email protected]>
PACKAGE_EXTRA_ARCHS in the conf file gets overwritten by the tune-atom include following it, preventing the atom BASE_PACKAGE_ARCH from being included in the final PACKAGE_ARCHS and causing do_rootfs to fail. Remove the atom BASE_PACKAGE_ARCH and PACKAGE_EXTRA_ARCHS in the conf file and allow the values in tune-atom to be used as intended.
Fixes [BUGID #986].
--- meta-crownbay/conf/machine/crownbay-noemgd.conf | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)
meta-crownbay/conf/machine/crownbay-noemgd.conf +0 -3
@@ -5,12 +5,9 @@ # i.e. E660 + EG20T TARGET_ARCH = "i586" -PACKAGE_EXTRA_ARCHS = "x86 atom" include conf/machine/include/tune-atom.inc -BASE_PACKAGE_ARCH="atom" - MACHINE_FEATURES = "kernel26 screen keyboard pci usbhost ext2 ext3 x86 \ acpi serial usbgadget"
Signature · 1 line
1.7.0.4
PATCH 3/4 fishriver: remove custom BASE_PACKAGE_ARCH and PACKAGE_EXTRA_ARCHS
In reply to Tom ZanussiFrom: Tom Zanussi <[email protected]>
PACKAGE_EXTRA_ARCHS in the conf file gets overwritten by the tune-atom include following it, preventing the atom BASE_PACKAGE_ARCH from being included in the final PACKAGE_ARCHS and causing do_rootfs to fail. Remove the atom BASE_PACKAGE_ARCH and PACKAGE_EXTRA_ARCHS in the conf file and allow the values in tune-atom to be used as intended.
--- meta-fishriver/conf/machine/fishriver.conf | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-)
meta-fishriver/conf/machine/fishriver.conf +0 -3
@@ -5,12 +5,9 @@ # i.e. Z530/E660 + EG20T TARGET_ARCH = "i586" -PACKAGE_EXTRA_ARCHS = "x86 atom" include conf/machine/include/tune-atom.inc -BASE_PACKAGE_ARCH="atom" - MACHINE_FEATURES = "kernel26 screen keyboard pci usbhost ext2 ext3 x86 \ acpi serial usbgadget"
Signature · 1 line
1.7.0.4
PATCH 4/4 crownbay-noemgd: add crownbay-noemgd as COMPATIBLE_MACHINE to linux-yocto bbappend
In reply to Tom ZanussiFrom: Tom Zanussi <[email protected]>
crownbay-noemgd also needs a COMPATIBLE_MACHINE entry in linux-yocto.
--- .../recipes-kernel/linux/linux-yocto_git.bbappend | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
meta-crownbay/recipes-kernel/linux/linux-yocto_git.bbappend +4 -0
@@ -1,3 +1,7 @@ FILESEXTRAPATHS := "${FILESEXTRAPATHS}:${THISDIR}/${PN}" + COMPATIBLE_MACHINE_crownbay = "crownbay" KMACHINE_crownbay = "yocto/standard/crownbay" + +COMPATIBLE_MACHINE_crownbay-noemgd = "crownbay-noemgd" +KMACHINE_crownbay-noemgd = "yocto/standard/crownbay"
Signature · 1 line
1.7.0.4