MAINTAINERS: Update patterns
cover MAINTAINERS: Update patterns
Just some housekeeping.
Joe Perches (6):
MAINTAINERS: Update MSM pattern
MAINTAINERS: Update CPU FREQUENCY patterns
MAINTAINERS: Update HIGH RESOLUTION TIMERS patterns
MAINTAINERS: Remove unused PERFORMANCE EVENTS pattern
MAINTAINERS: Update USB HID/HIDBP DRIVERS pattern
MAINTAINERS: Remove section USB SE401 DRIVER
MAINTAINERS | 15 +++------------ 1 files changed, 3 insertions(+), 12 deletions(-)
Signature · 1 line
1.7.5.rc3.dirty
PATCH 1/6 MAINTAINERS: Update MSM pattern
Video MSM is still in staging.
--- MAINTAINERS | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
MAINTAINERS +1 -1
@@ -926,7 +926,7 @@ F: drivers/mmc/host/msm_sdcc.c F: drivers/mmc/host/msm_sdcc.h F: drivers/tty/serial/msm_serial.h F: drivers/tty/serial/msm_serial.c -F: drivers/platform/msm/ +F: drivers/staging/msm/ F: drivers/*/pm8???-* F: include/linux/mfd/pm8xxx/ T: git git://codeaurora.org/quic/kernel/davidb/linux-msm.git
Signature · 1 line
1.7.5.rc3.dirty
Re: [PATCH 1/6] MAINTAINERS: Update MSM pattern
Quoted 1 line · Joe Perches
Video MSM is still in staging.
It also appears to be in drivers/video/msm
Carl, do we need the staging driver any more?
I don't have any problem removing the drivers/platform/msm line, since that now appears to have been an ill-formed idea, but I'd rather just get rid of the staging video driver.
David
Quoted 21 lines
cc David Brown <[email protected]>cc Daniel Walker <[email protected]>cc Bryan Huntsman <[email protected]>Signed-off-by Joe Perches <[email protected]>--- MAINTAINERS | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)MAINTAINERS +1
-1@@ -926,7 +926,7 @@ F: drivers/mmc/host/msm_sdcc.c F: drivers/mmc/host/msm_sdcc.h F: drivers/tty/serial/msm_serial.h F: drivers/tty/serial/msm_serial.c -F: drivers/platform/msm/ +F: drivers/staging/msm/ F: drivers/*/pm8???-* F: include/linux/mfd/pm8xxx/ T: git git://codeaurora.org/quic/kernel/davidb/linux-msm.git
Signature · 2 lines
Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
Re: [PATCH 1/6] MAINTAINERS: Update MSM pattern
Quoted 6 lines · Joe Perches
Quoted 2 lines
Video MSM is still in staging.
It also appears to be in
drivers/video/msm
Quoted 8 lines
Carl, do we need the staging driver any more?
I don't have any problem removing the
drivers/platform/msmline, since that now appears to have been an ill-formed idea, but I'd rather just get rid of the staging video driver.David
The staging video driver can be removed. While the current driver is moving along the same dev path as the staging driver originally did, I don't believe it is a goal to converge to the staging driver in its current form.
-Carl V.
Quoted 26 lines
Quoted 13 lines
cc David Brown <[email protected]>cc Daniel Walker <[email protected]>cc Bryan Huntsman <[email protected]>Signed-off-by Joe Perches <[email protected]>--- MAINTAINERS | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)MAINTAINERS +0
-0MAINTAINERS F: drivers/mmc/host/msm_sdcc.c · line 932
Quoted 8 lines
MAINTAINERS +1
-1@@ -926,7 +926,7 @@ F: drivers/mmc/host/msm_sdcc.c F: drivers/mmc/host/msm_sdcc.h F: drivers/tty/serial/msm_serial.h F: drivers/tty/serial/msm_serial.c -F: drivers/platform/msm/ +F: drivers/staging/msm/ F: drivers/*/pm8???-* F: include/linux/mfd/pm8xxx/ T: git git://codeaurora.org/quic/kernel/davidb/linux-msm.git--
Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
Signature · 2 lines
Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
PATCH 2/6 MAINTAINERS: Update CPU FREQUENCY patterns
In reply to Joe PerchesCommit bb0a56ecc4ba ("[CPUFREQ] Move x86 drivers to drivers/cpufreq/") moved the files, remove the old pattern.
--- MAINTAINERS | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
MAINTAINERS +0 -1
@@ -1889,7 +1889,6 @@ L: [email protected] W: http://www.codemonkey.org.uk/projects/cpufreq/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/davej/cpufreq.git S: Maintained -F: arch/x86/kernel/cpu/cpufreq/ F: drivers/cpufreq/ F: include/linux/cpufreq.h
Signature · 1 line
1.7.5.rc3.dirty
PATCH 3/6 MAINTAINERS: Update HIGH RESOLUTION TIMERS patterns
In reply to Joe Perchesclockchips.h was typoed as clockevents.h
--- MAINTAINERS | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
MAINTAINERS +1 -1
@@ -2993,7 +2993,7 @@ F: kernel/hrtimer.c F: kernel/time/clockevents.c F: kernel/time/tick*.* F: kernel/time/timer_*.c -F: include/linux/clockevents.h +F: include/linux/clockchips.h F: include/linux/hrtimer.h HIGH-SPEED SCC DRIVER FOR AX.25
Signature · 1 line
1.7.5.rc3.dirty
PATCH 4/6 MAINTAINERS: Remove unused PERFORMANCE EVENTS pattern
In reply to Joe PerchesNo arch/*/lib/perf_event* files exist so remove the pattern.
--- MAINTAINERS | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
MAINTAINERS +0 -1
@@ -4908,7 +4908,6 @@ F: arch/*/kernel/perf_event*.c F: arch/*/kernel/*/perf_event*.c F: arch/*/kernel/*/*/perf_event*.c F: arch/*/include/asm/perf_event.h -F: arch/*/lib/perf_event*.c F: arch/*/kernel/perf_callchain.c F: tools/perf/
Signature · 1 line
1.7.5.rc3.dirty
Re: [PATCH 4/6] MAINTAINERS: Remove unused PERFORMANCE EVENTS pattern
Quoted 16 lines · Joe Perches
No
arch/*/lib/perf_event*files exist so remove the pattern.cc Peter Zijlstra <[email protected]>cc Paul Mackerras <[email protected]>cc Ingo Molnar <[email protected]>cc Arnaldo Carvalho de Melo <[email protected]>Signed-off-by Joe Perches <[email protected]>--- MAINTAINERS | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)MAINTAINERS +0
-0
MAINTAINERS F: arch/*/kernel/perf_event*.c · line 4912
Quoted 6 lines
MAINTAINERS +0
-1@@ -4908,7 +4908,6 @@ F: arch/*/kernel/perf_event*.c F: arch/*/kernel/*/perf_event*.c F: arch/*/kernel/*/*/perf_event*.c F: arch/*/include/asm/perf_event.h -F: arch/*/lib/perf_event*.c F: arch/*/kernel/perf_callchain.c F: tools/perf/
The arch/*/lib/ hierarchy is a common place to put stuff into, it does not hurt at all to have it mentioned.
In Linux there's 10+ really important, not yet implemented features to implement, there's 100+ under-maintained subsystems to maintain, there's 1000+ not yet fixed bugs to fix, there's 10,000+ ugly driver files to be improved and there's 1,000,000+ stylistic errors to fix.
Mucking with the MAINTAINERS file on the level you did in this patch comes some time after we've fixed the 1,000,000+ stylistic errors.
Could you please stop mucking with these patterns and start dealing with some of the more important problems we have?
Thanks,
Ingo
Re: [PATCH 4/6] MAINTAINERS: Remove unused PERFORMANCE EVENTS pattern
Quoted 4 lines · Ingo Molnar
Quoted 1 line · Joe Perches
No
arch/*/lib/perf_event*files exist so remove the pattern.The
arch/*/lib/hierarchy is a common place to put stuff into, it does not hurt at all to have it mentioned.
Every once in awhile I run a script on MAINTAINERS and fix up defects found by the script.
Dead code is dead code.
This was unused as of commit e360adbe2924.
Quoted 2 lines
stop mucking with these patterns and start dealing with some of the more important problems we have?
My time, my choice on what to do with it.
Ingo Molnar
NAKRe: [PATCH 4/6] MAINTAINERS: Remove unused PERFORMANCE EVENTS pattern
Quoted 11 lines · Joe Perches
Quoted 4 lines · Ingo Molnar
Quoted 1 line · Joe Perches
No
arch/*/lib/perf_event*files exist so remove the pattern.The
arch/*/lib/hierarchy is a common place to put stuff into, it does not hurt at all to have it mentioned.Every once in awhile I run a script on
MAINTAINERSand fix up defects found by the script.Dead code is dead code.
This was unused as of commite360adbe2924.
NAK, i've outlined my reasons:
- It's an obvious pattern to put librarized functionality in there and should an architecture grow a file there in the future it will be included automatically.
- What we are interested in are false positives (files included that should not be matched) and false negatives (files belonging to a subsystm not included) - this pattern is none of those.
Quoted 4 lines
Quoted 2 lines
stop mucking with these patterns and start dealing with some of the more important problems we have?
My time, my choice on what to do with it.
Yes, but this time you are also wasting my time with such a stupid patch, so it's not just your time wasted anymore.
Thanks,
Ingo
PATCH 5/6 MAINTAINERS: Update USB HID/HIDBP DRIVERS pattern
In reply to Joe PerchesIt was moved by commit 1a978c50c6cf
("HID: Move hiddev.txt to the new Documentation/hid directory") so update the MAINTAINERS pattern too.
--- MAINTAINERS | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
MAINTAINERS +1 -1
@@ -6458,7 +6458,7 @@ M: Jiri Kosina <[email protected]> L: [email protected] T: git git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git S: Maintained -F: Documentation/usb/hiddev.txt +F: Documentation/hid/hiddev.txt F: drivers/hid/usbhid/ USB ISP116X DRIVER
Signature · 1 line
1.7.5.rc3.dirty
Jiri Kosina
AppliedRe: [PATCH 5/6] MAINTAINERS: Update USB HID/HIDBP DRIVERS pattern
Quoted 3 lines · Joe Perches
It was moved by commit
1a978c50c6cf
("HID: Move hiddev.txt to the newDocumentation/hiddirectory") so update theMAINTAINERSpattern too.
Good catch.
Applied, thanks.
Signature · 2 lines
Jiri Kosina SUSE Labs
PATCH 6/6 MAINTAINERS: Remove section USB SE401 DRIVER
In reply to Joe PerchesCommit b287db119edb ("[media] se401: remove last V4L1 driver") removed the driver, so remove the section from MAINTAINERS.
--- MAINTAINERS | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-)
MAINTAINERS +0 -7
@@ -6524,13 +6524,6 @@ W: http://pegasus2.sourceforge.net/ S: Maintained F: drivers/net/usb/rtl8150.c -USB SE401 DRIVER -L: [email protected] -W: http://www.chello.nl/~j.vreeken/se401/ -S: Orphan -F: Documentation/video4linux/se401.txt -F: drivers/staging/se401/ - USB SERIAL BELKIN F5U103 DRIVER M: William Greathouse <[email protected]> L: [email protected]
Signature · 1 line
1.7.5.rc3.dirty