Skip to contentSkip to conversation

Not display false error msg

PATCH In review Lianhao Lu 2 participants 3 messages Jun 7, 2011

lore
Share & tools
lore

Lianhao Lu

author
#0 lore raw

cover Not display false error msg

This patch prevents displaying the false error msg "Nothing to do. Use 'bitbake world' to build everything, or run 'bitbake --help' for usage information." when hob ui exits.

NOTE: This patch should be applied to the branch of "poky-contrib/josh/hob".

The following changes since commit 8f7947c089c86deee84f284b352dbdac4bfd6bf2:
Joshua Lock (1):
bitbake/hob: show the busy cursor when performing lengthy operations

are available in the git repository at:

git://git.pokylinux.org/poky-contrib llu/hob_errmsg
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=llu/hob_errmsg

Lianhao Lu (1):
bitbake/hob: Not display false error msg at hob exit.

 bitbake/lib/bb/cooker.py      |    4 +++-
 bitbake/lib/bb/ui/__init__.py |    2 ++
 bitbake/lib/bb/ui/hob.py      |    3 +++
 3 files changed, 8 insertions(+), 1 deletions(-)
author
#1 lore raw

PATCH 1/1 bitbake/hob: Not display false error msg at hob exit.

Not display the false error msg "Nothing to do ..." when hob ui exits by adding a flag of bb.ui.allowNoneAction.

Signed-off-by Lianhao Lu <[email protected]>
---
 bitbake/lib/bb/cooker.py      |    4 +++-
 bitbake/lib/bb/ui/__init__.py |    2 ++
 bitbake/lib/bb/ui/hob.py      |    3 +++
 3 files changed, 8 insertions(+), 1 deletions(-)
bitbake/lib/bb/cooker.py +3 -1
index ac2faa2..584a86d 100644
@@ -35,6 +35,7 @@ from cStringIO import StringIO
 from contextlib import closing
 import bb
 from bb import utils, data, parse, event, cache, providers, taskdata, command, runqueue
+import bb.ui
 
 logger      = logging.getLogger("BitBake")
 collectlog  = logging.getLogger("BitBake.Collection")

@@ -153,7 +154,8 @@ class BBCooker:
                 self.commandlineAction = ["buildTargets", self.configuration.pkgs_to_build, self.configuration.cmd]
             else:
                 self.commandlineAction = None
-                buildlog.error("Nothing to do.  Use 'bitbake world' to build everything, or run 'bitbake --help' for usage information.")
+                if not bb.ui.allowNoneAction:
+                    buildlog.error("Nothing to do.  Use 'bitbake world' to build everything, or run 'bitbake --help' for usage information.")
 
     def runCommands(self, server, data, abort):
         """
bitbake/lib/bb/ui/__init__.py +2 -0
index a4805ed..518abfc 100644
@@ -15,3 +15,5 @@
 # You should have received a copy of the GNU General Public License along
 # with this program; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+
+allowNoneAction = False
\ No newline at end of file
bitbake/lib/bb/ui/hob.py +3 -0
index bef3ba2..391bf52 100644
@@ -31,6 +31,9 @@ from bb.ui.crumbs.hig import CrumbsDialog
 import xmlrpclib
 import logging
 import Queue
+import bb.ui
+
+bb.ui.allowNoneAction = True
 
 class MainWindow (gtk.Window):
Signature · 1 line
1.7.0.4
#2 lore raw

Re: [Image_Creator_Patch 1/1] bitbake/hob: Not display false error msg at hob exit.

Quoted 4 lines · Lianhao Lu

Not display the false error msg "Nothing to do ..." when hob ui exits by adding a flag of bb.ui.allowNoneAction.

Signed-off-by Lianhao Lu <[email protected]>

Maybe we should move the handling of this message into the UIs, rather than it being in the cooker, either as additional logic (I do think we need to find a better way of handling the command line action) or as an event, then it would be up to the UI if it should display such a message.

Signature · 5 lines
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics