Skip to contentSkip to conversation

bonding: delete two unused variables

PATCH In review Weiping Pan 2 participants 5 messages Jun 9, 2011

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover bonding: delete two unused variables

Delete two unused variables in bonding.

Weiping Pan (2):
bonding: delete unused ad_timer
bonding: delete unused arp_mon_pt

 drivers/net/bonding/bond_3ad.h |    1 -
 drivers/net/bonding/bonding.h  |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.4.4
#1 lore raw

PATCH 1/2 bonding: delete unused ad_timer

Now we use agg_select_timer and ad_work.

---
 drivers/net/bonding/bond_3ad.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/bonding/bond_3ad.h +0 -1
index 0ee3f16..fb67185 100644
@@ -257,7 +257,6 @@ struct ad_bond_info {
 	int lacp_fast;		/* whether fast periodic tx should be
 				 * requested
 				 */
-	struct timer_list ad_timer;
 };
 
 struct ad_slave_info {
Signature · 1 line
1.7.4.4
#2 lore raw

PATCH 2/2 bonding: delete unused arp_mon_pt

In reply to Weiping Pan

Now all received packets are handled by bond_handle_frame, arp_mon_pt isn't used any more.

---
 drivers/net/bonding/bonding.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/net/bonding/bonding.h +0 -1
index ea1d005..382903f 100644
@@ -240,7 +240,6 @@ struct bonding {
 	struct   bond_params params;
 	struct   list_head vlan_list;
 	struct   vlan_group *vlgrp;
-	struct   packet_type arp_mon_pt;
 	struct   workqueue_struct *wq;
 	struct   delayed_work mii_work;
 	struct   delayed_work arp_work;
Signature · 1 line
1.7.4.4
author
#4 lore raw
Quoted 7 lines · Américo Wang
Quoted 6 lines · Weiping Pan

Delete two unused variables in bonding.

Weiping Pan (2):
bonding: delete unused ad_timer
bonding: delete unused arp_mon_pt

Quoted 5 lines

Both look good to me,

Thanks.

thanks,
But I move these two patches into another patchset,
the title is "[PATCH v4 net-next 0/5] bonding:use latest lacp_rate and ad_select and delete unused ad_timer and arp_mon_pt"

Hope it will be convenient to be reviewed and merged, so forget these two patches.

thanks
Weiping Pan