Skip to contentSkip to conversation

busybox: bump PR to enable largefile support

PATCH In review Dexuan Cui 2 participants 5 messages Jul 1, 2011

lore
Share & tools
lore

Dexuan Cui

author
#0 lore raw

cover busybox: bump PR to enable largefile support

The following changes since commit 4d60d32a60ae0fae1002b27cd7d20c28532f4932:

poky.conf: add largefile support into DISTRO_FEATURES (2011-07-01 17:35:26 +0800)

Dexuan Cui (1):
busybox: bump PR to enable largefile support

are available in the git repository at:
git://git.pokylinux.org/poky-contrib dcui/mkswap
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dcui/mkswap

 meta/recipes-core/busybox/busybox_1.18.4.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Signature · 1 line
1.7.6
author
#1 lore raw

PATCH 1/1 busybox: bump PR to enable largefile support

[YOCTO #1205 ]

In the previous commit we enable largefile setting in meta-yocto/conf/distro/poky.conf, so we need to re-build busybox to actually enable it.

---
 meta/recipes-core/busybox/busybox_1.18.4.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta/recipes-core/busybox/busybox_1.18.4.bb +1 -1
index cb41ac6..5883cc6 100644
@@ -1,5 +1,5 @@
 require busybox.inc
-PR = "r4"
+PR = "r5"
 
 SRC_URI = "http://www.busybox.net/downloads/busybox-${PV}.tar.bz2;name=tarball \
            file://udhcpscript.patch \
Signature · 1 line
1.7.6
#2 lore raw
Quoted 3 lines · Dexuan Cui

In the previous commit we enable largefile setting in meta-yocto/conf/distro/poky.conf, so we need to re-build busybox to actually enable it.

I guess this would be a good case for using something like OE .dev's DISTRO_PR. It would be a bit sad if we end up having to bump PRs all over the place in oe-core whenever some random layer changes its DISTRO_FEATURES or whatever.

Also, just on a stylistic issue, it's a bit confusing to talk about "the previous commit" if the commit in question was to a different file and in a different repo. If you want to refer to a specific commit it's best to mention the actual hash and, if necessary, the repo where it can be found.

p.

#3 lore raw
Quoted 9 lines · Phil Blundell
Quoted 3 lines · Dexuan Cui

In the previous commit we enable largefile setting in meta-yocto/conf/distro/poky.conf, so we need to re-build busybox to actually enable it.

I guess this would be a good case for using something like OE .dev's DISTRO_PR. It would be a bit sad if we end up having to bump PRs all over the place in oe-core whenever some random layer changes its DISTRO_FEATURES or whatever.

Thanks for the info!
I didn't know OE.dev's DISTRO_PR before. I'm going to look at that.

Quoted 5 lines

Also, just on a stylistic issue, it's a bit confusing to talk about "the previous commit" if the commit in question was to a different file and in a different repo. If you want to refer to a specific commit it's best to mention the actual hash and, if necessary, the repo where it can be found.

Thanks for the suggestion!
I'll pay special attention to this and avoid confusion in future.

Thanks,
-- Dexuan

#4 lore raw
In reply to Dexuan Cui
Quoted 9 lines · Dexuan

The following changes since commit
4d60d32a60ae0fae1002b27cd7d20c28532f4932:

poky.conf: add largefile support into DISTRO_FEATURES (2011-07-01
17:35:26 +0800)

Dexuan Cui (1):
busybox: bump PR to enable largefile support

Quoted 6 lines

are available in the git repository at:
git://git.pokylinux.org/poky-contrib dcui/mkswap
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dcui/mkswap

 meta/recipes-core/busybox/busybox_1.18.4.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

BTW: please see my first commit in [email protected].

Thanks,
-- Dexuan