Skip to contentSkip to conversation

Fix external module compilations

PATCH In review Anders Darander 2 participants 5 messages Jul 5, 2011

lore
Share & tools
lore
#0 lore raw

cover Fix external module compilations

When compiling an external module, the compilation errors out, when scripts/basic/fixdep and later on scripts/mod/modpost is being requested. The removal of 'make -C $kerneldir _mrproper_scripts' fixes these problems.

The following changes since commit 340cc366c7feff983a85f9e9ae8ae1f537239f5b:

  gcc-4.5: Edit defaults.h in ${B} instead of ${S}, and t-oe in ${B} (2011-07-02 22:40:22 +0200)

are available in the git repository at:
git://github.com/darander/meta-oe fixdep
https://github.com/darander/meta-oe/tree/fixdep

Anders Darander (1):
kernel.bbclass: make external module compile

 meta-oe/classes/kernel.bbclass |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 kernel.bbclass: make external module compile

When compiling external modules, scripts/basic/fixdep and scripts/mod/modpost, is wanted. Do not remove too much from the staged kernel sources.

---
 meta-oe/classes/kernel.bbclass |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
meta-oe/classes/kernel.bbclass +0 -1
index 89aeb92..34aaf17 100644
@@ -161,7 +161,6 @@ kernel_do_install() {
 	# and include files.
 	#
 	oe_runmake -C $kerneldir CC="${KERNEL_CC}" LD="${KERNEL_LD}" clean
-	make -C $kerneldir _mrproper_scripts
 	find $kerneldir -path $kerneldir/scripts -prune -o -name "*.[csS]" -exec rm '{}' \;
 	find $kerneldir/Documentation -name "*.txt" -exec rm '{}' \;
 
Signature · 1 line
1.7.4.1
#2 lore raw
In reply to Anders Darander
Quoted 3 lines · Anders Darander Anders Darander

When compiling an external module, the compilation errors out, when scripts/basic/fixdep and later on scripts/mod/modpost is being requested.

Forget about this e-mail.
I've just sent an new one, with meta-oe in the subject.

Cheers,
Anders

#3 lore raw
In reply to Anders Darander
Quoted 3 lines · Anders Darander

When compiling an external module, the compilation errors out, when scripts/basic/fixdep and later on scripts/mod/modpost is being requested. The removal of 'make -C $kerneldir _mrproper_scripts' fixes these problems.

It is a bit sad that these sorts of changes need to be done twice. Is there a compelling reason why meta-oe needs to maintain its own version of kernel.bbclass rather than sharing it with oe-core?

p.

#4 lore raw
Quoted 9 lines · Phil Blundell Phil Blundell
Quoted 4 lines · Anders Darander

When compiling an external module, the compilation errors out, when scripts/basic/fixdep and later on scripts/mod/modpost is being requested. The removal of 'make -C $kerneldir _mrproper_scripts' fixes these problems.

It is a bit sad that these sorts of changes need to be done twice. Is there a compelling reason why meta-oe needs to maintain its own version of kernel.bbclass rather than sharing it with oe-core?

Yes, it is certainly a sad state.

The primary difference seems to be some changes in the uImage-related code, and that meta-oe has some initramfs-support in its kernel.bbclass.

Can someone with deeper knowledge comment on this? I guess that it shouldn't be any real problems in getting the initramfs support code merged into oe- core.

What about the differences in the uImage code? (I haven't really looked into the differences).

Cheers,
Anders