the fix to bug 1208

PATCH Applied Dexuan Cui 4 participants 10 messages Jul 7, 2011 – Jul 8, 2011

lore

Share & tools

lore

Dexuan Cui

author

2011-07-07 08:43 UTC #0 lore raw

cover the fix to bug 1208

The following changes since commit ad2363278f0ea86fcf3464f8f6073d3a3d06be63:

uclibc: Fix compilation in thumb mode (2011-07-02 00:02:24 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib dcui/distro
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dcui/distro

Dexuan Cui (1):
powertop: inherit update-alternatives and use a higher priority than
busybox

 meta/recipes-kernel/powertop/powertop_1.13.bb |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

Signature · 1 line

1.7.6

Dexuan Cui

author

2011-07-07 08:43 UTC #1 lore raw

PATCH 1/1 powertop: inherit update-alternatives and use a higher priority than busybox

busybox-1.18.4 installs /bin/powertop and the powertop recipe installs /usr/bin/powertop. So, in PATH, if /bin appears before /usr/bin, we would run the version offered by busybox, which has a very limited function (e.g., no parameter is accepted) and this causes trouble to eclipse plugin.

We can use update-alternatives for powertop with higher priority to resolve the issue.

Fixes [YOCTO #1208]

Signed-off-by Dexuan Cui <[email protected]>

---
 meta/recipes-kernel/powertop/powertop_1.13.bb |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

meta/recipes-kernel/powertop/powertop_1.13.bb +7 -1

index dff4fcd..472a2bb 100644
@@ -11,7 +11,7 @@ DEPENDS = "virtual/libintl ncurses"
 # powertop 1.13 needs lspci
 RDEPENDS_${PN} = "pciutils"
 
-PR = "r0"
+PR = "r1"
 
 SRC_URI = "http://www.lesswatts.org/projects/powertop/download/powertop-${PV}.tar.gz \
            file://stub_out_the_ncurses_calls_in_dump_mode.patch"

@@ -22,6 +22,12 @@ SRC_URI[sha256sum] = "2bc866089496877dd26d2d316ad5763ab8ecb5e28aefba44bc5d355dcd
 CFLAGS += "${LDFLAGS}"
 EXTRA_OEMAKE = "VERSION=\"${PV}\""
 
+inherit update-alternatives
+ALTERNATIVE_NAME = "powertop"
+ALTERNATIVE_PATH = "${bindir}/powertop"
+ALTERNATIVE_LINK = "${base_bindir}/powertop"
+ALTERNATIVE_PRIORITY = "100"
+
 do_configure() {
 	# We do not build ncurses with wide char support
 	sed -i -e "s/lncursesw/lncurses/" ${S}/Makefile

Signature · 1 line

1.7.6

Tom Rini

2011-07-07 15:45 UTC #2 lore raw

Re: [PATCH 1/1] powertop: inherit update-alternatives and use a higher priority than busybox

Quoted 11 lines · Dexuan Cui

busybox-1.18.4 installs /bin/powertop and the powertop recipe installs /usr/bin/powertop. So, in PATH, if /bin appears before /usr/bin, we would run the version offered by busybox, which has a very limited function (e.g., no parameter is accepted) and this causes trouble to eclipse plugin.
We can use update-alternatives for powertop with higher priority to resolve the issue.
Fixes [YOCTO #1208]
Signed-off-by Dexuan Cui <[email protected]>

This fix seems a bit incomplete. Why is busybox putting powertop into /bin when it almost certainly belongs in /usr/bin like the real recipe was placing it. busybox needs a fix here too.

Signature · 2 lines

Tom Rini
Mentor Graphics Corporation

Cui, Dexuan

author

2011-07-08 01:45 UTC #3 lore raw

Re: [PATCH 1/1] powertop: inherit update-alternatives and use a higher priority than busybox

Quoted 10 lines · Tom Rini

Quoted 9 lines · Dexuan Cui
busybox-1.18.4 installs /bin/powertop and the powertop recipe installs /usr/bin/powertop. So, in PATH, if /bin appears before /usr/bin, we would run the version offered by busybox, which has a very limited function (e.g., no parameter is accepted) and this causes trouble to eclipse plugin.
We can use update-alternatives for powertop with higher priority to resolve the issue.

Quoted 7 lines

Quoted 3 lines
Fixes [YOCTO #1208]
Signed-off-by Dexuan Cui <[email protected]>
This fix seems a bit incomplete. Why is busybox putting powertop into /bin when it almost certainly belongs in /usr/bin like the real recipe was placing it. busybox needs a fix here too.

Thanks for the comment!
I was hesitant about fixing busybox as I wasn't sure if it's worthy to make a patch to only fix the path for busybox. I don't know why busybox puts it into /bin. I think the best place may be /usr/sbin/. A little unluckily this patch to powertop has been already in poky master... So maybe we could try to fix the recipes in future, e.g., when upgrading them.

Thanks,
-- Dexuan

Koen Kooi

2011-07-08 07:36 UTC #4 lore raw

Re: [PATCH 1/1] powertop: inherit update-alternatives and use a higher priority than busybox

Op 8 jul. 2011 om 02:40 heeft "Cui, Dexuan" <[email protected]> het volgende geschreven:

Quoted 13 lines

Quoted 12 lines · Tom Rini
Quoted 11 lines · Dexuan Cui
busybox-1.18.4 installs /bin/powertop and the powertop recipe installs /usr/bin/powertop. So, in PATH, if /bin appears before /usr/bin, we would run the version offered by busybox, which has a very limited function (e.g., no parameter is accepted) and this causes trouble to eclipse plugin.
We can use update-alternatives for powertop with higher priority to resolve the issue.
Fixes [YOCTO #1208]

Quoted 8 lines

Quoted 5 lines
Quoted 1 line
Signed-off-by Dexuan Cui <[email protected]>
This fix seems a bit incomplete. Why is busybox putting powertop into /bin when it almost certainly belongs in /usr/bin like the real recipe was placing it. busybox needs a fix here too.
Thanks for the comment!
I was hesitant about fixing busybox as I wasn't sure if it's worthy to make a patch to only fix the path for busybox. I don't know why busybox puts it into /bin. I think the best place may be /usr/sbin/. A little unluckily this patch to powertop has been already in poky master... So maybe we could try to fix the recipes in future, e.g., when upgrading them.

we should do the right thing in oe-core, the poky people can clean up on their own.

Quoted 7 lines

Thanks,
-- Dexuan
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Richard Purdie

2011-07-08 15:07 UTC #5 lore raw

Re: [PATCH 1/1] powertop: inherit update-alternatives and use a higher priority than busybox

Quoted 23 lines · Koen Kooi

Op 8 jul. 2011 om 02:40 heeft "Cui, Dexuan" <[email protected]> het volgende geschreven:
Quoted 13 lines
Quoted 12 lines · Tom Rini
Quoted 11 lines · Dexuan Cui
busybox-1.18.4 installs /bin/powertop and the powertop recipe installs /usr/bin/powertop. So, in PATH, if /bin appears before /usr/bin, we would run the version offered by busybox, which has a very limited function (e.g., no parameter is accepted) and this causes trouble to eclipse plugin.
We can use update-alternatives for powertop with higher priority to resolve the issue.
Fixes [YOCTO #1208]
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Dexuan Cui <[email protected]>
This fix seems a bit incomplete. Why is busybox putting powertop into /bin when it almost certainly belongs in /usr/bin like the real recipe was placing it. busybox needs a fix here too.
Thanks for the comment!
I was hesitant about fixing busybox as I wasn't sure if it's worthy

Quoted 7 lines

to make a patch to only fix the path for busybox. I don't know why busybox puts it into /bin. I think the best place may be /usr/sbin/.
Quoted 1 line
A little unluckily this patch to powertop has been already in poky
master... So maybe we could try to fix the recipes in future, e.g., when upgrading them.
we should do the right thing in oe-core, the poky people can clean up on their own.

I don't think anyone is suggesting we shouldn't do the right thing in OE-Core? :)

I merged the original patch on the grounds that its was an improvement to the situation. We've identified a better improvement so can someone please send me the patch and I'll likely merge that too.

FWIW, I agree that powertop should really be under /usr/...

Cheers,

Richard

Koen Kooi

2011-07-08 16:01 UTC #6 lore raw

Re: [PATCH 1/1] powertop: inherit update-alternatives and use a higher priority than busybox

Op 8 jul. 2011 om 16:00 heeft Richard Purdie <[email protected]> het volgende geschreven:

Quoted 30 lines · Koen Kooi

Quoted 29 lines
Op 8 jul. 2011 om 02:40 heeft "Cui, Dexuan" <[email protected]> het volgende geschreven:
Quoted 13 lines
Quoted 12 lines · Tom Rini
Quoted 11 lines · Dexuan Cui
busybox-1.18.4 installs /bin/powertop and the powertop recipe installs /usr/bin/powertop. So, in PATH, if /bin appears before /usr/bin, we would run the version offered by busybox, which has a very limited function (e.g., no parameter is accepted) and this causes trouble to eclipse plugin.
We can use update-alternatives for powertop with higher priority to resolve the issue.
Fixes [YOCTO #1208]
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Dexuan Cui <[email protected]>
This fix seems a bit incomplete. Why is busybox putting powertop into /bin when it almost certainly belongs in /usr/bin like the real recipe was placing it. busybox needs a fix here too.
Thanks for the comment!
I was hesitant about fixing busybox as I wasn't sure if it's worthy
to make a patch to only fix the path for busybox. I don't know why busybox puts it into /bin. I think the best place may be /usr/sbin/.
Quoted 1 line
A little unluckily this patch to powertop has been already in poky
master... So maybe we could try to fix the recipes in future, e.g., when upgrading them.

Quoted 8 lines

Quoted 1 line
we should do the right thing in oe-core, the poky people can clean up on their own.
I don't think anyone is suggesting we shouldn't do the right thing in OE-Core? :)
I merged the original patch on the grounds that its was an improvement to the situation. We've identified a better improvement so can someone please send me the patch and I'll likely merge that too.

the email makes it seem that the patch was merged into poky, but not oe-core. When reading it like that the proposal involved merging the 'incomplete' patch for the sake of keeping poky and oe-core in sync

Quoted 13 lines

FWIW, I agree that powertop should really be under /usr/...
Cheers,
Richard
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Richard Purdie

2011-07-08 16:48 UTC #7 lore raw

Re: [PATCH 1/1] powertop: inherit update-alternatives and use a higher priority than busybox

Quoted 38 lines · Koen Kooi

Op 8 jul. 2011 om 16:00 heeft Richard Purdie <[email protected]> het volgende geschreven:
Quoted 35 lines · Koen Kooi
Quoted 23 lines
Op 8 jul. 2011 om 02:40 heeft "Cui, Dexuan" <[email protected]> het volgende geschreven:
Quoted 13 lines
Quoted 12 lines · Tom Rini
Quoted 11 lines · Dexuan Cui
busybox-1.18.4 installs /bin/powertop and the powertop recipe installs /usr/bin/powertop. So, in PATH, if /bin appears before /usr/bin, we would run the version offered by busybox, which has a very limited function (e.g., no parameter is accepted) and this causes trouble to eclipse plugin.
We can use update-alternatives for powertop with higher priority to resolve the issue.
Fixes [YOCTO #1208]
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Dexuan Cui <[email protected]>
This fix seems a bit incomplete. Why is busybox putting powertop into /bin when it almost certainly belongs in /usr/bin like the real recipe was placing it. busybox needs a fix here too.
Thanks for the comment!
I was hesitant about fixing busybox as I wasn't sure if it's worthy
Quoted 7 lines
to make a patch to only fix the path for busybox. I don't know why busybox puts it into /bin. I think the best place may be /usr/sbin/.
Quoted 1 line
A little unluckily this patch to powertop has been already in poky
master... So maybe we could try to fix the recipes in future, e.g., when upgrading them.
we should do the right thing in oe-core, the poky people can clean up on their own.
I don't think anyone is suggesting we shouldn't do the right thing in OE-Core? :)

Quoted 7 lines

Quoted 3 lines
I merged the original patch on the grounds that its was an improvement to the situation. We've identified a better improvement so can someone please send me the patch and I'll likely merge that too.
the email makes it seem that the patch was merged into poky, but not oe-core. When reading it like that the proposal involved merging the 'incomplete' patch for the sake of keeping poky and oe-core in sync

The OE-Core component of Poky always stays in sync now...

Cheers,

Richard

Koen Kooi

2011-07-08 20:49 UTC #8 lore raw

Re: [PATCH 1/1] powertop: inherit update-alternatives and use a higher priority than busybox

Op 8 jul. 2011 om 18:43 heeft Richard Purdie <[email protected]> het volgende geschreven:

Quoted 43 lines · Koen Kooi

Quoted 42 lines
Op 8 jul. 2011 om 16:00 heeft Richard Purdie <[email protected]> het volgende geschreven:
Quoted 38 lines · Koen Kooi
Quoted 23 lines
Op 8 jul. 2011 om 02:40 heeft "Cui, Dexuan" <[email protected]> het volgende geschreven:
Quoted 13 lines
Quoted 12 lines · Tom Rini
Quoted 11 lines · Dexuan Cui
busybox-1.18.4 installs /bin/powertop and the powertop recipe installs /usr/bin/powertop. So, in PATH, if /bin appears before /usr/bin, we would run the version offered by busybox, which has a very limited function (e.g., no parameter is accepted) and this causes trouble to eclipse plugin.
We can use update-alternatives for powertop with higher priority to resolve the issue.
Fixes [YOCTO #1208]
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Dexuan Cui <[email protected]>
This fix seems a bit incomplete. Why is busybox putting powertop into /bin when it almost certainly belongs in /usr/bin like the real recipe was placing it. busybox needs a fix here too.
Thanks for the comment!
I was hesitant about fixing busybox as I wasn't sure if it's worthy
Quoted 7 lines
to make a patch to only fix the path for busybox. I don't know why busybox puts it into /bin. I think the best place may be /usr/sbin/.
Quoted 1 line
A little unluckily this patch to powertop has been already in poky
master... So maybe we could try to fix the recipes in future, e.g., when upgrading them.
we should do the right thing in oe-core, the poky people can clean up on their own.
I don't think anyone is suggesting we shouldn't do the right thing in OE-Core? :)
I merged the original patch on the grounds that its was an improvement to the situation. We've identified a better improvement so can someone please send me the patch and I'll likely merge that too.

Quoted 5 lines

Quoted 3 lines
the email makes it seem that the patch was merged into poky, but not oe-core. When reading it like that the proposal involved merging the 'incomplete' patch for the sake of keeping poky and oe-core in sync
The OE-Core component of Poky always stays in sync now...

I realized that later, I'm way too tired to think properly. sorry about the fuss

Quoted 11 lines

Cheers,
Richard
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Richard Purdie

Applied

2011-07-07 12:42 UTC #9 lore raw

In reply to Dexuan Cui

Quoted 11 lines · Dexuan Cui

The following changes since commit ad2363278f0ea86fcf3464f8f6073d3a3d06be63:
uclibc: Fix compilation in thumb mode (2011-07-02 00:02:24 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib dcui/distro
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dcui/distro
Dexuan Cui (1):
powertop: inherit update-alternatives and use a higher priority than
busybox

Merged to master, thanks.

Richard