Skip to contentSkip to conversation

Enable network sanity checks

PATCH In review Joshua Lock 2 participants 4 messages Jul 13, 2011

lore
Share & tools
lore
#0 lore raw

cover Enable network sanity checks

Add some CONNECTIVITY_CHECK_URIS to local.conf.sample such that the network sanity checks are enabled for http, https and git sources.

The following changes since commit 7354fc9213f27aa1b643dbe88070437f1ee4c063:

insane.bbclass: skip rdepends QA checks for kernel / modules (2011-07-12 15:22:09 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib josh/sanity
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=josh/sanity

Joshua Lock (1):
local.conf.sample: add CONNECTIVITY_CHECK_URIS

 meta-yocto/conf/local.conf.sample |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
Signature · 1 line
1.7.6
#1 lore raw

PATCH 1/1 local.conf.sample: add CONNECTIVITY_CHECK_URIS

Add CONNECTIVITY_CHECK_URIS to run the network connectivity sanity test for http, https and git sources.

---
 meta-yocto/conf/local.conf.sample |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
meta-yocto/conf/local.conf.sample +8 -0
index ea32b81..fb20f2c 100644
@@ -214,3 +214,11 @@ NO32LIBS = "1"
 # The network based PR service host and port
 #PRSERV_HOST = "localhost"
 #PRSERV_PORT = "8585"
+
+# Use the following URI's to test whether we can succesfully fetch from the
+# network (and warn you if not). This test will be run each time a new build
+# directory is specfied, if you wish to disable it delete or comment out the
+# following few lines that define CONNECTIVITY_CHECK_URIS.
+CONNECTIVITY_CHECK_URIS = "git://git.yoctoproject.org/yocto-firewall-test;protocol=git;rev=HEAD \
+			   https://eula-downloads.yoctoproject.org/index.php \
+			   http://bugzilla.yoctoproject.org/report.cgi"
Signature · 1 line
1.7.6
#2 lore raw

Re: [PATCH 1/1] local.conf.sample: add CONNECTIVITY_CHECK_URIS

Quoted 14 lines · Joshua Lock

Add CONNECTIVITY_CHECK_URIS to run the network connectivity sanity test for http, https and git sources.

---
 meta-yocto/conf/local.conf.sample |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
meta-yocto/conf/local.conf.sample +0 -0
index ea32b81..fb20f2c 100644
@@ -214,3 +214,11 @@ NO32LIBS = "1"
 # The network based PR service host and port

meta-yocto/conf/local.conf.sample NO32LIBS = "1" · line 224

Quoted 10 lines
meta-yocto/conf/local.conf.sample +8 -0
 #PRSERV_HOST = "localhost"
 #PRSERV_PORT = "8585"
+
+# Use the following URI's to test whether we can succesfully fetch from the
+# network (and warn you if not). This test will be run each time a new build
+# directory is specfied, if you wish to disable it delete or comment out the
+# following few lines that define CONNECTIVITY_CHECK_URIS.
+CONNECTIVITY_CHECK_URIS = "git://git.yoctoproject.org/yocto-firewall-test;protocol=git;rev=HEAD \
+			   https://eula-downloads.yoctoproject.org/index.php \
+			   http://bugzilla.yoctoproject.org/report.cgi"

Would this not be better in a distro config file? conf/distro/poky.conf comes to mind.

Josh pointed out that the lsb variant would then miss out - so perhaps a network-sanity.inc file could be included by each distro defined in a layer. It doesn't make sense in layer.conf as multiple layers can be used - but as I understand it, only a single distro is built at a time?

I like the idea of it working by default without any requirements on local.conf. The user could override this variable in local.conf if they want, but I don't think it should be required to be there for the checks to work.

Signature · 3 lines
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
#3 lore raw

Re: [PATCH 1/1] local.conf.sample: add CONNECTIVITY_CHECK_URIS

Quoted 31 lines · Darren Hart
Quoted 14 lines · Joshua Lock

Add CONNECTIVITY_CHECK_URIS to run the network connectivity sanity test for http, https and git sources.

---
 meta-yocto/conf/local.conf.sample |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)
meta-yocto/conf/local.conf.sample +0 -0
index ea32b81..fb20f2c 100644
@@ -214,3 +214,11 @@ NO32LIBS = "1"
 # The network based PR service host and port

meta-yocto/conf/local.conf.sample NO32LIBS = "1" · line 224

Quoted 10 lines
meta-yocto/conf/local.conf.sample +8 -0
 #PRSERV_HOST = "localhost"
 #PRSERV_PORT = "8585"
+
+# Use the following URI's to test whether we can succesfully fetch from the
+# network (and warn you if not). This test will be run each time a new build
+# directory is specfied, if you wish to disable it delete or comment out the
+# following few lines that define CONNECTIVITY_CHECK_URIS.
+CONNECTIVITY_CHECK_URIS = "git://git.yoctoproject.org/yocto-firewall-test;protocol=git;rev=HEAD \
+			   https://eula-downloads.yoctoproject.org/index.php \
+			   http://bugzilla.yoctoproject.org/report.cgi"

Would this not be better in a distro config file? conf/distro/poky.conf comes to mind.

Quoted 4 lines

Josh pointed out that the lsb variant would then miss out - so perhaps a network-sanity.inc file could be included by each distro defined in a layer. It doesn't make sense in layer.conf as multiple layers can be used - but as I understand it, only a single distro is built at a time?

I was being stupid both when I submitted this patch and when we discussed it, the poky.conf file is inherited by each of the distributions in meta-yocto so it makes sense to define this variable there.

Quoted 6 lines

I like the idea of it working by default without any requirements on local.conf. The user could override this variable in local.conf if they want, but I don't think it should be required to be there for the checks to work.

You are entirely correct. I should also set it with ?= so it's easy to override.

v2 patch imminent.

Thanks,
Joshua

Signature · 3 lines
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre