Skip to contentSkip to conversation

Fix for OpenSuse build failure

PATCH In review Saul Wold 3 participants 4 messages Jul 21, 2011 – Sep 26, 2012

lore
Share & tools
lore

Saul Wold

author
#0 lore raw

v2 cover Fix for OpenSuse build failure

Richard,

This fixes a problem with OpenSuse host contamination. Adds one depends in the initial depends chain for gettext-native.

Thanks
Sau!

The following changes since commit 0d03800caffc2341b74190d38f7a372223c89f4c:

lsbsetup_1.0.bb: Change the hardcoded /usr/lib to support multilib (2011-07-20 15:43:43 +0100)

are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib sgw/fix
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=sgw/fix

Saul Wold (1):
gettext: Add depends to gettext to avoid host contamination

 meta/recipes-core/gettext/gettext_0.18.1.1.bb |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
1.7.3.4
author
#1 lore raw

PATCH v2 1/1 gettext: Add depends to gettext to avoid host contamination

[YOCTO #1242]

---
 meta/recipes-core/gettext/gettext_0.18.1.1.bb |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
meta/recipes-core/gettext/gettext_0.18.1.1.bb +3 -3
index 0b11a90..cc0129f 100644
@@ -5,9 +5,9 @@ SECTION = "libs"
 LICENSE = "GPLv3"
 LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
 
-PR = "r1"
-DEPENDS = "gettext-native virtual/libiconv ncurses expat"
-DEPENDS_virtclass-native = ""
+PR = "r2"
+DEPENDS = "libxml2-native gettext-native virtual/libiconv ncurses expat"
+DEPENDS_virtclass-native = "libxml2-native"
 PROVIDES = "virtual/libintl virtual/gettext"
 PROVIDES_virtclass-native = ""
 CONFLICTS_${PN} = "proxy-libintl"
Signature · 1 line
1.7.3.4
#2 lore raw

Re: [PATCH v2 1/1] gettext: Add depends to gettext to avoid host contamination

Can you clarify what exactly is the host contamination issue here? I don't quite understand why it's appropriate for the target gettext to be depending on libxml2-native (which it presumably can't be linking against). Also, since gettext-native is configured --with-included-xml, it doesn't seem as though that one is going to be using libxml2-native in any meaningful sense either.

thanks

p.

Quoted 24 lines · Saul Wold

[YOCTO #1242]

---
 meta/recipes-core/gettext/gettext_0.18.1.1.bb |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
meta/recipes-core/gettext/gettext_0.18.1.1.bb +3 -3
index 0b11a90..cc0129f 100644
@@ -5,9 +5,9 @@ SECTION = "libs"
 LICENSE = "GPLv3"
 LIC_FILES_CHKSUM = "file://COPYING;md5=d32239bcb673463ab874e80d47fae504"
 
-PR = "r1"
-DEPENDS = "gettext-native virtual/libiconv ncurses expat"
-DEPENDS_virtclass-native = ""
+PR = "r2"
+DEPENDS = "libxml2-native gettext-native virtual/libiconv ncurses expat"
+DEPENDS_virtclass-native = "libxml2-native"
 PROVIDES = "virtual/libintl virtual/gettext"
 PROVIDES_virtclass-native = ""
 CONFLICTS_${PN} = "proxy-libintl"
#3 lore raw

Re: [PATCH v2 1/1] gettext: Add depends to gettext to avoid host contamination

Quoted 6 lines · Phil Blundell

Can you clarify what exactly is the host contamination issue here? I don't quite understand why it's appropriate for the target gettext to be depending on libxml2-native (which it presumably can't be linking against). Also, since gettext-native is configured --with-included-xml, it doesn't seem as though that one is going to be using libxml2-native in any meaningful sense either.

I tried to unravel this a bit. I think:

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=e5e6e761d15e42d94836a2153eda13bdbc4f915e

which added the --with-included-xml came later and should have removed the DEPENDS but didn't.

(the earlier commit being
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=a0abef4533337faeb2fd991d7ab67f0a94f59568)

So this should be ok to go in and does some nice dependency unravelling.

Cheers,

Richard