More hob bug fixes
cover More hob bug fixes
The first patch is a glaring omission in my code, apologies for that. The second, aiui, should fix cache invalidation to work as expected.
Please review.
Thanks,
Joshua
The following changes since commit 5f079f11ca626a4a11ad728c56bde21009ddd7c8:
bb/ui/hob: be clear that the image contents are an estimate (2011-08-03 18:19:54 -0700)
are available in the git repository at:
git://github.com/incandescant/bitbake hob
https://github.com/incandescant/bitbake/tree/hob
Joshua Lock (2):
bb/ui/hob: reset event handler once build complete bb/cooker: mark parsed conf files as potential cache invalidators
lib/bb/cooker.py | 2 +- lib/bb/ui/hob.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletions(-)
Signature · 1 line
1.7.6
PATCH 1/2 bb/ui/hob: reset event handler once build complete
The HobEventHandler passes events on to RunningBuild when a build is in progress. This patch resets the HobEventHandler to handle events when the build is complete.
--- lib/bb/ui/hob.py | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
lib/bb/ui/hob.py +2 -0
@@ -450,6 +450,8 @@ class MainWindow (gtk.Window): self.nb.set_current_page(0) def build_complete_cb(self, running_build): + # Have the handler process BB events again + self.handler.building = None self.stopping = False self.back.connect("clicked", self.back_button_clicked_cb) self.back.set_sensitive(True)
Signature · 1 line
1.7.6
PATCH 2/2 bb/cooker: mark parsed conf files as potential cache invalidators
In reply to Joshua LockThe include parameter to _parse() tells the parser whether to include the file in __base_depends, the contents of which have their mtime tested to invalidate the cache when they have changed.
As I understand it we would want all of the configuration files that are currently handled with the _parse() method to invalidate the cache to set the default value of the include parameter to True.
--- lib/bb/cooker.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
lib/bb/cooker.py +1 -1
@@ -1317,7 +1317,7 @@ def catch_parse_error(func): return wrapped @catch_parse_error -def _parse(fn, data, include=False): +def _parse(fn, data, include=True): return bb.parse.handle(fn, data, include) @catch_parse_error
Signature · 1 line
1.7.6
Richard Purdie
AppliedQuoted 12 lines · Joshua Lock
The first patch is a glaring omission in my code, apologies for that. The second, aiui, should fix cache invalidation to work as expected.
Please review.
Thanks,
JoshuaThe following changes since commit
5f079f11ca626a4a11ad728c56bde21009ddd7c8:bb/ui/hob: be clear that the image contents are an estimate (2011-08-03 18:19:54 -0700)
Quoted 7 lines
are available in the git repository at:
git://github.com/incandescant/bitbakehob
https://github.com/incandescant/bitbake/tree/hobJoshua Lock (2):
bb/ui/hob: reset event handler once build complete bb/cooker: mark parsed conf files as potential cache invalidators
Merged to master, thanks.
Richard