Skip to contentSkip to conversation

fix yocto bug 1276: qemuppc hello-mod fails to build

PATCH Applied Darren Hart 2 participants 3 messages Aug 17, 2011

lore
Share & tools
lore
#0 lore raw

cover fix yocto bug 1276: qemuppc hello-mod fails to build

The following changes since commit a21ff559e7c93e9da61104f4a33e42e6004189fd:

Fixup remaining bb.msg.domain users (2011-08-15 17:31:52 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib dvhart/powerpc
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dvhart/powerpc

Darren Hart (1):
kernel: restore crtsavres.o to enable building external modules on
powerpc

 meta/classes/kernel.bbclass |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
Signature · 1 line
1.7.6
#1 lore raw

PATCH 1/1 kernel: restore crtsavres.o to enable building external modules on powerpc

Fixes [YOCTO #1276]

As of Linux kernel version 3.0.1, and much earlier, the make clean target removes arch/powerpc/lib/crtsavres.o. As this object is present in KBUILD_LDFLAGS_MODULE, it is required to build external modules, and should therefor not be removed by make clean.

While I do not advocate fixing buggy kernels in the generic kernel classes, we should probably account for this one in kernel.bbclass as it affects such a long list of kernel versions.

CC Bruce Ashfield <[email protected]>
CC Tom Zanussi <[email protected]>
---
 meta/classes/kernel.bbclass |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)
meta/classes/kernel.bbclass +7 -0
index 7dc9cc6..386b05e 100644
@@ -159,6 +159,13 @@ kernel_do_install() {
 	find $kerneldir -path $kerneldir/scripts -prune -o -name "*.[csS]" -exec rm '{}' \;
 	find $kerneldir/Documentation -name "*.txt" -exec rm '{}' \;
 
+	# As of Linux kernel version 3.0.1, the clean target removes
+	# arch/powerpc/lib/crtsavres.o which is present in
+	# KBUILD_LDFLAGS_MODULE, making it required to build external modules.
+	if [ ${ARCH} = "powerpc" ]; then
+		cp arch/powerpc/lib/crtsavres.o $kerneldir/arch/powerpc/lib/crtsavres.o
+	fi
+
 	# Remove the following binaries which cause strip errors
 	# during do_package for cross-compiled platforms
 	bin_files="arch/powerpc/boot/addnote arch/powerpc/boot/hack-coff \
Signature · 1 line
1.7.6
#2 lore raw

Re: [PATCH 1/1] kernel: restore crtsavres.o to enable building external modules on powerpc

Quoted 7 lines · Darren Hart

Fixes [YOCTO #1276]

As of Linux kernel version 3.0.1, and much earlier, the make clean target removes arch/powerpc/lib/crtsavres.o. As this object is present in KBUILD_LDFLAGS_MODULE, it is required to build external modules, and should therefor not be removed by make clean.

Quoted 7 lines

While I do not advocate fixing buggy kernels in the generic kernel classes, we should probably account for this one in kernel.bbclass as it affects such a long list of kernel versions.

CC Bruce Ashfield <[email protected]>
CC Tom Zanussi <[email protected]>

Merged to master, thanks.

Richard