Skip to contentSkip to conversation

initrdscripts: fix init-live.sh for hddimg and livecd

PATCH Applied [email protected] 3 participants 4 messages Aug 24, 2011

lore
Share & tools
lore
#0 lore raw

cover initrdscripts: fix init-live.sh for hddimg and livecd

From: Jingdong Lu <[email protected]>

Both hddimg and livecd use init-live.sh script to boot the rootfs.img. But the paths of rootfs.img in hddimg and livecd are different. So we add a variable "ISOLINUX" to provide a correct path.

The following changes since commit edd8e1e8b974eb3f0f9f66c2207aadf43612350b:
Scott Rifenbark (1):
documentation/adt-manual/adt-command.xml: general edits.

are available in the git repository at:

git://git.pokylinux.org/poky-contrib jingdonglu/bug686-v2
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jingdonglu/bug686-v2

Jingdong Lu (1):
initrdscripts: fix init-live.sh for hddimg and livecd

 meta/recipes-core/initrdscripts/files/init-live.sh |   17 +++++++++++------
 .../initrdscripts/initramfs-live-boot_1.0.bb       |    2 +-
 2 files changed, 12 insertions(+), 7 deletions(-)
#1 lore raw

PATCH 1/1 initrdscripts: fix init-live.sh for hddimg and livecd

From: Jingdong Lu <[email protected]>

Both hddimg and livecd use init-live.sh script to boot the rootfs.img. But the paths of rootfs.img in hddimg and livecd are different. So we add a variable "ISOLINUX" to provide a correct path.

---
 meta/recipes-core/initrdscripts/files/init-live.sh |   17 +++++++++++------
 .../initrdscripts/initramfs-live-boot_1.0.bb       |    2 +-
 2 files changed, 12 insertions(+), 7 deletions(-)
meta/recipes-core/initrdscripts/files/init-live.sh +11 -6
index 1cd87e8..6a1deba 100644
@@ -1,9 +1,10 @@
 #!/bin/sh
 
 ROOT_MOUNT="/rootfs/"
-ROOT_IMAGE="isolinux/rootfs.img"
+ROOT_IMAGE="rootfs.img"
 MOUNT="/bin/mount"
 UMOUNT="/bin/umount"
+ISOLINUX=""
 
 early_setup() {
     mkdir /proc
@@ -58,8 +59,12 @@ while true
 do
   for i in `ls /media 2>/dev/null`; do
       if [ -f /media/$i/$ROOT_IMAGE ] ; then
-	  found="yes"
-	  break
+		found="yes"
+		break
+	  elif [ -f /media/$i/isolinux/$ROOT_IMAGE ]; then
+		found="yes"
+		ISOLINUX="isolinux"
+		break	
       fi
   done
   if [ "$found" = "yes" ]; then
@@ -73,15 +78,15 @@ case $label in
 	mkdir $ROOT_MOUNT
 	mknod /dev/loop0 b 7 0
 
-	if ! $MOUNT -o rw,loop,noatime,nodiratime /media/$i/$ROOT_IMAGE $ROOT_MOUNT ; then
+	if ! $MOUNT -o rw,loop,noatime,nodiratime /media/$i/$ISOLINUX/$ROOT_IMAGE $ROOT_MOUNT ; then
 	    fatal "Couldnt mount rootfs image"
 	else
 	    boot_live_root
 	fi
 	;;
     install)
-	if [ -f /media/$i/$ROOT_IMAGE ] ; then
-	    ./install.sh $i $ROOT_IMAGE $video_mode $vga_mode
+	if [ -f /media/$i/$ISOLINUX/$ROOT_IMAGE ] ; then
+	    ./install.sh $i/$ISOLINUX $ROOT_IMAGE $video_mode $vga_mode
 	else
 	    fatal "Couldnt find install script"
 	fi
meta/recipes-core/initrdscripts/initramfs-live-boot_1.0.bb +1 -1
index 140fb1d..6d354b7 100644
@@ -3,7 +3,7 @@ LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
 SRC_URI = "file://init-live.sh"
 
-PR = "r4"
+PR = "r5"
 
 do_install() {
         install -m 0755 ${WORKDIR}/init-live.sh ${D}/init
Signature · 1 line
1.7.0.4
#2 lore raw
Quoted 3 lines · On Wed, Aug 24, 2011 at 05:25, <[email protected]> wrote:

Both hddimg and livecd use init-live.sh script to boot the rootfs.img. But the paths of rootfs.img in hddimg and livecd are different. So we add a variable "ISOLINUX" to provide a correct path.

I do like the patch and I think the way it fixes it is the right one except by the variable name that has been choose; I'd use 'BASEDIR' since this reflects more the reasoning of it to exist.

Signature · 3 lines
Otavio Salvador                             O.S. Systems
E-mail: [email protected]  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
Applied
#3 lore raw
In reply to [email protected]
Quoted 23 lines · On 08/24/2011 01:25 AM, [email protected] wrote:

From: Jingdong Lu<[email protected]>

Both hddimg and livecd use init-live.sh script to boot the rootfs.img. But the paths of rootfs.img in hddimg and livecd are different. So we add a variable "ISOLINUX" to provide a correct path.

The following changes since commit edd8e1e8b974eb3f0f9f66c2207aadf43612350b:
Scott Rifenbark (1):
documentation/adt-manual/adt-command.xml: general edits.

are available in the git repository at:

   git://git.pokylinux.org/poky-contrib jingdonglu/bug686-v2
   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jingdonglu/bug686-v2

Jingdong Lu (1):
initrdscripts: fix init-live.sh for hddimg and livecd

  meta/recipes-core/initrdscripts/files/init-live.sh |   17 +++++++++++------
  .../initrdscripts/initramfs-live-boot_1.0.bb       |    2 +-
  2 files changed, 12 insertions(+), 7 deletions(-)
Quoted 5 lines

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Merged into OE-Core

Thanks
Sau!