Skip to contentSkip to conversation

enable btrfs as a supported image fs type

PATCH In review [email protected] 3 participants 7 messages Sep 6, 2011 – Sep 9, 2011

lore
Share & tools
lore
#0 lore raw

cover enable btrfs as a supported image fs type

From: Nitin A Kamble <[email protected]>

The following changes since commit dbff56238e083d0110eb13c1f5a07716340fdfe4:

icu-3.6: fix building with big make -j (2011-09-06 16:37:02 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib nitin/btrfs
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=nitin/btrfs

Nitin A Kamble (1):
image-types: add btrfs as a supported fstype

 meta/classes/image_types.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Signature · 1 line
1.7.4.4
#1 lore raw

PATCH 1/1 image-types: add btrfs as a supported fstype

From: Nitin A Kamble <[email protected]>

---
 meta/classes/image_types.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta/classes/image_types.bbclass +1 -1
index c24b326..3e303ed 100644
@@ -141,4 +141,4 @@ IMAGE_DEPENDS_ubi = "mtd-utils-native"
 IMAGE_DEPENDS_ubifs = "mtd-utils-native"
 
 # This variable is available to request which values are suitable for IMAGE_FSTYPES
-IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz live squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"
+IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz btrfs live squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"
Signature · 1 line
1.7.4.4
#2 lore raw

Re: [PATCH 1/1] image-types: add btrfs as a supported fstype

Quoted 12 lines · On Tue, 2011-09-06 at 14:06 -0700, [email protected] wrote:

From: Nitin A Kamble <[email protected]>

---
 meta/classes/image_types.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta/classes/image_types.bbclass +0 -0
index c24b326..3e303ed 100644

meta/classes/image_types.bbclass IMAGE_DEPENDS_ubi = "mtd-utils-native" · line 144

Quoted 5 lines
meta/classes/image_types.bbclass +1 -1
@@ -141,4 +141,4 @@ IMAGE_DEPENDS_ubi = "mtd-utils-native"
 IMAGE_DEPENDS_ubifs = "mtd-utils-native"
 
 # This variable is available to request which values are suitable for IMAGE_FSTYPES
-IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz live squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"
+IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz btrfs live squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"

This isn't enough, the variable you've modified is one used only by the hob UI.

You need to define IMAGE_CMD_btrfs and possibly IMAGE_DEPENDS_btrfs entries, maybe EXTRA_IMAGE_CMD_btrfs too if required?

Cheers,
Joshua

Signature · 3 lines
Joshua Lock
        Yocto Project "Johannes factotum"
        Intel Open Source Technology Centre
#3 lore raw

Re: [PATCH 1/1] image-types: add btrfs as a supported fstype

In reply to [email protected]
Quoted 12 lines · * [email protected] <[email protected]> [110906 23:07]:

From: Nitin A Kamble <[email protected]>

---
 meta/classes/image_types.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta/classes/image_types.bbclass +0 -0
index c24b326..3e303ed 100644

meta/classes/image_types.bbclass IMAGE_DEPENDS_ubi = "mtd-utils-native" · line 144

Quoted 5 lines
meta/classes/image_types.bbclass +1 -1
@@ -141,4 +141,4 @@ IMAGE_DEPENDS_ubi = "mtd-utils-native"
 IMAGE_DEPENDS_ubifs = "mtd-utils-native"
 
 # This variable is available to request which values are suitable for IMAGE_FSTYPES
-IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz live squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"
+IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz btrfs live squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"

As Joshua already replied, this isn't enough.
This raises one question, though. Have you successfully built btrfs-image? If so, I assume that you have more patches locally, otherwise you should resist submitting patches, unless they're clearly marked as RFC (request for comments, and thus not to be applied).

Cheers,
Anders

Signature · 2 lines
Anders Darander
ChargeStorm AB
#4 lore raw

Re: [PATCH 1/1] image-types: add btrfs as a supported fstype

Quoted 36 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Anders Darander
Sent: Wednesday, September 07, 2011 12:16 AM
To: [email protected]
Subject: Re: [OE-core] [PATCH 1/1] image-types: add btrfs as a supported fstype

Review

Quoted 8 lines · * [email protected] <[email protected]> [110906 23:07]:

From: Nitin A Kamble <[email protected]>

---
 meta/classes/image_types.bbclass |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
(quoted diff) +0 -0

b/meta/classes/image_types.bbclass

meta/classes/image_types.bbclass IMAGE_DEPENDS_ubi = "mtd-utils-native" · line 143

Quoted 7 lines

index c24b326..3e303ed 100644

meta/classes/image_types.bbclass +0 -0
@@ -141,4 +141,4 @@ IMAGE_DEPENDS_ubi = "mtd-utils-native"
 IMAGE_DEPENDS_ubifs = "mtd-utils-native"
 
 # This variable is available to request which values are suitable

for IMAGE_FSTYPES

meta/classes/image_types.bbclass IMAGE_DEPENDS_ubi = "mtd-utils-native" · line 144

Quoted 1 line
meta/classes/image_types.bbclass +0 -1
-IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz live squashfs

squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"

meta/classes/image_types.bbclass IMAGE_DEPENDS_ubi = "mtd-utils-native" · line 144

Quoted 1 line
meta/classes/image_types.bbclass +1 -0
+IMAGE_TYPES = "jffs2 cramfs ext2 ext2.gz ext3 ext3.gz btrfs live

squashfs squashfs-lzma ubi tar tar.gz tar.bz2 tar.xz cpio cpio.gz cpio.xz cpio.lzma"

Quoted 8 lines

As Joshua already replied, this isn't enough.
This raises one question, though. Have you successfully built btrfs-image? If so, I assume that you have more patches locally, otherwise you should resist submitting patches, unless they're clearly marked as RFC (request for comments, and thus not to be applied).

Cheers,
Anders

All these pieces Josh mentioned are already in the tree. I found this new line, and saw btrfs was not listed in it so added there also. The btrfs support in yocto is working with Linux-yocto 3.x kernel. The btrfs kernel config needs to be enabled, I have sent a patch for that implementing it as a kernel feature, Once that is there then also need to enable the btrfs feature in the Linux-yocto kernel recipe. I will send a patch for that too.

Thanks,
Nitin

#5 lore raw

Re: [PATCH 1/1] image-types: add btrfs as a supported fstype

Quoted 13 lines · Kamble, Nitin A
Quoted 7 lines

-----Original Message----- From:
[email protected] [mailto:[email protected]] On Behalf Of Anders Darander Sent: Wednesday, September 07, 2011 12:16 AM To:
[email protected] Subject: Re: [OE-core] [PATCH 1/1] image-types: add btrfs as a supported fstype

Quoted 5 lines

As Joshua already replied, this isn't enough. This raises one question, though. Have you successfully built btrfs-image? If so, I assume that you have more patches locally, otherwise you should resist submitting patches, unless they're clearly marked as RFC (request for comments, and thus not to be applied).

Quoted 7 lines

All these pieces Josh mentioned are already in the tree. I found this new line, and saw btrfs was not listed in it so added there also. The btrfs support in yocto is working with Linux-yocto 3.x kernel. The btrfs kernel config needs to be enabled, I have sent a patch for that implementing it as a kernel feature, Once that is there then also need to enable the btrfs feature in the Linux-yocto kernel recipe. I will send a patch for that too.

My apologies.
You're correct in that the pieces mentioned by Josh is already in the tree.

However, the commit log should probably have included something like "enabling btrfs support for hob", perhaps worded slightly better.

Cheers,
Anders

Signature · 2 lines
Anders Darander
ChargeStorm AB
#6 lore raw

Re: [PATCH 1/1] image-types: add btrfs as a supported fstype

Quoted 7 lines

My apologies.
You're correct in that the pieces mentioned by Josh is already in the tree.

However, the commit log should probably have included something like "enabling btrfs support for hob", perhaps worded slightly better.

Makes sense. I was not aware of that line is there for hob, now I know it, and change the commit log. Nitin

Quoted 13 lines

Cheers,
Anders

--
Anders Darander
ChargeStorm AB

_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core