Skip to contentSkip to conversation

Pull request #12

PATCH In review Martin Jansa 2 participants 7 messages Sep 16, 2011

lore
Share & tools
lore

Martin Jansa

author
#0 lore raw

cover Pull request #12

The following changes since commit 9c4ff53d2fa688581d257eb7e045f9e6a20470d3:

vlc: update to 1.1.11 and fix xml2 build (2011-09-15 15:59:26 +0200)

are available in the git repository at:
git://git.openembedded.org/meta-openembedded-contrib jansa/meta-efl
http://cgit.openembedded.org/cgit.cgi/meta-openembedded-contrib/log/?h=jansa/meta-efl

pespin (4):
enjoy: Add var LIC_FILES_CHKSUM to recipe
enjoy: Add inherit gettext
enjoy: Update gstreamer package names in RDEPENDS
enjoy: Add gst-plugins-good-autodetect to RDEPENDS

 meta-efl/recipes-efl/e17/enjoy_svn.bb |   15 ++++++++-------
 1 files changed, 8 insertions(+), 7 deletions(-)
Signature · 1 line
1.7.6.1
author
#1 lore raw

PATCH 1/4 enjoy: Add var LIC_FILES_CHKSUM to recipe

From: pespin <[email protected]>

Signed-off-by Pau Espin Pedrol <[email protected]>
Signed-off-by Martin Jansa <[email protected]>
---
 meta-efl/recipes-efl/e17/enjoy_svn.bb |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
meta-efl/recipes-efl/e17/enjoy_svn.bb +1 -0
index eab81b4..d3fea32 100644
@@ -1,5 +1,6 @@
 DESCRIPTION = "Enjoy music player"
 LICENSE = "LGPLv3"
+LIC_FILES_CHKSUM = "file://COPYING;md5=0f507c68d42d1cc0fcb507d007112bf2"
 DEPENDS = "evas ecore edje elementary emotion lightmediascanner"
 SRCREV = "${EFL_SRCREV}"
 PV = "0.0+svnr${SRCPV}"
Signature · 1 line
1.7.6.1
author
#2 lore raw

PATCH 2/4 enjoy: Add inherit gettext

From: pespin <[email protected]>

* Without this patch bitbake fails to build this recipe, and it says this line should be added to recipe

Signed-off-by Pau Espin Pedrol <[email protected]>
Signed-off-by Martin Jansa <[email protected]>
---
 meta-efl/recipes-efl/e17/enjoy_svn.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta-efl/recipes-efl/e17/enjoy_svn.bb +1 -1
index d3fea32..90eb318 100644
@@ -21,7 +21,7 @@ RDEPENDS += "\
 	lightmediascanner-test \
 	"
 
-inherit e
+inherit e gettext
 SRC_URI = "${E_SVN}/trunk;module=${SRCNAME};proto=http;scmdata=keep"
 S = "${WORKDIR}/${SRCNAME}"
Signature · 1 line
1.7.6.1
author
#3 lore raw

PATCH 3/4 enjoy: Update gstreamer package names in RDEPENDS

In reply to Martin Jansa

From: pespin <[email protected]>

* we'll update gstreamer package names again as soon as gstreamer packaging is improved in oe-core

Signed-off-by Pau Espin Pedrol <[email protected]>
Signed-off-by Martin Jansa <[email protected]>
---
 meta-efl/recipes-efl/e17/enjoy_svn.bb |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)
meta-efl/recipes-efl/e17/enjoy_svn.bb +6 -6
index 90eb318..d2f6b03 100644
@@ -14,12 +14,12 @@ DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', '
 #4th needed for flac playback
 #5th needed binary to create db
 RDEPENDS += "\
-	gst-plugin-typefindfunctions gst-plugin-playbin gst-plugin-volume gst-plugin-decodebin2  \
-	${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugin-mad gst-plugin-id3demux', d)} \
-	gst-plugin-ogg gst-plugin-ivorbisdec \
-	gst-plugin-flac \
-	lightmediascanner-test \
-	"
+       gst-plugins-base-typefindfunctions gst-plugins-base-playbin gst-plugins-base-volume gst-plugins-base-decodebin2 \
+       ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugins-ugly-mad gst-plugins-good-id3demux', d)} \
+       gst-plugins-base-ogg gst-plugins-base-ivorbisdec \
+       gst-plugins-good-flac \
+       lightmediascanner-test \
+       "
 
 inherit e gettext
 SRC_URI = "${E_SVN}/trunk;module=${SRCNAME};proto=http;scmdata=keep"
Signature · 1 line
1.7.6.1
author
#4 lore raw

PATCH 4/4 enjoy: Add gst-plugins-good-autodetect to RDEPENDS

In reply to Martin Jansa

From: pespin <[email protected]>

* This plugin is needed in newer versions of enjoy. The app won't play any sound files without this plugin.

Signed-off-by Pau Espin Pedrol <[email protected]>
Signed-off-by Martin Jansa <[email protected]>
---
 meta-efl/recipes-efl/e17/enjoy_svn.bb |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
meta-efl/recipes-efl/e17/enjoy_svn.bb +1 -1
index d2f6b03..8c4d4c2 100644
@@ -14,7 +14,7 @@ DEPENDS += "gst-plugins-good ${@base_conditional('ENTERPRISE_DISTRO', '1', '', '
 #4th needed for flac playback
 #5th needed binary to create db
 RDEPENDS += "\
-       gst-plugins-base-typefindfunctions gst-plugins-base-playbin gst-plugins-base-volume gst-plugins-base-decodebin2 \
+       gst-plugins-base-typefindfunctions gst-plugins-base-playbin gst-plugins-base-volume gst-plugins-base-decodebin2 gst-plugins-good-autodetect \
        ${@base_conditional('ENTERPRISE_DISTRO', '1', '', 'gst-plugins-ugly-mad gst-plugins-good-id3demux', d)} \
        gst-plugins-base-ogg gst-plugins-base-ivorbisdec \
        gst-plugins-good-flac \
Signature · 1 line
1.7.6.1
#5 lore raw
In reply to Martin Jansa

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 16-09-11 09:08, Martin Jansa schreef:

Quoted 5 lines

The following changes since commit
9c4ff53d2fa688581d257eb7e045f9e6a20470d3:

vlc: update to 1.1.11 and fix xml2 build (2011-09-15 15:59:26 +0200)

Quoted 7 lines

are available in the git repository at:
git://git.openembedded.org/meta-openembedded-contrib jansa/meta-efl
http://cgit.openembedded.org/cgit.cgi/meta-openembedded-contrib/log/?h=jansa/meta-efl

pespin (4): enjoy: Add var LIC_FILES_CHKSUM to recipe enjoy: Add inherit
gettext enjoy: Update gstreamer package names in RDEPENDS enjoy: Add gst-plugins-good-autodetect to RDEPENDS

I'm not going to pull the gstreamer ones till the oe-core situation is sorted out on that front.
My other complaint is the lack of a proper author, could you please fix that up?

regards,

Koen

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFOcwcPMkyGM64RGpERAgdHAJ9RJ7X7Cd61X0U0a3MfOp6p6stQlwCgoKKj 6J+kRvXdfoWwt5MRmoNq9s8=
=Q+Ip
-----END PGP SIGNATURE-----

author
#6 lore raw
Quoted 13 lines · Koen Kooi

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 16-09-11 09:08, Martin Jansa schreef:

Quoted 9 lines

The following changes since commit
9c4ff53d2fa688581d257eb7e045f9e6a20470d3:

vlc: update to 1.1.11 and fix xml2 build (2011-09-15 15:59:26 +0200)

are available in the git repository at:
git://git.openembedded.org/meta-openembedded-contrib jansa/meta-efl
http://cgit.openembedded.org/cgit.cgi/meta-openembedded-contrib/log/?h=jansa/meta-efl

Quoted 6 lines
Quoted 3 lines

pespin (4): enjoy: Add var LIC_FILES_CHKSUM to recipe enjoy: Add inherit
gettext enjoy: Update gstreamer package names in RDEPENDS enjoy: Add gst-plugins-good-autodetect to RDEPENDS

I'm not going to pull the gstreamer ones till the oe-core situation is sorted out on that front.

Ah.. I was hoping we could update that as soon as it's fixed in oe-core.. because now enjoy is not really usable in current form.. well we need more then this 4 patches to make it usefull..

Quoted 1 line

My other complaint is the lack of a proper author, could you please fix that up?

Yup, updated in jansa/meta-efl.

Thanks

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]