Skip to contentSkip to conversation

Fix a silly hob bug

PATCH Applied Joshua Lock 2 participants 3 messages Oct 11, 2011 – Oct 24, 2011

lore
Share & tools
lore
#0 lore raw

cover Fix a silly hob bug

Dismissing the open file dialog in hob results in a backtrace, this is due to a stupid logic/indentation error on my part - the following patch rectifies this.

Regards,
Joshua

The following changes since commit dca46cc2e1c75b6add2c4801e2994a4812745f5b:

fetch2: Export additional variables to the fetchers (2011-10-05 14:23:16 +0100)

are available in the git repository at:
git://github.com/incandescant/bitbake hob
https://github.com/incandescant/bitbake/tree/hob

Joshua Lock (1):
hob: fix backtrace when dismissing open dialog

 lib/bb/ui/hob.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.6.4
#1 lore raw

PATCH 1/1 hob: fix backtrace when dismissing open dialog

Clearly a logic/indentation error - we should only try and load the recipe should the file-chooser return OK.

Fixes [YOCTO #1668]

---
 lib/bb/ui/hob.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
lib/bb/ui/hob.py +2 -2
index 71ea88a..0fcaad5 100644
@@ -400,9 +400,9 @@ class MainWindow (gtk.Window):
         if response == gtk.RESPONSE_OK:
             rep.loadRecipe(recipe)
             self.save_path = recipe
+            self.model.load_image_rep(rep)
+            self.dirty = False
         chooser.destroy()
-        self.model.load_image_rep(rep)
-        self.dirty = False
 
     def bake_clicked_cb(self, button):
         build_image = True
Signature · 1 line
1.7.6.4
#2 lore raw

Re: [PATCH 1/1] hob: fix backtrace when dismissing open dialog

Quoted 9 lines · Joshua Lock

Clearly a logic/indentation error - we should only try and load the recipe should the file-chooser return OK.

Fixes [YOCTO #1668]

---
 lib/bb/ui/hob.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

Merged to master, thanks.

Richard