Skip to contentSkip to conversation

Hob v1 related fixes

PATCH Applied Joshua Lock 2 participants 4 messages Dec 13, 2011 – Dec 20, 2011

lore
Share & tools
lore
#0 lore raw

cover Hob v1 related fixes

This series works around a couple of issues which I'd like to address for the Yocto Edison 1.1.1 release.

Regards,
Joshua

The following changes since commit 71b53a3f0766ca464560a1f6a449f9424fbdf7ae:

siggen.py: If both sigs have a variable in it's whitelist then don't say it's changed (2011-12-05 16:17:38 +0000)

are available in the git repository at:
git://github.com/incandescant/bitbake hob
https://github.com/incandescant/bitbake/tree/hob

Joshua Lock (2):
ui/crumbs/runningbuild: handle InvalidTask events ui/crumbs/hobprefs: trigger a reparse after changing IMAGE_FSTYPES

 lib/bb/ui/crumbs/hobprefs.py     |    1 +
 lib/bb/ui/crumbs/runningbuild.py |    4 ++++
 2 files changed, 5 insertions(+), 0 deletions(-)
Signature · 1 line
1.7.7.4
#1 lore raw

PATCH 1/2 ui/crumbs/runningbuild: handle InvalidTask events

The knotty UI just ignores these and so should RunningBuild, if these events aren't handled the UI appears to hang.

Fixes [YOCTO #1665]

---
 lib/bb/ui/crumbs/runningbuild.py |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)
lib/bb/ui/crumbs/runningbuild.py +4 -0
index 509590a..4f609fc 100644
@@ -179,6 +179,10 @@ class RunningBuild (gobject.GObject):
             # that we need to attach to a task.
             self.tasks_to_iter[(package, task)] = i
 
+        # If we don't handle these the GUI does not proceed
+        elif isinstance(event, bb.build.TaskInvalid):
+            return
+
         elif isinstance(event, bb.build.TaskBase):
             current = self.tasks_to_iter[(package, task)]
             parent = self.tasks_to_iter[(package, None)]
Signature · 1 line
1.7.7.4
#2 lore raw

PATCH 2/2 ui/crumbs/hobprefs: trigger a reparse after changing IMAGE_FSTYPES

In reply to Joshua Lock

As reported on the mailing list[1] when changing IMAGE_FSTYPES through the hob preferences a reparse is required before the changes will be picked up by the system. This patch sets the reload_required property of the class to true when the image types have been modified to ensure the reparse is triggered.

1. https://lists.yoctoproject.org/pipermail/yocto/2011-December/006002.html

---
 lib/bb/ui/crumbs/hobprefs.py |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
lib/bb/ui/crumbs/hobprefs.py +1 -0
index 5dfb0e6..3f6f128 100644
@@ -39,6 +39,7 @@ class HobPrefs(gtk.Dialog):
             self.selected_image_types = handler.remove_image_output_type(ot)
 
         self.configurator.setConfVar('IMAGE_FSTYPES', "%s" % " ".join(self.selected_image_types).lstrip(" "))
+        self.reload_required = True
 
     def sdk_machine_combo_changed_cb(self, combo, handler):
         sdk_mach = combo.get_active_text()
Signature · 1 line
1.7.7.4
#3 lore raw
In reply to Joshua Lock
Quoted 10 lines · Joshua Lock

This series works around a couple of issues which I'd like to address for the Yocto Edison 1.1.1 release.

Regards,
Joshua

The following changes since commit 71b53a3f0766ca464560a1f6a449f9424fbdf7ae:

siggen.py: If both sigs have a variable in it's whitelist then don't say it's changed (2011-12-05 16:17:38 +0000)

Quoted 7 lines

are available in the git repository at:
git://github.com/incandescant/bitbake hob
https://github.com/incandescant/bitbake/tree/hob

Joshua Lock (2):
ui/crumbs/runningbuild: handle InvalidTask events ui/crumbs/hobprefs: trigger a reparse after changing IMAGE_FSTYPES

Merged to master, thanks.

Richard