Skip to contentSkip to conversation

warning fix of sysvinit-inittab.

PATCH Superseded Lianhao Lu 3 participants 4 messages Mar 19, 2012 – Mar 20, 2012

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Lianhao Lu

author
#0 lore raw

cover warning fix of sysvinit-inittab.

This fixed the warning in do_populate_lic task in sysvinit-inittab.

The following changes since commit efd80fd23cb96ccc203893017938c1163d20b898:
Richard Purdie (1):
tcl: Fix bad RPATH QA warning

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib llu/warningfix
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=llu/warningfix

Lianhao Lu (1):
sysvinit-inittab: Fixed license warning.

 .../sysvinit/sysvinit-inittab_2.88dsf.bb           |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
author
#1 lore raw

PATCH 1/1 sysvinit-inittab: Fixed license warning.

WARNING: .../sysvinit-inittab-2.88dsf-r6/sysvinit-2.88dsf/COPYING could not be copied for some reason. It may not exist. WARN for now.

Signed-off-by Lianhao Lu <[email protected]>
---
 .../sysvinit/sysvinit-inittab_2.88dsf.bb           |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)
meta/recipes-core/sysvinit/sysvinit-inittab_2.88dsf.bb +5 -1
index 3a716d7..85e34c8 100644
@@ -11,7 +11,11 @@ S = "${WORKDIR}/sysvinit-${PV}"
 
 INHIBIT_DEFAULT_DEPS = "1"
 
-do_configure() {
+do_unpack_append() {
+	bb.build.exec_func('do_copy_lic', d)
+}
+
+do_copy_lic () {
 	cp ${WORKDIR}/COPYING ${S}/
 }
Signature · 1 line
1.7.0.4
#2 lore raw

Re: [PATCH 1/1] sysvinit-inittab: Fixed license warning.

Quoted 13 lines · Lianhao Lu

WARNING: .../sysvinit-inittab-2.88dsf-r6/sysvinit-2.88dsf/COPYING could not be copied for some reason. It may not exist. WARN for now.

Signed-off-by Lianhao Lu<[email protected]>
---
  .../sysvinit/sysvinit-inittab_2.88dsf.bb           |    6 +++++-
  1 files changed, 5 insertions(+), 1 deletions(-)
meta/recipes-core/sysvinit/sysvinit-inittab_2.88dsf.bb +0 -0
index 3a716d7..85e34c8 100644

meta/recipes-core/sysvinit/sysvinit-inittab_2.88dsf.bb S = "${WORKDIR}/sysvinit-${PV}" · line 17

Quoted 8 lines
meta/recipes-core/sysvinit/sysvinit-inittab_2.88dsf.bb +4 -1
@@ -11,7 +11,11 @@ S = "${WORKDIR}/sysvinit-${PV}"
 
  INHIBIT_DEFAULT_DEPS = "1"
 
-do_configure() {
+do_unpack_append() {
+	bb.build.exec_func('do_copy_lic', d)
+}
+

I think it would be better to do the copy in a do_configure_prepend() Or can we set ${S} to ${WORKDIR} and not have to copy it at all?

Quoted 4 lines
meta/recipes-core/sysvinit/sysvinit-inittab_2.88dsf.bb +1 -0
+do_copy_lic () {
  	cp ${WORKDIR}/COPYING ${S}/
  }
#3 lore raw

Re: [PATCH 1/1] sysvinit-inittab: Fixed license warning.

Quoted 17 lines · Saul Wold
Quoted 16 lines · Lianhao Lu

WARNING: .../sysvinit-inittab-2.88dsf-r6/sysvinit-2.88dsf/COPYING could not be copied for some reason. It may not exist. WARN for now.

Signed-off-by Lianhao Lu<[email protected]>
---
  .../sysvinit/sysvinit-inittab_2.88dsf.bb           |    6 +++++-
  1 files changed, 5 insertions(+), 1 deletions(-)
meta/recipes-core/sysvinit/sysvinit-inittab_2.88dsf.bb +0 -0
index 3a716d7..85e34c8 100644
@@ -11,7 +11,11 @@ S = "${WORKDIR}/sysvinit-${PV}"
 
  INHIBIT_DEFAULT_DEPS = "1"
Quoted 13 lines

meta/recipes-core/sysvinit/sysvinit-inittab_2.88dsf.bb S = "${WORKDIR}/sysvinit-${PV}" · line 17

Quoted 5 lines
meta/recipes-core/sysvinit/sysvinit-inittab_2.88dsf.bb +4 -1
-do_configure() {
+do_unpack_append() {
+	bb.build.exec_func('do_copy_lic', d)
+}
+

I think it would be better to do the copy in a do_configure_prepend() Or can we set ${S} to ${WORKDIR} and not have to copy it at all?

Quoted 4 lines
meta/recipes-core/sysvinit/sysvinit-inittab_2.88dsf.bb +1 -0
+do_copy_lic () {
  	cp ${WORKDIR}/COPYING ${S}/
  }

How about changing the license URL to point at:

file://${COREBASE}/meta/files/common-licenses/GPL-2.0

?

Cheers,

Richard