Hob: fix 2098
cover Hob: fix 2098
This patch is to fix bug 2098 to make the build progress clear.
The following changes since commit 8350c03eeca3f5d70984797ef784f29c71cbbb3b:
gst-plugins: remove obsolete orcc hack (2012-03-23 12:13:09 +0000)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib shane/hob-fixes-1
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=shane/hob-fixes-1
Shane Wang (1):
Hob: add build status labels in the build details screen to make it
more close to the visual design
bitbake/lib/bb/ui/crumbs/builddetailspage.py | 17 +++++++++++-- bitbake/lib/bb/ui/crumbs/builder.py | 3 ++ bitbake/lib/bb/ui/crumbs/runningbuild.py | 33 +++++++++++++------------ 3 files changed, 34 insertions(+), 19 deletions(-)
Signature · 1 line
1.7.6
PATCH 1/1 Hob: add build status labels in the build details screen to make it more close to the visual design
This patch is to add build status (incl. "Running task XX of XX: XXXXXX") in the build details screen, in order to provide clear information about task in progress and make the GUI close to the visual design.
[Yocto #2098]
--- bitbake/lib/bb/ui/crumbs/builddetailspage.py | 17 +++++++++++-- bitbake/lib/bb/ui/crumbs/builder.py | 3 ++ bitbake/lib/bb/ui/crumbs/runningbuild.py | 33 +++++++++++++------------ 3 files changed, 34 insertions(+), 19 deletions(-)
bitbake/lib/bb/ui/crumbs/builddetailspage.py +14 -3
@@ -46,12 +46,17 @@ class BuildDetailsPage (HobPage): # create visual elements self.vbox = gtk.VBox(False, 12) - self.progress_box = gtk.HBox(False, 6) + self.progress_box = gtk.VBox(False, 12) + self.task_status = gtk.Label() + self.task_status.set_alignment(0.0, 0.5) + self.progress_box.pack_start(self.task_status, expand=False, fill=False) + self.progress_hbox = gtk.HBox(False, 6) + self.progress_box.pack_end(self.progress_hbox, expand=True, fill=True) self.progress_bar = HobProgressBar() - self.progress_box.pack_start(self.progress_bar, expand=True, fill=True) + self.progress_hbox.pack_start(self.progress_bar, expand=True, fill=True) self.stop_button = HobAltButton("Stop") self.stop_button.connect("clicked", self.stop_button_clicked_cb) - self.progress_box.pack_end(self.stop_button, expand=False, fill=False) + self.progress_hbox.pack_end(self.stop_button, expand=False, fill=False) self.notebook = HobNotebook() self.config_tv = BuildConfigurationTreeView()
@@ -82,6 +87,12 @@ class BuildDetailsPage (HobPage): self.back_button.connect("clicked", self.back_button_clicked_cb) self.button_box.pack_start(self.back_button, expand=False, fill=False) + def update_build_status(self, tsk_msg): + self.task_status.set_markup(tsk_msg) + + def reset_build_status(self): + self.task_status.set_markup("") + def show_issues(self): self.num_of_issues += 1 self.notebook.show_indicator_icon("Issues", self.num_of_issues)
bitbake/lib/bb/ui/crumbs/builder.py +3 -0
@@ -533,6 +533,7 @@ class Builder(gtk.Window): elif self.current_step == self.PACKAGE_GENERATING: fraction = 0 self.build_details_page.update_progress_bar("Build Started: ", fraction) + self.build_details_page.reset_build_status() self.build_details_page.reset_issues() def build_succeeded(self):
@@ -600,6 +601,8 @@ class Builder(gtk.Window): elif message["eventname"] == "runQueueTaskStarted": fraction = 0.2 + 0.8 * fraction self.build_details_page.update_progress_bar(title + ": ", fraction) + self.build_details_page.update_build_status( + "<span weight=\'bold\'>Running task %s of %s:</span> %s" % (message["current"], message["total"], message["task"])) def handler_build_failure_cb(self, running_build): self.build_details_page.show_issues()
bitbake/lib/bb/ui/crumbs/runningbuild.py +17 -16
@@ -69,24 +69,24 @@ class RunningBuildModel (gtk.TreeStore): class RunningBuild (gobject.GObject): __gsignals__ = { - 'build-started' : (gobject.SIGNAL_RUN_LAST, - gobject.TYPE_NONE, + 'build-started' : (gobject.SIGNAL_RUN_LAST, + gobject.TYPE_NONE, ()), - 'build-succeeded' : (gobject.SIGNAL_RUN_LAST, - gobject.TYPE_NONE, + 'build-succeeded' : (gobject.SIGNAL_RUN_LAST, + gobject.TYPE_NONE, + ()), + 'build-failed' : (gobject.SIGNAL_RUN_LAST, + gobject.TYPE_NONE, + ()), + 'build-complete' : (gobject.SIGNAL_RUN_LAST, + gobject.TYPE_NONE, + ()), + 'task-started' : (gobject.SIGNAL_RUN_LAST, + gobject.TYPE_NONE, + (gobject.TYPE_PYOBJECT,)), + 'log-error' : (gobject.SIGNAL_RUN_LAST, + gobject.TYPE_NONE, ()), - 'build-failed' : (gobject.SIGNAL_RUN_LAST, - gobject.TYPE_NONE, - ()), - 'build-complete' : (gobject.SIGNAL_RUN_LAST, - gobject.TYPE_NONE, - ()), - 'task-started' : (gobject.SIGNAL_RUN_LAST, - gobject.TYPE_NONE, - (gobject.TYPE_PYOBJECT,)), - 'log-error' : (gobject.SIGNAL_RUN_LAST, - gobject.TYPE_NONE, - ()), } pids_to_task = {} tasks_to_iter = {}
@@ -319,6 +319,7 @@ class RunningBuild (gobject.GObject): message["current"] = num_of_completed message["total"] = event.stats.total message["title"] = "" + message["task"] = event.taskstring self.emit("task-started", message) return
Signature · 1 line
1.7.6
Richard Purdie
AppliedQuoted 6 lines · Shane Wang
This patch is to fix bug 2098 to make the build progress clear.
The following changes since commit
8350c03eeca3f5d70984797ef784f29c71cbbb3b:gst-plugins: remove obsolete orcc hack (2012-03-23 12:13:09 +0000)
Quoted 7 lines
are available in the git repository at:
git://git.pokylinux.org/poky-contribshane/hob-fixes-1
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=shane/hob-fixes-1Shane Wang (1):
Hob: add build status labels in the build details screen to make it
more close to the visual design
Merged to master, thanks.
Richard