Skip to contentSkip to conversation

meta-yocto fix

PATCH RESEND In review Shane Wang 2 participants 3 messages Apr 2, 2012

lore
Share & tools
lore

Shane Wang

author
#0 lore raw

cover meta-yocto fix

The patch is to change local.conf to allow Hob change BB threads and pmake. Please review. In the current local.conf, BB_NUMBER_THREADS and PARALLEL_MAKE are assigned by '=', which overwrites the values set from the Hob. To avoid that, use '?=' instead.

The following changes since commit 8691a588267472eb5a32b978a0eb9ddfd0c91733:

cross-canadian.bbclass: fix rpath for sdk executables (2012-03-31 18:00:59 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib shane/meta-yocto
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=shane/meta-yocto

Shane Wang (1):
meta-yocto/local.conf.sample: change = to ?= for BB_NUMBER_THREADS
and PARALLEL_MAKE

 meta-yocto/conf/local.conf.sample |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.6
author
#1 lore raw

PATCH 1/1 meta-yocto/local.conf.sample: change = to ?= for BB_NUMBER_THREADS and PARALLEL_MAKE

In the current local.conf, BB_NUMBER_THREADS and PARALLEL_MAKE are assigned by '=', which overwrites the values set from the Hob. To avoid that, use '?=' instead.

[Yocto #2210]

---
 meta-yocto/conf/local.conf.sample |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
meta-yocto/conf/local.conf.sample +2 -2
index 38507e3..a4a8192 100644
@@ -17,12 +17,12 @@
 # These two options control how much parallelism BitBake should use. The first 
 # option determines how many tasks bitbake should run in parallel:
 #
-#BB_NUMBER_THREADS = "4"
+#BB_NUMBER_THREADS ?= "4"
 # 
 # The second option controls how many processes make should run in parallel when
 # running compile tasks:
 #
-#PARALLEL_MAKE = "-j 4"
+#PARALLEL_MAKE ?= "-j 4"
 #
 # For a quad-core machine, BB_NUMBER_THREADS = "4", PARALLEL_MAKE = "-j 4" would
 # be appropriate for example.
Signature · 1 line
1.7.6
#2 lore raw

Re: [PATCH 1/1] meta-yocto/local.conf.sample: change = to ?= for BB_NUMBER_THREADS and PARALLEL_MAKE

Quoted 10 lines · Shane Wang

In the current local.conf, BB_NUMBER_THREADS and PARALLEL_MAKE are assigned by '=', which overwrites the values set from the Hob. To avoid that, use '?=' instead.

[Yocto #2210]

---
 meta-yocto/conf/local.conf.sample |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

If the user has used "=" in their configuration files, hob needs to deal with this. It is not acceptable to patch the world to revolve around hob.

So, no, I'm not going to take this patch, sorry.

Cheers,

Richard