Skip to contentSkip to conversation

Ensure package dependency between connman and ofono

PATCH In review Lianhao Lu 2 participants 4 messages Apr 6, 2012 – Apr 10, 2012

lore
Share & tools
lore

Lianhao Lu

author
#0 lore raw

cover Ensure package dependency between connman and ofono

Make sure ofono package is generated when building connman.

The following changes since commit 1a82989345fb98becb487d270fd93a5e6dffeb47:
Saul Wold (1):
runqemu-internal: Add console=tty for qemuppc and NFS

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib llu/multilib
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=llu/multilib

Lianhao Lu (1):
connman: ensure ofono package is generated.

 meta/recipes-connectivity/connman/connman.inc |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
author
#1 lore raw

PATCH 1/1 connman: ensure ofono package is generated.

Make sure ofono package is generated when buidling connman, because dynamic package connman-plugin-ofono has a RDEPENDS on ofono.

---
 meta/recipes-connectivity/connman/connman.inc |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
meta/recipes-connectivity/connman/connman.inc +2 -0
index 1a6dd1b..3ed5667 100644
@@ -39,6 +39,8 @@ EXTRA_OECONF += "\
     --disable-ntpd \
 "
 
+do_package[depends] = "${MLPREFIX}ofono:do_package"
+
 INITSCRIPT_NAME = "connman"
 INITSCRIPT_PARAMS = "start 05 5 2 3 . stop 22 0 1 6 ."
 
Signature · 1 line
1.7.0.4
#2 lore raw

Re: [PATCH 1/1] connman: ensure ofono package is generated.

Quoted 3 lines · Lianhao Lu

Make sure ofono package is generated when buidling connman, because dynamic package connman-plugin-ofono has a RDEPENDS on ofono.

Since this is for a plugin, can the connman-plugin-ofono be generated in a separate package (or possibly even a separate recipe that depends on ofono, instead of making connman depend on ofono, I am not sure the solution below is correct either.

Sau!

Quoted 18 lines
---
  meta/recipes-connectivity/connman/connman.inc |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)
meta/recipes-connectivity/connman/connman.inc +2 -0
index 1a6dd1b..3ed5667 100644
@@ -39,6 +39,8 @@ EXTRA_OECONF += "\
      --disable-ntpd \
  "
 
+do_package[depends] = "${MLPREFIX}ofono:do_package"
+
  INITSCRIPT_NAME = "connman"
  INITSCRIPT_PARAMS = "start 05 5 2 3 . stop 22 0 1 6 ."
 
#3 lore raw

Re: [PATCH 1/1] connman: ensure ofono package is generated.

Saul Wold wrote on 2012-04-10:

Quoted 8 lines · Lianhao Lu
Quoted 3 lines

Make sure ofono package is generated when buidling connman, because dynamic package connman-plugin-ofono has a RDEPENDS on ofono.

Since this is for a plugin, can the connman-plugin-ofono be generated in a separate package (or possibly even a separate recipe that depends on ofono, instead of making connman depend on ofono, I am not sure the solution below is correct either.

connman-plugin-ofono is already generated in a separate dynamic package, just like other dynamic connman-plugin-bluez4. I think we'd better build the connman-plugin-ofono based on the value distro_features, just like we did for connman-plugin-bluez4 in commit http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit?id=1288313411f8db7628e9ec4c04f2ad7f830e994d. I'll remake the patch.

-Lianhao

Quoted 17 lines

Sau!

Quoted 9 lines
---
  meta/recipes-connectivity/connman/connman.inc |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)
meta/recipes-connectivity/connman/connman.inc +0 -0
index 1a6dd1b..3ed5667 100644

meta/recipes-connectivity/connman/connman.inc EXTRA_OECONF += "\ · line 44

Quoted 6 lines
meta/recipes-connectivity/connman/connman.inc +2 -0
@@ -39,6 +39,8 @@ EXTRA_OECONF += "\
      --disable-ntpd \
  "
+do_package[depends] = "${MLPREFIX}ofono:do_package"
+
  INITSCRIPT_NAME = "connman"
  INITSCRIPT_PARAMS = "start 05 5 2 3 . stop 22 0 1 6 ."

Best Regards,
Lianhao