connman: optionally build ofono plugin
v2 cover connman: optionally build ofono plugin
Only build connman ofono plugin when 3g distro feature is enabled.
The following changes since commit 1a82989345fb98becb487d270fd93a5e6dffeb47:
Saul Wold (1):
runqemu-internal: Add console=tty for qemuppc and NFS
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib llu/multilib
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=llu/multilib
Lianhao Lu (1):
connman: optionally build ofono plugin.
meta/recipes-connectivity/connman/connman.inc | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
PATCH v2 1/1 connman: optionally build ofono plugin.
Only build ofono plugin when 3g feature is enabled. Also add dependency to ofono when ofono plugin is being built.
This is part of the buf fixing [YOCTO #2216].
--- meta/recipes-connectivity/connman/connman.inc | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)
meta/recipes-connectivity/connman/connman.inc +2 -1
@@ -17,6 +17,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \ DEPENDS = "dbus glib-2.0 ppp iptables gnutls \ ${@base_contains('DISTRO_FEATURES', 'bluetooth','bluez4', '', d)} \ ${@base_contains('DISTRO_FEATURES', 'wifi','wpa-supplicant', '', d)} \ + ${@base_contains('DISTRO_FEATURES', '3g','ofono', '', d)} \ " EXTRA_OECONF += "\
@@ -30,7 +31,7 @@ EXTRA_OECONF += "\ ${@base_contains('DISTRO_FEATURES', 'wifi','--enable-wifi', '--disable-wifi', d)} \ ${@base_contains('DISTRO_FEATURES', 'bluetooth','--enable-bluetooth', '--disable-bluetooth', d)} \ --enable-dnsproxy \ - --enable-ofono \ + ${@base_contains('DISTRO_FEATURES', '3g','--enable-ofono', '--disable-ofono', d)} \ --enable-tools \ --enable-test \ --disable-polkit \
Signature · 1 line
1.7.0.4
Re: [PATCH V2 1/1] connman: optionally build ofono plugin.
This changes the default behaviour, so it should not go in for 1.2
Op 10 apr. 2012, om 05:16 heeft Lianhao Lu het volgende geschreven:
Quoted 39 lines
Only build ofono plugin when 3g feature is enabled. Also add dependency to ofono when ofono plugin is being built.
This is part of the buf fixing [YOCTO #2216].
Signed-off-by Lianhao Lu <[email protected]>---
meta/recipes-connectivity/connman/connman.inc | 3 ++-1 files changed, 2 insertions(+), 1 deletions(-)meta/recipes-connectivity/connman/connman.inc +2
-1@@ -17,6 +17,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=12f884d2ae1ff87c09e5b7ccc2c4ca7e \ DEPENDS = "dbus glib-2.0 ppp iptables gnutls \ ${@base_contains('DISTRO_FEATURES', 'bluetooth','bluez4', '', d)} \ ${@base_contains('DISTRO_FEATURES', 'wifi','wpa-supplicant', '', d)} \ + ${@base_contains('DISTRO_FEATURES', '3g','ofono', '', d)} \ " EXTRA_OECONF += "\@@ -30,7 +31,7 @@ EXTRA_OECONF += "\ ${@base_contains('DISTRO_FEATURES', 'wifi','--enable-wifi', '--disable-wifi', d)} \ ${@base_contains('DISTRO_FEATURES', 'bluetooth','--enable-bluetooth', '--disable-bluetooth', d)} \ --enable-dnsproxy \ - --enable-ofono \ + ${@base_contains('DISTRO_FEATURES', '3g','--enable-ofono', '--disable-ofono', d)} \ --enable-tools \ --enable-test \ --disable-polkit \Signature · 7 lines
1.7.0.4 _______________________________________________ Openembedded-core mailing list [email protected] http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [PATCH V2 1/1] connman: optionally build ofono plugin.
Hello Koen,
Quoted 1 line · Koen Kooi
This changes the default behaviour, so it should not go in for 1.2
I don't see why this shouldn't be included. It does improve build time and works for both OE-Core and Yocto setups.
Can you clarify what is your concerns?
Signature · 3 lines
Otavio Salvador O.S. Systems E-mail: [email protected] http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
Re: [PATCH V2 1/1] connman: optionally build ofono plugin.
Op 10 apr. 2012, om 13:18 heeft Otavio Salvador het volgende geschreven:
Quoted 9 lines
Hello Koen,
Quoted 1 line · Koen Kooi
This changes the default behaviour, so it should not go in for 1.2
I don't see why this shouldn't be included. It does improve build time and works for both OE-Core and Yocto setups.
Can you clarify what is your concerns?
It changes the default behaviour. There shouldn't be any behaviour changes so late in the release cycle. And apart from that, it should use PACKAGECONFIG :)
Re: [PATCH V2 1/1] connman: optionally build ofono plugin.
Quoted 4 lines · Koen Kooi
Quoted 1 line
Can you clarify what is your concerns?
It changes the default behaviour. There shouldn't be any behaviour changes so late in the release cycle. And apart from that, it should use PACKAGECONFIG :)
I agree about PACKAGECONFIG but this behaviour change seems acceptable for me since most users won't be using 3g and will be not affected by this.
Signature · 3 lines
Otavio Salvador O.S. Systems E-mail: [email protected] http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
Re: [PATCH V2 1/1] connman: optionally build ofono plugin.
Quoted 9 lines · Otavio Salvador
Quoted 4 lines · Koen Kooi
Quoted 1 line
Can you clarify what is your concerns?
It changes the default behaviour. There shouldn't be any behaviour changes so late in the release cycle. And apart from that, it should use PACKAGECONFIG :)
I agree about PACKAGECONFIG but this behaviour change seems acceptable for me since most users won't be using 3g and will be not affected by this.
So how about we just add ophono to DEPENDS for 1.2 (since its implied and enabled as things stand) and then in 1.3 we use PACKAGECONFIG?
Cheers,
Richard
Re: [PATCH V2 1/1] connman: optionally build ofono plugin.
Op 10 apr. 2012, om 14:08 heeft Richard Purdie het volgende geschreven:
Quoted 7 lines · Otavio Salvador
Quoted 6 lines · Koen Kooi
Quoted 4 lines
Quoted 1 line
Can you clarify what is your concerns?
It changes the default behaviour. There shouldn't be any behaviour changes so late in the release cycle. And apart from that, it should use PACKAGECONFIG :)
Quoted 6 lines
Quoted 3 lines
I agree about PACKAGECONFIG but this behaviour change seems acceptable for me since most users won't be using 3g and will be not affected by this.
So how about we just add ophono to DEPENDS for 1.2 (since its implied and enabled as things stand) and then in 1.3 we use PACKAGECONFIG?
That works for me.
regards,
koen