gst-plugins-bad: dependency fix
Hi Richard and Saul,
This pull request adds curl as gst-plugins-bad's dependency.
Please help to review and pull.
Thanks,
Dongxiao
The following changes since commit be298b6f0168bbd6baf90602da35904c441deade:
nspr: fix package spliting (2012-04-14 09:33:54 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib dxu4/hob-bugfix-oecore
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=dxu4/hob-bugfix-oecore
Dongxiao Xu (1):
gst-plugins-bad: add curl as build dependency
.../gstreamer/gst-plugins-bad_0.10.23.bb | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Signature · 1 line
1.7.4.1
PATCH 1/1 gst-plugins-bad: add curl as build dependency
gst-plugins-bad needs curl.h to finish its build, so add curl as its dependency.
--- .../gstreamer/gst-plugins-bad_0.10.23.bb | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
meta/recipes-multimedia/gstreamer/gst-plugins-bad_0.10.23.bb +1 -1
@@ -6,7 +6,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \ file://COPYING.LIB;md5=55ca817ccb7d5b5b66355690e9abc605 \ file://gst/tta/crc32.h;beginline=12;endline=29;md5=71a904d99ce7ae0c1cf129891b98145c" -DEPENDS += "gst-plugins-base libmusicbrainz tremor librsvg" +DEPENDS += "gst-plugins-base libmusicbrainz tremor librsvg curl" PR = "r1"
Signature · 1 line
1.7.4.1
Re: [PATCH 1/1] gst-plugins-bad: add curl as build dependency
Op 14 apr. 2012, om 12:44 heeft Dongxiao Xu het volgende geschreven:
Quoted 2 lines
gst-plugins-bad needs
curl.hto finish its build, so add curl as its dependency.
I can't be sure without the exact failure log, but: missing PR bump
regards,
Koen
Re: [PATCH 1/1] gst-plugins-bad: add curl as build dependency
Quoted 6 lines · Koen Kooi
Op 14 apr. 2012, om 12:44 heeft Dongxiao Xu het volgende geschreven:
Quoted 2 lines
gst-plugins-bad needs
curl.hto finish its build, so add curl as its dependency.I can't be sure without the exact failure log, but: missing PR bump
Add a dependency here doesn't impact the original build. If the original build is successful, it means curl has already been built by chance. Do we still need to bump PR in this case?
Besides, this is the detailed log:
i586-poky-linux-libtool: compile: i586-poky-linux-gcc -m32 -march=i586
--sysroot=/distro/sdb/build-master/tmp/sysroots/qemux86 -std=gnu99
-DHAVE_CONFIG_H -I. -I../.. -pthread
-I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -pthread -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -DG_THREADS_MANDATORY -DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -Wall -Wdeclaration-after-statement -Wvla -Wpointer-arith -Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wwrite-strings -Wformat-security -Wold-style-definition -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wnested-externs -O2 -pipe -g -feliminate-unused-debug-types -c gstcurlsink.c -fPIC -DPIC -o .libs/libgstcurl_la-gstcurlsink.o
i586-poky-linux-libtool: compile: i586-poky-linux-gcc -m32 -march=i586
--sysroot=/distro/sdb/build-master/tmp/sysroots/qemux86 -std=gnu99
-DHAVE_CONFIG_H -I. -I../.. -pthread
-I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -pthread -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -DG_THREADS_MANDATORY -DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -Wall -Wdeclaration-after-statement -Wvla -Wpointer-arith -Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wwrite-strings -Wformat-security -Wold-style-definition -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wnested-externs -O2 -pipe -g -feliminate-unused-debug-types -c gstcurl.c -fPIC -DPIC -o .libs/libgstcurl_la-gstcurl.o gstcurlsink.c:45:23: fatal error: curl/curl.h: No such file or directory
compilation terminated.
make[3]: *** [libgstcurl_la-gstcurlsink.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
Thanks,
Dongxiao
Quoted 9 lines
regards,
Koen
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Re: [PATCH 1/1] gst-plugins-bad: add curl as build dependency
Quoted 16 lines · Dongxiao
Quoted 6 lines · Koen Kooi
Op 14 apr. 2012, om 12:44 heeft Dongxiao Xu het volgende geschreven:
Quoted 2 lines
gst-plugins-bad needs
curl.hto finish its build, so add curl as its dependency.I can't be sure without the exact failure log, but: missing PR bump
Add a dependency here doesn't impact the original build. If the original build is successful, it means curl has already been built by chance. Do we still need to bump PR in this case?
Besides, this is the detailed log:
i586-poky-linux-libtool: compile: i586-poky-linux-gcc -m32 -march=i586 --sysroot=/distro/sdb/build-master/tmp/sysroots/qemux86 -std=gnu99
Review
Quoted 2 lines
(quoted diff) +0
-2-DHAVE_CONFIG_H -I. -I../.. -pthread -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -pthread -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -DG_THREADS_MANDATORY -DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -Wall -Wdeclaration-after-statement -Wvla -Wpointer-arith -Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wwrite-strings -Wformat-security -Wold-style-definition -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wnested-externs -O2 -pipe -g -feliminate-unused-debug-types -c gstcurlsink.c -fPIC -DPIC -o .libs/libgstc
ur
Review
Quoted 5 lines
l_la-gstcurlsink.o
i586-poky-linux-libtool: compile: i586-poky-linux-gcc -m32 -march=i586 --sysroot=/distro/sdb/build-master/tmp/sysroots/qemux86 -std=gnu99(quoted diff) +0
-2-DHAVE_CONFIG_H -I. -I../.. -pthread -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -pthread -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -DG_THREADS_MANDATORY -DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -Wall -Wdeclaration-after-statement -Wvla -Wpointer-arith -Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wwrite-strings -Wformat-security -Wold-style-definition -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wnested-externs -O2 -pipe -g -feliminate-unused-debug-types -c gstcurl.c -fPIC -DPIC -o .libs/libgstcurl_
la
Quoted 5 lines
-gstcurl.o
gstcurlsink.c:45:23: fatal error:curl/curl.h: No such file or directory compilation terminated.
make[3]: *** [libgstcurl_la-gstcurlsink.lo] Error 1
make[3]: *** Waiting for unfinished jobs....
That's certainly wrong, because for me curl is a new dependency, i.e. it didn't need to be built before this patch went in.
The error above is probably the symptom of a race condition, where curl was rebuilt and thus removed from the sysroot after gst-plugins-bad was configured.
So either a PR bump is required or --disable-curl (or such) should have been used instead.
Regards,
Andreas
Re: [PATCH 1/1] gst-plugins-bad: add curl as build dependency
Quoted 13 lines · Andreas Oberritter
Quoted 12 lines · Dongxiao
Quoted 6 lines · Koen Kooi
Op 14 apr. 2012, om 12:44 heeft Dongxiao Xu het volgende geschreven:
Quoted 2 lines
gst-plugins-bad needs
curl.hto finish its build, so add curl as its dependency.I can't be sure without the exact failure log, but: missing PR bump
Add a dependency here doesn't impact the original build. If the original build is successful, it means curl has already been built by chance. Do we still need to bump PR in this case?
Quoted 6 lines
Review
Quoted 6 lines
Besides, this is the detailed log:
i586-poky-linux-libtool: compile: i586-poky-linux-gcc -m32 -march=i586 --sysroot=/distro/sdb/build-master/tmp/sysroots/qemux86 -std=gnu99
(quoted diff) +0
-2-DHAVE_CONFIG_H -I. -I../.. -pthread -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -pthread -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -DG_THREADS_MANDATORY -DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -Wall -Wdeclaration-after-statement -Wvla -Wpointer-arith -Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wwrite-strings -Wformat-security -Wold-style-definition -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wnested-externs -O2 -pipe -g -feliminate-unused-debug-types -c gstcurlsink.c -fPIC -DPIC -o .libs/libg!
stc
Quoted 6 lines
ur
Review
Quoted 5 lines
l_la-gstcurlsink.o
i586-poky-linux-libtool: compile: i586-poky-linux-gcc -m32 -march=i586 --sysroot=/distro/sdb/build-master/tmp/sysroots/qemux86 -std=gnu99(quoted diff) +0
-2-DHAVE_CONFIG_H -I. -I../.. -pthread -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -pthread -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/gstreamer-0.10 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/glib-2.0 -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/lib/glib-2.0/include -I/distro/sdb/build-master/tmp/sysroots/qemux86/usr/include/libxml2 -DG_THREADS_MANDATORY -DG_DISABLE_CAST_CHECKS -DG_DISABLE_ASSERT -Wall -Wdeclaration-after-statement -Wvla -Wpointer-arith -Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wwrite-strings -Wformat-security -Wold-style-definition -Winit-self -Wmissing-include-dirs -Waddress -Wno-multichar -Wnested-externs -O2 -pipe -g -feliminate-unused-debug-types -c gstcurl.c -fPIC -DPIC -o .libs/libgstcu!
rl_
Quoted 10 lines
la
Quoted 5 lines
-gstcurl.o
gstcurlsink.c:45:23: fatal error:curl/curl.h: No such file or directory compilation terminated.
make[3]: *** [libgstcurl_la-gstcurlsink.lo] Error 1
make[3]: *** Waiting for unfinished jobs....That's certainly wrong, because for me curl is a new dependency, i.e. it didn't need to be built before this patch went in.
Quoted 6 lines
The error above is probably the symptom of a race condition, where curl was rebuilt and thus removed from the sysroot after gst-plugins-bad was configured.
So either a PR bump is required or --disable-curl (or such) should have been used instead.
I want the builds to be deterministic so either enabling curl (via DEPENDS) or disabling it through the configure option would be fine. I went with adding curl since gst-plugins-bad is one of the last packages to build on the autobuilder and hence it would usually have had curl built so that is the most tested configuration I'm aware of.
I've pushed a PR bump.
Cheers,
Richard