Skip to contentSkip to conversation

Hob UI fixes

PATCH New Shane Wang 1 participant 3 messages Apr 16, 2012

lore
Share & tools
lore

Shane Wang

author
#0 lore raw

cover Hob UI fixes

These are two UI fixes submitted by Liming.

One is to fix the overlay-scrollbar with the multiple overlaped scrollbar in 'Recipe View' notebook or 'Package View' notebook.

The other is to fix the binb dialog, without the patch, we could have a lot of binb dialogs and should close them in order on Ubuntu 11.10. But on Ubuntu 10.04, no that issue.

Please review and check in.

The following changes since commit 2ddf7d3e8326e8cb07101ddb2d6e5dc6866371e2:

gcc-configure-common.inc: Stop gcc looking at build system paths (2012-04-15 18:09:57 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib shane/hob_0416
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=shane/hob_0416

Liming An (2):
Hob: fixed the issue that the notebook overlay-scrollbar is
overlapped
Hob: add the parent window to 'binb' popup window for managing it

 bitbake/lib/bb/ui/crumbs/builder.py           |    2 +-
 bitbake/lib/bb/ui/crumbs/hobwidget.py         |    1 -
 bitbake/lib/bb/ui/crumbs/persistenttooltip.py |    6 +++++-
 3 files changed, 6 insertions(+), 3 deletions(-)
Signature · 1 line
1.7.6
author
#1 lore raw

PATCH 1/2 Hob: fixed the issue that the notebook overlay-scrollbar is overlapped

From: Liming An <[email protected]>

In those systems which had use gtk overlay-scrollbar feature,such as Ubuntu 11.10, we have the issue with the multiple overlaped scrollbar in 'Recipe View' notebook or 'Package View' notebook, this patch is going to fix it.

---
 bitbake/lib/bb/ui/crumbs/hobwidget.py |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
bitbake/lib/bb/ui/crumbs/hobwidget.py +0 -1
index a42cdec..490de4a 100644
@@ -165,7 +165,6 @@ class HobViewTable (gtk.VBox):
 
         scroll = gtk.ScrolledWindow()
         scroll.set_policy(gtk.POLICY_NEVER, gtk.POLICY_ALWAYS)
-        scroll.set_shadow_type(gtk.SHADOW_IN)
         scroll.add(self.table_tree)
         self.pack_start(scroll, True, True, 0)
 
Signature · 1 line
1.7.6
author
#2 lore raw

PATCH 2/2 Hob: add the parent window to 'binb' popup window for managing it

From: Liming An <[email protected]>

The 'binb' popup window should be "set transient for" the main application window which they were spawned from.

---
 bitbake/lib/bb/ui/crumbs/builder.py           |    2 +-
 bitbake/lib/bb/ui/crumbs/persistenttooltip.py |    6 +++++-
 2 files changed, 6 insertions(+), 2 deletions(-)
bitbake/lib/bb/ui/crumbs/builder.py +1 -1
index bd45016..0f85cf5 100755
@@ -898,7 +898,7 @@ class Builder(gtk.Window):
 
     def show_binb_dialog(self, binb):
         markup = "<b>Brought in by:</b>\n%s" % binb
-        ptip = PersistentTooltip(markup)
+        ptip = PersistentTooltip(markup, self)
 
         ptip.show()
 
bitbake/lib/bb/ui/crumbs/persistenttooltip.py +5 -1
index 4db3018..b43d297 100644
@@ -35,7 +35,7 @@ class PersistentTooltip(gtk.Window):
 
     markup: some Pango text markup to display in the tooltip
     """
-    def __init__(self, markup):
+    def __init__(self, markup, parent_win=None):
         gtk.Window.__init__(self, gtk.WINDOW_POPUP)
 
         # Inherit the system theme for a tooltip
@@ -76,6 +76,10 @@ class PersistentTooltip(gtk.Window):
         # Ensure a reasonable minimum size
         self.set_geometry_hints(self, 100, 50)
 
+        # Set this window as a transient window for parent(main window)
+        if parent_win:
+            self.set_transient_for(parent_win)
+            self.set_destroy_with_parent(True)
         # Draw our label and close buttons
         hbox = gtk.HBox(False, 0)
         hbox.show()
Signature · 1 line
1.7.6