Skip to contentSkip to conversation

Misc Fixes

PATCH In review [email protected] 3 participants 4 messages Apr 16, 2012

lore
Share & tools
lore
#0 lore raw

cover Misc Fixes

From: Nitin A Kamble <[email protected]>

The following changes since commit a5afc58319d3c7e082a090f5fad7f89bd6e588c9:

connman-gnome: fix segfault on connect (2012-04-16 22:53:00 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib nitin/bugfixes
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=nitin/bugfixes

Nitin A Kamble (1):
poky-tiny: fix eglibc configuration

 meta-yocto/conf/distro/poky-tiny.conf |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
1.7.7
#1 lore raw

PATCH 1/1 poky-tiny: fix eglibc configuration

From: Nitin A Kamble <[email protected]>

eglibc needs libc-posix-regexp-glibc & libc-libm-big enabled in it's configuration to avoid following eglibc build issue.

...

| In file included from xregex.c:634:0:
| xregex.c: In function 'byte_regex_compile':
| xregex.c:3395:8: error: too few arguments to function 'findidx'
| ../locale/weight.h:23:1: note: declared here

...

This fixes bug [YOCTO #2295]

---
 meta-yocto/conf/distro/poky-tiny.conf |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
meta-yocto/conf/distro/poky-tiny.conf +2 -2
index 58d64ec..626b2d0 100644
@@ -62,7 +62,7 @@ ASSUME_PROVIDED += "pkgconfig$"
 
 # Reconfigure eglibc for a smaller installation
 # Comment out any of the lines below to disable them in the build
-DISTRO_FEATURES_LIBC_TINY = "libc-libm libc-crypt"
+DISTRO_FEATURES_LIBC_TINY = "libc-libm libc-libm-big libc-crypt"
 # for gettext
 DISTRO_FEATURES_LIBC_TINY += "libc-posix-clang-wchar"
 # for m4
@@ -71,7 +71,7 @@ DISTRO_FEATURES_LIBC_TINY += "libc-spawn libc-locale-code"
 DISTRO_FEATURES_LIBC_TINY += "libc-ftraverse"
 # Required for "who"
 DISTRO_FEATURES_LIBC_MINIMAL = "libc-utmp libc-getlogin"
-DISTRO_FEATURES_LIBC_REGEX = "libc-posix-regexp"
+DISTRO_FEATURES_LIBC_REGEX = "libc-posix-regexp libc-posix-regexp-glibc"
 DISTRO_FEATURES_LIBC_NET = "libc-inet libc-nis"
 
 DISTRO_FEATURES_LIBC = "${DISTRO_FEATURES_LIBC_TINY} \
Signature · 1 line
1.7.7
#2 lore raw

Re: [PATCH 1/1] poky-tiny: fix eglibc configuration

Quoted 11 lines · On 4/16/12 5:14 PM, [email protected] wrote:

From: Nitin A Kamble<[email protected]>

eglibc needs libc-posix-regexp-glibc& libc-libm-big enabled in it's configuration to avoid following eglibc build issue.

...

| In file included from xregex.c:634:0:
| xregex.c: In function 'byte_regex_compile':
| xregex.c:3395:8: error: too few arguments to function 'findidx'
| ../locale/weight.h:23:1: note: declared here

...

If glibc is failing to build because of the above, you need to report the failure to the eglibc mailing list.

eglibc is expected to build with those items disabled.

If it's another package, then it would be nice to know which item it is, as there may be a workaround.. (coreutils for instance has the ability to provide an internal regex function...)

--Mark

Quoted 29 lines

This fixes bug [YOCTO #2295]

---
  meta-yocto/conf/distro/poky-tiny.conf |    4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)
meta-yocto/conf/distro/poky-tiny.conf +2 -2
index 58d64ec..626b2d0 100644
@@ -62,7 +62,7 @@ ASSUME_PROVIDED += "pkgconfig$"
 
  # Reconfigure eglibc for a smaller installation
  # Comment out any of the lines below to disable them in the build
-DISTRO_FEATURES_LIBC_TINY = "libc-libm libc-crypt"
+DISTRO_FEATURES_LIBC_TINY = "libc-libm libc-libm-big libc-crypt"
  # for gettext
  DISTRO_FEATURES_LIBC_TINY += "libc-posix-clang-wchar"
  # for m4
@@ -71,7 +71,7 @@ DISTRO_FEATURES_LIBC_TINY += "libc-spawn libc-locale-code"
  DISTRO_FEATURES_LIBC_TINY += "libc-ftraverse"
  # Required for "who"
  DISTRO_FEATURES_LIBC_MINIMAL = "libc-utmp libc-getlogin"
-DISTRO_FEATURES_LIBC_REGEX = "libc-posix-regexp"
+DISTRO_FEATURES_LIBC_REGEX = "libc-posix-regexp libc-posix-regexp-glibc"
  DISTRO_FEATURES_LIBC_NET = "libc-inet libc-nis"
 
  DISTRO_FEATURES_LIBC = "${DISTRO_FEATURES_LIBC_TINY} \
#3 lore raw

Re: [PATCH 1/1] poky-tiny: fix eglibc configuration

In reply to [email protected]
Quoted 33 lines · On 04/16/2012 03:23 PM, [email protected] wrote:

From: Nitin A Kamble <[email protected]>

eglibc needs libc-posix-regexp-glibc & libc-libm-big enabled in it's configuration to avoid following eglibc build issue.

...

| In file included from xregex.c:634:0:
| xregex.c: In function 'byte_regex_compile':
| xregex.c:3395:8: error: too few arguments to function 'findidx'
| ../locale/weight.h:23:1: note: declared here

...

This fixes bug [YOCTO #2295]

---
 meta-yocto/conf/distro/poky-tiny.conf |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
meta-yocto/conf/distro/poky-tiny.conf +1 -1
index 58d64ec..626b2d0 100644
@@ -62,7 +62,7 @@ ASSUME_PROVIDED += "pkgconfig$"
 
 # Reconfigure eglibc for a smaller installation
 # Comment out any of the lines below to disable them in the build
-DISTRO_FEATURES_LIBC_TINY = "libc-libm libc-crypt"
+DISTRO_FEATURES_LIBC_TINY = "libc-libm libc-libm-big libc-crypt"
 # for gettext
 DISTRO_FEATURES_LIBC_TINY += "libc-posix-clang-wchar"
 # for m4

meta-yocto/conf/distro/poky-tiny.conf DISTRO_FEATURES_LIBC_TINY += "libc-spawn libc-locale-code" · line 77

Quoted 8 lines
meta-yocto/conf/distro/poky-tiny.conf +1 -1
@@ -71,7 +71,7 @@ DISTRO_FEATURES_LIBC_TINY += "libc-spawn libc-locale-code"
 DISTRO_FEATURES_LIBC_TINY += "libc-ftraverse"
 # Required for "who"
 DISTRO_FEATURES_LIBC_MINIMAL = "libc-utmp libc-getlogin"
-DISTRO_FEATURES_LIBC_REGEX = "libc-posix-regexp"
+DISTRO_FEATURES_LIBC_REGEX = "libc-posix-regexp libc-posix-regexp-glibc"
 DISTRO_FEATURES_LIBC_NET = "libc-inet libc-nis"
 
 DISTRO_FEATURES_LIBC = "${DISTRO_FEATURES_LIBC_TINY} \

I have a patch that makes it clear which features are added for the toolchain. This will make it easier to reduce in the future as well. I'll test with the libm-big added to that and report on size increase and send that patch for inclusion.

Nitin, thank you for identifying the missing lib. I would prefer we not merge this patch as is. It will only collide with my cleanup patch. I might as well integrate it into the cleanup patch and send it out as one. Will have it tested and sent out as soon as I can get a few builds to complete.

Signature · 3 lines
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel