add x/ehci-hcd and mei features

PATCH In review [email protected] 3 participants 17 messages May 3, 2012 – May 4, 2012

lore

Share & tools

lore

[email protected]

author

2012-05-03 03:35 UTC #0 lore raw

cover add x/ehci-hcd and mei features

From: Tom Zanussi <[email protected]>

This adds a few new features, one for xhci-hcd and another for amt/mei, and refactors some existing config options into a new echi-hcd, which is then used in crownbay.

If this looks like the way to go, I'll add similar USB features for ohci and uhci and fix up all the meta-intel BSPs to use them.

Please pull into linux-yocto-3.2.

Thanks,

Tom

The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
Yang Shi (1):
meta: Clean up BSPs kernel config

are available in the git repository at:

git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features

Tom Zanussi (5):
meta: add usb/host/base feature
meta: add usb/xhci-hcd feature
meta: add usb/ehci-hcd feature
meta/crownbay: use ehci-hcd feature
meta: add mei feature

 meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg    |    4 ----
 meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    2 ++
 meta/cfg/kernel-cache/features/amt/mei/mei.cfg     |    3 +++
 meta/cfg/kernel-cache/features/amt/mei/mei.scc     |    4 ++++
 .../features/usb/ehci-hcd/ehci-hcd.cfg             |    1 +
 .../features/usb/ehci-hcd/ehci-hcd.scc             |    6 ++++++
 meta/cfg/kernel-cache/features/usb/host/base.cfg   |    3 +++
 meta/cfg/kernel-cache/features/usb/host/base.scc   |    4 ++++
 .../features/usb/xhci-hcd/xhci-hcd.cfg             |    1 +
 .../features/usb/xhci-hcd/xhci-hcd.scc             |    6 ++++++
 10 files changed, 30 insertions(+), 4 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
 create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc
 create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc
 create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc
 create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc

[email protected]

author

2012-05-03 03:35 UTC #1 lore raw

PATCH 1/5 meta: add usb/host/base feature

From: Tom Zanussi <[email protected]>

Add a feature to enable 'base' support for USB, mainly to be included by derived features such as ehch, xhci, etc.

Signed-off-by Tom Zanussi <[email protected]>

---
 meta/cfg/kernel-cache/features/usb/host/base.cfg |    3 +++
 meta/cfg/kernel-cache/features/usb/host/base.scc |    4 ++++
 2 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc

meta/cfg/kernel-cache/features/usb/host/base.cfg new file +3 -0

new file mode 100644
index 0000000..dec6a47
@@ -0,0 +1,3 @@
+CONFIG_USB_SUPPORT=y
+CONFIG_USB=y
+

meta/cfg/kernel-cache/features/usb/host/base.scc new file +4 -0

new file mode 100644
index 0000000..3c93475
@@ -0,0 +1,4 @@
+define KFEATURE_DESCRIPTION "Enable core options for USB support"
+define KFEATURE_COMPATIBILITY board
+
+kconf hardware base.cfg

Signature · 1 line

1.7.0.4

[email protected]

author

2012-05-03 03:35 UTC #2 lore raw

PATCH 2/5 meta: add usb/xhci-hcd feature

From: Tom Zanussi <[email protected]>

Add an 'xhci-hcd' feature that turns on the kernel options required to support xhci (USB 3.0).

Signed-off-by Tom Zanussi <[email protected]>

---
 .../features/usb/xhci-hcd/xhci-hcd.cfg             |    1 +
 .../features/usb/xhci-hcd/xhci-hcd.scc             |    6 ++++++
 2 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc

meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg new file +1 -0

new file mode 100644
index 0000000..ae4294b
@@ -0,0 +1 @@
+CONFIG_USB_XHCI_HCD=y

meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc new file +6 -0

new file mode 100644
index 0000000..e9251af
@@ -0,0 +1,6 @@
+define KFEATURE_DESCRIPTION "Enable options for xhci (USB 3.0)"
+define KFEATURE_COMPATIBILITY board
+
+kconf hardware xhci-hcd.cfg
+
+include features/usb/host/base.scc

Signature · 1 line

1.7.0.4

[email protected]

author

2012-05-03 03:35 UTC #3 lore raw

PATCH 3/5 meta: add usb/ehci-hcd feature

In reply to [email protected]

From: Tom Zanussi <[email protected]>

Add an 'ehci-hcd' feature that turns on the kernel options required to support ehci (USB 2.0).

Signed-off-by Tom Zanussi <[email protected]>

---
 .../features/usb/ehci-hcd/ehci-hcd.cfg             |    1 +
 .../features/usb/ehci-hcd/ehci-hcd.scc             |    6 ++++++
 2 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc

meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg new file +1 -0

new file mode 100644
index 0000000..7322dc2
@@ -0,0 +1 @@
+CONFIG_USB_EHCI_HCD=y

meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc new file +6 -0

new file mode 100644
index 0000000..6ed0944
@@ -0,0 +1,6 @@
+define KFEATURE_DESCRIPTION "Enable options for ehci (USB 2.0)"
+define KFEATURE_COMPATIBILITY board
+
+kconf hardware ehci-hcd.cfg
+
+include features/usb/host/base.scc

Signature · 1 line

1.7.0.4

[email protected]

author

2012-05-03 03:35 UTC #4 lore raw

PATCH 4/5 meta/crownbay: use ehci-hcd feature

In reply to [email protected]

From: Tom Zanussi <[email protected]>

Use the ehci-hcd feature and remove the associated config settings from crownbay.cfg

Signed-off-by Tom Zanussi <[email protected]>

---
 meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg |    4 ----
 meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc |    2 ++
 2 files changed, 2 insertions(+), 4 deletions(-)

meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg +0 -4

index b101419..7a8b7ba 100644
@@ -10,13 +10,9 @@ CONFIG_ATA_SFF=y
 CONFIG_PCI=y
 CONFIG_MMC=y
 CONFIG_MMC_SDHCI=y
-CONFIG_USB_SUPPORT=y
-CONFIG_USB=y
-CONFIG_USB_ARCH_HAS_EHCI=y
 CONFIG_R8169=y
 CONFIG_PATA_SCH=y
 CONFIG_MMC_SDHCI_PCI=y
-CONFIG_USB_EHCI_HCD=y
 CONFIG_PCIEPORTBUS=y
 CONFIG_NET=y
 CONFIG_USB_UHCI_HCD=y

meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc +2 -0

index 0ff6ac6..968c648 100644
@@ -16,3 +16,5 @@ include features/logbuf/size-normal.scc
 
 include features/latencytop/latencytop.scc
 include features/profiling/profiling.scc
+
+include features/usb/ehci-hcd/ehci-hcd.scc

Signature · 1 line

1.7.0.4

[email protected]

author

2012-05-03 03:35 UTC #5 lore raw

PATCH 5/5 meta: add mei feature

In reply to [email protected]

From: Tom Zanussi <[email protected]>

Add an 'mei' feature that turns on the kernel options required to support the Intel Management Engine Interface.

Signed-off-by Tom Zanussi <[email protected]>

---
 meta/cfg/kernel-cache/features/amt/mei/mei.cfg |    3 +++
 meta/cfg/kernel-cache/features/amt/mei/mei.scc |    4 ++++
 2 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg
 create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc

meta/cfg/kernel-cache/features/amt/mei/mei.cfg new file +3 -0

new file mode 100644
index 0000000..c1c2ace
@@ -0,0 +1,3 @@
+CONFIG_STAGING=y
+CONFIG_WATCHDOG_CORE=y
+CONFIG_INTEL_MEI=y

meta/cfg/kernel-cache/features/amt/mei/mei.scc new file +4 -0

new file mode 100644
index 0000000..c506a04
@@ -0,0 +1,4 @@
+define KFEATURE_DESCRIPTION "Enable options for the Intel Management Engine Interface"
+define KFEATURE_COMPATIBILITY board
+
+kconf hardware mei.cfg

Signature · 1 line

1.7.0.4

Darren Hart

2012-05-04 16:17 UTC #6 lore raw

Re: [PATCH 1/5][KERNEL] meta: add usb/host/base feature

In reply to [email protected]

Quoted 4 lines · On 05/02/2012 08:35 PM, [email protected] wrote:

From: Tom Zanussi <[email protected]>
Add a feature to enable 'base' support for USB, mainly to be included by derived features such as ehch, xhci, etc.

This seems overly granular in my opinion. I think I would just include the two required options in each of the *hci features.

--
Darren

Quoted 28 lines

Signed-off-by Tom Zanussi <[email protected]>

---
 meta/cfg/kernel-cache/features/usb/host/base.cfg |    3 +++
 meta/cfg/kernel-cache/features/usb/host/base.scc |    4 ++++
 2 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc

meta/cfg/kernel-cache/features/usb/host/base.cfg new file +3 -0

new file mode 100644
index 0000000..dec6a47
@@ -0,0 +1,3 @@
+CONFIG_USB_SUPPORT=y
+CONFIG_USB=y
+

meta/cfg/kernel-cache/features/usb/host/base.scc new file +4 -0

new file mode 100644
index 0000000..3c93475
@@ -0,0 +1,4 @@
+define KFEATURE_DESCRIPTION "Enable core options for USB support"
+define KFEATURE_COMPATIBILITY board
+
+kconf hardware base.cfg

Signature · 3 lines

Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Tom Zanussi

author

2012-05-04 16:28 UTC #7 lore raw

Re: [PATCH 1/5][KERNEL] meta: add usb/host/base feature

Quoted 10 lines · Darren Hart

Quoted 4 lines · On 05/02/2012 08:35 PM, [email protected] wrote:
From: Tom Zanussi <[email protected]>
Add a feature to enable 'base' support for USB, mainly to be included by derived features such as ehch, xhci, etc.
This seems overly granular in my opinion. I think I would just include the two required options in each of the *hci features.

Really? This seems to me a perfect use case for taking advantage of the 'reusibality' conf fragments offer. There would be four of these, that alone would seem to justify using a 'subroutine', but there could be more in the future, and if so, this fragment would be readily available.

i.e. I don't see any reason to 'inline' these...

Tom

Quoted 32 lines

--
Darren

Quoted 28 lines

Signed-off-by Tom Zanussi <[email protected]>

---
 meta/cfg/kernel-cache/features/usb/host/base.cfg |    3 +++
 meta/cfg/kernel-cache/features/usb/host/base.scc |    4 ++++
 2 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc

meta/cfg/kernel-cache/features/usb/host/base.cfg new file +3 -0

new file mode 100644
index 0000000..dec6a47
@@ -0,0 +1,3 @@
+CONFIG_USB_SUPPORT=y
+CONFIG_USB=y
+

meta/cfg/kernel-cache/features/usb/host/base.scc new file +4 -0

new file mode 100644
index 0000000..3c93475
@@ -0,0 +1,4 @@
+define KFEATURE_DESCRIPTION "Enable core options for USB support"
+define KFEATURE_COMPATIBILITY board
+
+kconf hardware base.cfg

Darren Hart

2012-05-04 16:34 UTC #8 lore raw

Re: [PATCH 1/5][KERNEL] meta: add usb/host/base feature

Quoted 8 lines · Tom Zanussi

Quoted 7 lines · Darren Hart
Quoted 4 lines · On 05/02/2012 08:35 PM, [email protected] wrote:
From: Tom Zanussi <[email protected]>
Add a feature to enable 'base' support for USB, mainly to be included by derived features such as ehch, xhci, etc.

Quoted 9 lines

Quoted 3 lines
This seems overly granular in my opinion. I think I would just include the two required options in each of the *hci features.
Really? This seems to me a perfect use case for taking advantage of the 'reusibality' conf fragments offer. There would be four of these, that alone would seem to justify using a 'subroutine', but there could be more in the future, and if so, this fragment would be readily available.

I agree in principle, but feel the two lines of obvious requirements aren't worth it.

Quoted 1 line

i.e. I don't see any reason to 'inline' these...

I think "the line" is obviously a subjective one. And since you are the one that put in the time to prepare the meta-data, I don't feel strongly enough about it to argue the point. So I won't object to them going in as is.

--
Darren

Quoted 37 lines

Tom

Quoted 32 lines

--
Darren

Quoted 28 lines

Signed-off-by Tom Zanussi <[email protected]>

---
 meta/cfg/kernel-cache/features/usb/host/base.cfg |    3 +++
 meta/cfg/kernel-cache/features/usb/host/base.scc |    4 ++++
 2 files changed, 7 insertions(+), 0 deletions(-)
 create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg
 create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc

meta/cfg/kernel-cache/features/usb/host/base.cfg new file +3 -0

new file mode 100644
index 0000000..dec6a47
@@ -0,0 +1,3 @@
+CONFIG_USB_SUPPORT=y
+CONFIG_USB=y
+

meta/cfg/kernel-cache/features/usb/host/base.scc new file +4 -0

new file mode 100644
index 0000000..3c93475
@@ -0,0 +1,4 @@
+define KFEATURE_DESCRIPTION "Enable core options for USB support"
+define KFEATURE_COMPATIBILITY board
+
+kconf hardware base.cfg

Signature · 3 lines

Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Bruce Ashfield

2012-05-03 12:40 UTC #9 lore raw

In reply to [email protected]

Quoted 9 lines · On 12-05-02 11:35 PM, [email protected] wrote:

From: Tom Zanussi<[email protected]>
This adds a few new features, one for xhci-hcd and another for amt/mei, and refactors some existing config options into a new echi-hcd, which is then used in crownbay.
If this looks like the way to go, I'll add similar USB features for ohci and uhci and fix up all the meta-intel BSPs to use them.

I had a look, and while at first I thought it was perhaps an over splitting and categorization. It does make things very clear, and gets us a split that can be used to keep configs minimal and reusable.

I also wasn't sure about directory splitting, since we do end up with the names both in .scc/.cfg and the directory name. We could flatten the directory down to just 'usb' and keep the names of the files as the differentiator. And if we don't think we'll have to carry any patches, we could put it under cfg/usb/<Tom's stuff>.

I don't have a really strong opinion (but gave my preference) on this
split (several directories vs single), and I'd bet that you considered the same thing. Comments ?

But definitely, this is the way to go, just a minor question about the organization of the files.

Bruce

Quoted 43 lines

Please pull into linux-yocto-3.2.
Thanks,
Tom
The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
Yang Shi (1):
meta: Clean up BSPs kernel config
are available in the git repository at:
git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
Tom Zanussi (5):
meta: add usb/host/base feature
meta: add usb/xhci-hcd feature
meta: add usb/ehci-hcd feature
meta/crownbay: use ehci-hcd feature
meta: add mei feature
  meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg    |    4 ----
  meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    2 ++
  meta/cfg/kernel-cache/features/amt/mei/mei.cfg     |    3 +++
  meta/cfg/kernel-cache/features/amt/mei/mei.scc     |    4 ++++
  .../features/usb/ehci-hcd/ehci-hcd.cfg             |    1 +
  .../features/usb/ehci-hcd/ehci-hcd.scc             |    6 ++++++
  meta/cfg/kernel-cache/features/usb/host/base.cfg   |    3 +++
  meta/cfg/kernel-cache/features/usb/host/base.scc   |    4 ++++
  .../features/usb/xhci-hcd/xhci-hcd.cfg             |    1 +
  .../features/usb/xhci-hcd/xhci-hcd.scc             |    6 ++++++
  10 files changed, 30 insertions(+), 4 deletions(-)
create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc

Tom Zanussi

author

2012-05-03 13:50 UTC #10 lore raw

Quoted 21 lines · Bruce Ashfield

Quoted 9 lines · On 12-05-02 11:35 PM, [email protected] wrote:
From: Tom Zanussi<[email protected]>
This adds a few new features, one for xhci-hcd and another for amt/mei, and refactors some existing config options into a new echi-hcd, which is then used in crownbay.
If this looks like the way to go, I'll add similar USB features for ohci and uhci and fix up all the meta-intel BSPs to use them.
I had a look, and while at first I thought it was perhaps an over splitting and categorization. It does make things very clear, and gets us a split that can be used to keep configs minimal and reusable.
I also wasn't sure about directory splitting, since we do end up with the names both in .scc/.cfg and the directory name. We could flatten the directory down to just 'usb' and keep the names of the files as the differentiator. And if we don't think we'll have to carry any patches, we could put it under cfg/usb/<Tom's stuff>.

Quoted 4 lines

I don't have a really strong opinion (but gave my preference) on this split (several directories vs single), and I'd bet that you considered the same thing. Comments ?

The directory splitting is definitely a result of personal preference on my part i.e. directories are cheap and I hate having bunches of files in a single directory. This is actually the reason I tend to avoid /cfg. ;-)

In this case and most others, I find the directory splitting maps more cleanly 'at-a-glance' for me to the split in functionality, but as I said it's a personal preference and if most people prefer a more flattened tree, then I don't have a problem making that change...

Tom

Quoted 50 lines

But definitely, this is the way to go, just a minor question about the organization of the files.
Bruce
Quoted 43 lines
Please pull into linux-yocto-3.2.
Thanks,
Tom
The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
Yang Shi (1):
meta: Clean up BSPs kernel config
are available in the git repository at:
git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
Tom Zanussi (5):
meta: add usb/host/base feature
meta: add usb/xhci-hcd feature
meta: add usb/ehci-hcd feature
meta/crownbay: use ehci-hcd feature
meta: add mei feature
  meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg    |    4 ----
  meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    2 ++
  meta/cfg/kernel-cache/features/amt/mei/mei.cfg     |    3 +++
  meta/cfg/kernel-cache/features/amt/mei/mei.scc     |    4 ++++
  .../features/usb/ehci-hcd/ehci-hcd.cfg             |    1 +
  .../features/usb/ehci-hcd/ehci-hcd.scc             |    6 ++++++
  meta/cfg/kernel-cache/features/usb/host/base.cfg   |    3 +++
  meta/cfg/kernel-cache/features/usb/host/base.scc   |    4 ++++
  .../features/usb/xhci-hcd/xhci-hcd.cfg             |    1 +
  .../features/usb/xhci-hcd/xhci-hcd.scc             |    6 ++++++
  10 files changed, 30 insertions(+), 4 deletions(-)
create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc

Bruce Ashfield

2012-05-03 13:57 UTC #11 lore raw

Quoted 27 lines · Tom Zanussi

Quoted 21 lines · Bruce Ashfield
Quoted 9 lines · On 12-05-02 11:35 PM, [email protected] wrote:
From: Tom Zanussi<[email protected]>
This adds a few new features, one for xhci-hcd and another for amt/mei, and refactors some existing config options into a new echi-hcd, which is then used in crownbay.
If this looks like the way to go, I'll add similar USB features for ohci and uhci and fix up all the meta-intel BSPs to use them.
I had a look, and while at first I thought it was perhaps an over splitting and categorization. It does make things very clear, and gets us a split that can be used to keep configs minimal and reusable.
I also wasn't sure about directory splitting, since we do end up with the names both in .scc/.cfg and the directory name. We could flatten the directory down to just 'usb' and keep the names of the files as the differentiator. And if we don't think we'll have to carry any patches, we could put it under cfg/usb/<Tom's stuff>.
Quoted 4 lines
I don't have a really strong opinion (but gave my preference) on this split (several directories vs single), and I'd bet that you considered the same thing. Comments ?

Quoted 4 lines

The directory splitting is definitely a result of personal preference on my part i.e. directories are cheap and I hate having bunches of files in a single directory. This is actually the reason I tend to avoid /cfg. ;-)

Aha! A valid point :)

Quoted 5 lines

In this case and most others, I find the directory splitting maps more cleanly 'at-a-glance' for me to the split in functionality, but as I said it's a personal preference and if most people prefer a more flattened tree, then I don't have a problem making that change...

Nope. I'd rather not have you re-do it for just that minor change, when there's a valid reason on both sides.

I tossed the email .. and something has happened to my IMAP connection, so I can't find them now. Can you resend just the pull request ? or just the patches to me.

We can wait to see if Darren has a strong opinion one way or the other as well.

Bruce

Quoted 56 lines

Tom
Quoted 50 lines
But definitely, this is the way to go, just a minor question about the organization of the files.
Bruce
Quoted 43 lines
Please pull into linux-yocto-3.2.
Thanks,
Tom
The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
Yang Shi (1):
meta: Clean up BSPs kernel config
are available in the git repository at:
git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
Tom Zanussi (5):
meta: add usb/host/base feature
meta: add usb/xhci-hcd feature
meta: add usb/ehci-hcd feature
meta/crownbay: use ehci-hcd feature
meta: add mei feature
   meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg    |    4 ----
   meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    2 ++
   meta/cfg/kernel-cache/features/amt/mei/mei.cfg     |    3 +++
   meta/cfg/kernel-cache/features/amt/mei/mei.scc     |    4 ++++
   .../features/usb/ehci-hcd/ehci-hcd.cfg             |    1 +
   .../features/usb/ehci-hcd/ehci-hcd.scc             |    6 ++++++
   meta/cfg/kernel-cache/features/usb/host/base.cfg   |    3 +++
   meta/cfg/kernel-cache/features/usb/host/base.scc   |    4 ++++
   .../features/usb/xhci-hcd/xhci-hcd.cfg             |    1 +
   .../features/usb/xhci-hcd/xhci-hcd.scc             |    6 ++++++
   10 files changed, 30 insertions(+), 4 deletions(-)
create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc

Darren Hart

2012-05-04 16:25 UTC #12 lore raw

Quoted 44 lines · Bruce Ashfield

Quoted 27 lines · Tom Zanussi
Quoted 21 lines · Bruce Ashfield
Quoted 9 lines · On 12-05-02 11:35 PM, [email protected] wrote:
From: Tom Zanussi<[email protected]>
This adds a few new features, one for xhci-hcd and another for amt/mei, and refactors some existing config options into a new echi-hcd, which is then used in crownbay.
If this looks like the way to go, I'll add similar USB features for ohci and uhci and fix up all the meta-intel BSPs to use them.
I had a look, and while at first I thought it was perhaps an over splitting and categorization. It does make things very clear, and gets us a split that can be used to keep configs minimal and reusable.
I also wasn't sure about directory splitting, since we do end up with the names both in .scc/.cfg and the directory name. We could flatten the directory down to just 'usb' and keep the names of the files as the differentiator. And if we don't think we'll have to carry any patches, we could put it under cfg/usb/<Tom's stuff>.
Quoted 4 lines
I don't have a really strong opinion (but gave my preference) on this split (several directories vs single), and I'd bet that you considered the same thing. Comments ?
Quoted 4 lines
The directory splitting is definitely a result of personal preference on my part i.e. directories are cheap and I hate having bunches of files in a single directory. This is actually the reason I tend to avoid /cfg. ;-)
Aha! A valid point :)
Quoted 5 lines
In this case and most others, I find the directory splitting maps more cleanly 'at-a-glance' for me to the split in functionality, but as I said it's a personal preference and if most people prefer a more flattened tree, then I don't have a problem making that change...
Nope. I'd rather not have you re-do it for just that minor change, when there's a valid reason on both sides.

Quoted 6 lines

I tossed the email .. and something has happened to my IMAP connection, so I can't find them now. Can you resend just the pull request ? or just the patches to me.
We can wait to see if Darren has a strong opinion one way or the other as well.

Personally I prefer to keep directories minimal until such time as there is a need for more. As it is we're only talking about a handful of files which are still easily filtered. Still, this isn't a huge deal. I care more about the granularity of the setup. I feel having the usb/base bit adds unnecessarily to the file count.

Otherwise I'm content-ish.

--
Darren

Quoted 60 lines

Bruce
Quoted 56 lines
Tom
Quoted 50 lines
But definitely, this is the way to go, just a minor question about the organization of the files.
Bruce
Quoted 43 lines
Please pull into linux-yocto-3.2.
Thanks,
Tom
The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
Yang Shi (1):
meta: Clean up BSPs kernel config
are available in the git repository at:
git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
Tom Zanussi (5):
meta: add usb/host/base feature
meta: add usb/xhci-hcd feature
meta: add usb/ehci-hcd feature
meta/crownbay: use ehci-hcd feature
meta: add mei feature
   meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg    |    4 ----
   meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    2 ++
   meta/cfg/kernel-cache/features/amt/mei/mei.cfg     |    3 +++
   meta/cfg/kernel-cache/features/amt/mei/mei.scc     |    4 ++++
   .../features/usb/ehci-hcd/ehci-hcd.cfg             |    1 +
   .../features/usb/ehci-hcd/ehci-hcd.scc             |    6 ++++++
   meta/cfg/kernel-cache/features/usb/host/base.cfg   |    3 +++
   meta/cfg/kernel-cache/features/usb/host/base.scc   |    4 ++++
   .../features/usb/xhci-hcd/xhci-hcd.cfg             |    1 +
   .../features/usb/xhci-hcd/xhci-hcd.scc             |    6 ++++++
   10 files changed, 30 insertions(+), 4 deletions(-)
create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc

Signature · 3 lines

Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Tom Zanussi

author

2012-05-04 16:35 UTC #13 lore raw

Quoted 50 lines · Darren Hart

Quoted 48 lines · Bruce Ashfield
Quoted 27 lines · Tom Zanussi
Quoted 21 lines · Bruce Ashfield
Quoted 9 lines · On 12-05-02 11:35 PM, [email protected] wrote:
From: Tom Zanussi<[email protected]>
This adds a few new features, one for xhci-hcd and another for amt/mei, and refactors some existing config options into a new echi-hcd, which is then used in crownbay.
If this looks like the way to go, I'll add similar USB features for ohci and uhci and fix up all the meta-intel BSPs to use them.
I had a look, and while at first I thought it was perhaps an over splitting and categorization. It does make things very clear, and gets us a split that can be used to keep configs minimal and reusable.
I also wasn't sure about directory splitting, since we do end up with the names both in .scc/.cfg and the directory name. We could flatten the directory down to just 'usb' and keep the names of the files as the differentiator. And if we don't think we'll have to carry any patches, we could put it under cfg/usb/<Tom's stuff>.
Quoted 4 lines
I don't have a really strong opinion (but gave my preference) on this split (several directories vs single), and I'd bet that you considered the same thing. Comments ?
Quoted 4 lines
The directory splitting is definitely a result of personal preference on my part i.e. directories are cheap and I hate having bunches of files in a single directory. This is actually the reason I tend to avoid /cfg. ;-)
Aha! A valid point :)
Quoted 5 lines
In this case and most others, I find the directory splitting maps more cleanly 'at-a-glance' for me to the split in functionality, but as I said it's a personal preference and if most people prefer a more flattened tree, then I don't have a problem making that change...
Nope. I'd rather not have you re-do it for just that minor change, when there's a valid reason on both sides.
I tossed the email .. and something has happened to my IMAP connection, so I can't find them now. Can you resend just the pull request ? or just the patches to me.

Quoted 9 lines

Quoted 2 lines
We can wait to see if Darren has a strong opinion one way or the other as well.
Personally I prefer to keep directories minimal until such time as there is a need for more. As it is we're only talking about a handful of files which are still easily filtered. Still, this isn't a huge deal. I care more about the granularity of the setup. I feel having the usb/base bit adds unnecessarily to the file count.

OK, sounds like people like flat directories.

Actually, the other option would be to just put the options into the top-level feature like everything else. Was trying to clean that current situation up a bit, but maybe it's not really needed and I'll just continue with that, will have to think on it....

Tom

Quoted 66 lines

Otherwise I'm content-ish.
--
Darren
Quoted 60 lines
Bruce
Quoted 56 lines
Tom
Quoted 50 lines
But definitely, this is the way to go, just a minor question about the organization of the files.
Bruce
Quoted 43 lines
Please pull into linux-yocto-3.2.
Thanks,
Tom
The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
Yang Shi (1):
meta: Clean up BSPs kernel config
are available in the git repository at:
git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
Tom Zanussi (5):
meta: add usb/host/base feature
meta: add usb/xhci-hcd feature
meta: add usb/ehci-hcd feature
meta/crownbay: use ehci-hcd feature
meta: add mei feature
   meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg    |    4 ----
   meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    2 ++
   meta/cfg/kernel-cache/features/amt/mei/mei.cfg     |    3 +++
   meta/cfg/kernel-cache/features/amt/mei/mei.scc     |    4 ++++
   .../features/usb/ehci-hcd/ehci-hcd.cfg             |    1 +
   .../features/usb/ehci-hcd/ehci-hcd.scc             |    6 ++++++
   meta/cfg/kernel-cache/features/usb/host/base.cfg   |    3 +++
   meta/cfg/kernel-cache/features/usb/host/base.scc   |    4 ++++
   .../features/usb/xhci-hcd/xhci-hcd.cfg             |    1 +
   .../features/usb/xhci-hcd/xhci-hcd.scc             |    6 ++++++
   10 files changed, 30 insertions(+), 4 deletions(-)
create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc

Darren Hart

2012-05-04 16:39 UTC #14 lore raw

Quoted 61 lines · Tom Zanussi

Quoted 50 lines · Darren Hart
Quoted 48 lines · Bruce Ashfield
Quoted 27 lines · Tom Zanussi
Quoted 21 lines · Bruce Ashfield
Quoted 9 lines · On 12-05-02 11:35 PM, [email protected] wrote:
From: Tom Zanussi<[email protected]>
This adds a few new features, one for xhci-hcd and another for amt/mei, and refactors some existing config options into a new echi-hcd, which is then used in crownbay.
If this looks like the way to go, I'll add similar USB features for ohci and uhci and fix up all the meta-intel BSPs to use them.
I had a look, and while at first I thought it was perhaps an over splitting and categorization. It does make things very clear, and gets us a split that can be used to keep configs minimal and reusable.
I also wasn't sure about directory splitting, since we do end up with the names both in .scc/.cfg and the directory name. We could flatten the directory down to just 'usb' and keep the names of the files as the differentiator. And if we don't think we'll have to carry any patches, we could put it under cfg/usb/<Tom's stuff>.
Quoted 4 lines
I don't have a really strong opinion (but gave my preference) on this split (several directories vs single), and I'd bet that you considered the same thing. Comments ?
Quoted 4 lines
The directory splitting is definitely a result of personal preference on my part i.e. directories are cheap and I hate having bunches of files in a single directory. This is actually the reason I tend to avoid /cfg. ;-)
Aha! A valid point :)
Quoted 5 lines
In this case and most others, I find the directory splitting maps more cleanly 'at-a-glance' for me to the split in functionality, but as I said it's a personal preference and if most people prefer a more flattened tree, then I don't have a problem making that change...
Nope. I'd rather not have you re-do it for just that minor change, when there's a valid reason on both sides.
I tossed the email .. and something has happened to my IMAP connection, so I can't find them now. Can you resend just the pull request ? or just the patches to me.
Quoted 9 lines
Quoted 2 lines
We can wait to see if Darren has a strong opinion one way or the other as well.
Personally I prefer to keep directories minimal until such time as there is a need for more. As it is we're only talking about a handful of files which are still easily filtered. Still, this isn't a huge deal. I care more about the granularity of the setup. I feel having the usb/base bit adds unnecessarily to the file count.

Quoted 6 lines

OK, sounds like people like flat directories.
Actually, the other option would be to just put the options into the top-level feature like everything else. Was trying to clean that current situation up a bit, but maybe it's not really needed and I'll just continue with that, will have to think on it....

I think at least a usb/ dir is worth while. My rule of thumb is that a new dir needs at least 3 things (I'd group cfg and scc as 1 thing). Again, highly subjective.

--
Darren

Quoted 71 lines

Tom
Quoted 66 lines
Otherwise I'm content-ish.
--
Darren
Quoted 60 lines
Bruce
Quoted 56 lines
Tom
Quoted 50 lines
But definitely, this is the way to go, just a minor question about the organization of the files.
Bruce
Quoted 43 lines
Please pull into linux-yocto-3.2.
Thanks,
Tom
The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
Yang Shi (1):
meta: Clean up BSPs kernel config
are available in the git repository at:
git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
Tom Zanussi (5):
meta: add usb/host/base feature
meta: add usb/xhci-hcd feature
meta: add usb/ehci-hcd feature
meta/crownbay: use ehci-hcd feature
meta: add mei feature
   meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg    |    4 ----
   meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    2 ++
   meta/cfg/kernel-cache/features/amt/mei/mei.cfg     |    3 +++
   meta/cfg/kernel-cache/features/amt/mei/mei.scc     |    4 ++++
   .../features/usb/ehci-hcd/ehci-hcd.cfg             |    1 +
   .../features/usb/ehci-hcd/ehci-hcd.scc             |    6 ++++++
   meta/cfg/kernel-cache/features/usb/host/base.cfg   |    3 +++
   meta/cfg/kernel-cache/features/usb/host/base.scc   |    4 ++++
   .../features/usb/xhci-hcd/xhci-hcd.cfg             |    1 +
   .../features/usb/xhci-hcd/xhci-hcd.scc             |    6 ++++++
   10 files changed, 30 insertions(+), 4 deletions(-)
create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc

Signature · 3 lines

Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Tom Zanussi

author

2012-05-04 16:43 UTC #15 lore raw

Quoted 71 lines · Darren Hart

Quoted 61 lines · Tom Zanussi
Quoted 50 lines · Darren Hart
Quoted 48 lines · Bruce Ashfield
Quoted 27 lines · Tom Zanussi
Quoted 21 lines · Bruce Ashfield
Quoted 9 lines · On 12-05-02 11:35 PM, [email protected] wrote:
From: Tom Zanussi<[email protected]>
This adds a few new features, one for xhci-hcd and another for amt/mei, and refactors some existing config options into a new echi-hcd, which is then used in crownbay.
If this looks like the way to go, I'll add similar USB features for ohci and uhci and fix up all the meta-intel BSPs to use them.
I had a look, and while at first I thought it was perhaps an over splitting and categorization. It does make things very clear, and gets us a split that can be used to keep configs minimal and reusable.
I also wasn't sure about directory splitting, since we do end up with the names both in .scc/.cfg and the directory name. We could flatten the directory down to just 'usb' and keep the names of the files as the differentiator. And if we don't think we'll have to carry any patches, we could put it under cfg/usb/<Tom's stuff>.
Quoted 4 lines
I don't have a really strong opinion (but gave my preference) on this split (several directories vs single), and I'd bet that you considered the same thing. Comments ?
Quoted 4 lines
The directory splitting is definitely a result of personal preference on my part i.e. directories are cheap and I hate having bunches of files in a single directory. This is actually the reason I tend to avoid /cfg. ;-)
Aha! A valid point :)
Quoted 5 lines
In this case and most others, I find the directory splitting maps more cleanly 'at-a-glance' for me to the split in functionality, but as I said it's a personal preference and if most people prefer a more flattened tree, then I don't have a problem making that change...
Nope. I'd rather not have you re-do it for just that minor change, when there's a valid reason on both sides.
I tossed the email .. and something has happened to my IMAP connection, so I can't find them now. Can you resend just the pull request ? or just the patches to me.
Quoted 9 lines
Quoted 2 lines
We can wait to see if Darren has a strong opinion one way or the other as well.
Personally I prefer to keep directories minimal until such time as there is a need for more. As it is we're only talking about a handful of files which are still easily filtered. Still, this isn't a huge deal. I care more about the granularity of the setup. I feel having the usb/base bit adds unnecessarily to the file count.
Quoted 6 lines
OK, sounds like people like flat directories.
Actually, the other option would be to just put the options into the top-level feature like everything else. Was trying to clean that current situation up a bit, but maybe it's not really needed and I'll just continue with that, will have to think on it....

Quoted 4 lines

I think at least a usb/ dir is worth while. My rule of thumb is that a new dir needs at least 3 things (I'd group cfg and scc as 1 thing). Again, highly subjective.

OK, this is what I'll go with, then, four features in /usb (ehci/xhci/uhch/ohci, etc), with no 'base' feature (inline those options in each individual feature).

So Bruce, don't bother pulling in the current patchset, I'll resubmit a new patchset later.

Tom

Quoted 75 lines

--
Darren
Quoted 71 lines
Tom
Quoted 66 lines
Otherwise I'm content-ish.
--
Darren
Quoted 60 lines
Bruce
Quoted 56 lines
Tom
Quoted 50 lines
But definitely, this is the way to go, just a minor question about the organization of the files.
Bruce
Quoted 43 lines
Please pull into linux-yocto-3.2.
Thanks,
Tom
The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
Yang Shi (1):
meta: Clean up BSPs kernel config
are available in the git repository at:
git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
Tom Zanussi (5):
meta: add usb/host/base feature
meta: add usb/xhci-hcd feature
meta: add usb/ehci-hcd feature
meta/crownbay: use ehci-hcd feature
meta: add mei feature
   meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg    |    4 ----
   meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc    |    2 ++
   meta/cfg/kernel-cache/features/amt/mei/mei.cfg     |    3 +++
   meta/cfg/kernel-cache/features/amt/mei/mei.scc     |    4 ++++
   .../features/usb/ehci-hcd/ehci-hcd.cfg             |    1 +
   .../features/usb/ehci-hcd/ehci-hcd.scc             |    6 ++++++
   meta/cfg/kernel-cache/features/usb/host/base.cfg   |    3 +++
   meta/cfg/kernel-cache/features/usb/host/base.scc   |    4 ++++
   .../features/usb/xhci-hcd/xhci-hcd.cfg             |    1 +
   .../features/usb/xhci-hcd/xhci-hcd.scc             |    6 ++++++
   10 files changed, 30 insertions(+), 4 deletions(-)
create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc

Bruce Ashfield

2012-05-04 20:54 UTC #16 lore raw

Quoted 77 lines · Tom Zanussi

Quoted 71 lines · Darren Hart
Quoted 61 lines · Tom Zanussi
Quoted 50 lines · Darren Hart
Quoted 48 lines · Bruce Ashfield
Quoted 27 lines · Tom Zanussi
Quoted 21 lines · Bruce Ashfield
Quoted 9 lines · On 12-05-02 11:35 PM, [email protected] wrote:
From: Tom Zanussi<[email protected]>
This adds a few new features, one for xhci-hcd and another for amt/mei, and refactors some existing config options into a new echi-hcd, which is then used in crownbay.
If this looks like the way to go, I'll add similar USB features for ohci and uhci and fix up all the meta-intel BSPs to use them.
I had a look, and while at first I thought it was perhaps an over splitting and categorization. It does make things very clear, and gets us a split that can be used to keep configs minimal and reusable.
I also wasn't sure about directory splitting, since we do end up with the names both in .scc/.cfg and the directory name. We could flatten the directory down to just 'usb' and keep the names of the files as the differentiator. And if we don't think we'll have to carry any patches, we could put it under cfg/usb/<Tom's stuff>.
Quoted 4 lines
I don't have a really strong opinion (but gave my preference) on this split (several directories vs single), and I'd bet that you considered the same thing. Comments ?
Quoted 4 lines
The directory splitting is definitely a result of personal preference on my part i.e. directories are cheap and I hate having bunches of files in a single directory. This is actually the reason I tend to avoid /cfg. ;-)
Aha! A valid point :)
Quoted 5 lines
In this case and most others, I find the directory splitting maps more cleanly 'at-a-glance' for me to the split in functionality, but as I said it's a personal preference and if most people prefer a more flattened tree, then I don't have a problem making that change...
Nope. I'd rather not have you re-do it for just that minor change, when there's a valid reason on both sides.
I tossed the email .. and something has happened to my IMAP connection, so I can't find them now. Can you resend just the pull request ? or just the patches to me.
Quoted 9 lines
Quoted 2 lines
We can wait to see if Darren has a strong opinion one way or the other as well.
Personally I prefer to keep directories minimal until such time as there is a need for more. As it is we're only talking about a handful of files which are still easily filtered. Still, this isn't a huge deal. I care more about the granularity of the setup. I feel having the usb/base bit adds unnecessarily to the file count.
Quoted 6 lines
OK, sounds like people like flat directories.
Actually, the other option would be to just put the options into the top-level feature like everything else. Was trying to clean that current situation up a bit, but maybe it's not really needed and I'll just continue with that, will have to think on it....
Quoted 4 lines
I think at least a usb/ dir is worth while. My rule of thumb is that a new dir needs at least 3 things (I'd group cfg and scc as 1 thing). Again, highly subjective.

Quoted 6 lines

OK, this is what I'll go with, then, four features in /usb (ehci/xhci/uhch/ohci, etc), with no 'base' feature (inline those options in each individual feature).
So Bruce, don't bother pulling in the current patchset, I'll resubmit a new patchset later.

ooops. I merged it on the plane, but haven't pushed it. I'll reset it out of my branches here.

Bruce

Quoted 80 lines

Tom
Quoted 75 lines
--
Darren
Quoted 71 lines
Tom
Quoted 66 lines
Otherwise I'm content-ish.
--
Darren
Quoted 60 lines
Bruce
Quoted 56 lines
Tom
Quoted 50 lines
But definitely, this is the way to go, just a minor question about the organization of the files.
Bruce
Quoted 43 lines
Please pull into linux-yocto-3.2.
Thanks,
Tom
The following changes since commit b14a08f5c7b469a5077c10942f4e1aec171faa9d:
Yang Shi (1):
meta: Clean up BSPs kernel config
are available in the git repository at:
git://git.yoctoproject.org/linux-yocto-2.6.37-contrib.git tzanussi/xhcd-mei-features
http://git.yoctoproject.org/cgit.cgi//log/?h=tzanussi/xhcd-mei-features
Tom Zanussi (5):
meta: add usb/host/base feature
meta: add usb/xhci-hcd feature
meta: add usb/ehci-hcd feature
meta/crownbay: use ehci-hcd feature
meta: add mei feature
meta/cfg/kernel-cache/bsp/crownbay/crownbay.cfg | 4 ----
meta/cfg/kernel-cache/bsp/crownbay/crownbay.scc | 2 ++
meta/cfg/kernel-cache/features/amt/mei/mei.cfg | 3 +++
meta/cfg/kernel-cache/features/amt/mei/mei.scc | 4 ++++
.../features/usb/ehci-hcd/ehci-hcd.cfg | 1 +
.../features/usb/ehci-hcd/ehci-hcd.scc | 6 ++++++
meta/cfg/kernel-cache/features/usb/host/base.cfg | 3 +++
meta/cfg/kernel-cache/features/usb/host/base.scc | 4 ++++
.../features/usb/xhci-hcd/xhci-hcd.cfg | 1 +
.../features/usb/xhci-hcd/xhci-hcd.scc | 6 ++++++
10 files changed, 30 insertions(+), 4 deletions(-)
create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.cfg create mode 100644 meta/cfg/kernel-cache/features/amt/mei/mei.scc create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/ehci-hcd/ehci-hcd.scc create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/host/base.scc create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.cfg create mode 100644 meta/cfg/kernel-cache/features/usb/xhci-hcd/xhci-hcd.scc