Skip to contentSkip to conversation

Hob: bug-fixes

PATCH Applied Liming An 2 participants 3 messages May 24, 2012 – May 25, 2012

lore
Share & tools
lore

Liming An

author
#0 lore raw

cover Hob: bug-fixes

The following changes since commit 6558abda67956e4fab1304b0cdf03c65f18fabd5:

qemu: disable vnc-jpeg compression (2012-05-24 08:53:57 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-continue
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-continue

Liming An (1):
Hob:fixed the issue of primary button is not an 'orange hob button'

 bitbake/lib/bb/ui/crumbs/imagedetailspage.py |   27 +++++++++++++++----------
 meta/conf/machine/include/qemu.inc           |    2 +-
 2 files changed, 17 insertions(+), 12 deletions(-)
Signature · 1 line
1.7.5.4
author
#1 lore raw

PATCH 1/1 Hob:fixed the issue of primary button is not an 'orange hob button'

In image detail page, the primary button should be an 'orange hob button', there has a primary button is not, so change it.

[YOCTO #2326]

---
 bitbake/lib/bb/ui/crumbs/imagedetailspage.py |   27 +++++++++++++++----------
 meta/conf/machine/include/qemu.inc           |    2 +-
 2 files changed, 17 insertions(+), 12 deletions(-)
bitbake/lib/bb/ui/crumbs/imagedetailspage.py +16 -11
index 5d85491..9d57dc0 100755
@@ -411,15 +411,6 @@ class ImageDetailsPage (HobPage):
             self.details_bottom_buttons.pack_end(run_button, expand=False, fill=False)
             created = True
 
-        if not packed:
-            box = gtk.HBox(False, 6)
-            box.show()
-            subbox = gtk.HBox(False, 0)
-            subbox.set_size_request(205, 49)
-            subbox.show()
-            box.add(subbox)
-            self.details_bottom_buttons.pack_end(box, False, False)
-
         name = "Save as template"
         if name in buttonlist:
             if created == True:
@@ -427,14 +418,28 @@ class ImageDetailsPage (HobPage):
                 label = gtk.Label(" or ")
                 self.details_bottom_buttons.pack_end(label, expand=False, fill=False)
 
-            # create button "Save as template"
-            save_button = HobAltButton("Save as template")
+                # create button "Save as template"
+                save_button = HobAltButton("Save as template")
+            else:
+                save_button = HobButton("Save as template")
+                save_button.set_size_request(205, 49)
+                save_button.set_flags(gtk.CAN_DEFAULT)
+                packed = True
             save_button.set_tooltip_text("Save the image configuration for reuse")
             button_id = save_button.connect("clicked", self.save_button_clicked_cb)
             self.button_ids[button_id] = save_button
             self.details_bottom_buttons.pack_end(save_button, expand=False, fill=False)
             create = True
 
+        if not packed:
+            box = gtk.HBox(False, 6)
+            box.show()
+            subbox = gtk.HBox(False, 0)
+            subbox.set_size_request(205, 49)
+            subbox.show()
+            box.add(subbox)
+            self.details_bottom_buttons.pack_end(box, False, False)
+
         name = "Build new image"
         if name in buttonlist:
             # create button "Build new image"
meta/conf/machine/include/qemu.inc +1 -1
index 5d59a7f..dc7f839 100644
@@ -10,7 +10,7 @@ XSERVER ?= "xserver-xorg \
 
 MACHINE_FEATURES = "apm alsa pcmcia bluetooth irda usbgadget screen"
 
-IMAGE_FSTYPES += "tar.bz2 ext3"
+IMAGE_FSTYPES += "tar.bz2"
 
 ROOT_FLASH_SIZE = "280"
 
Signature · 1 line
1.7.5.4
#2 lore raw
In reply to Liming An
Quoted 8 lines · Liming An

The following changes since commit 6558abda67956e4fab1304b0cdf03c65f18fabd5:

qemu: disable vnc-jpeg compression (2012-05-24 08:53:57 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib limx/hob-bug-fixes-continue
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=limx/hob-bug-fixes-continue

Quoted 6 lines

Liming An (1):
Hob:fixed the issue of primary button is not an 'orange hob button'

 bitbake/lib/bb/ui/crumbs/imagedetailspage.py |   27 +++++++++++++++----------
 meta/conf/machine/include/qemu.inc           |    2 +-
 2 files changed, 17 insertions(+), 12 deletions(-)

Merged to master, thanks.

Richard