A couple of buildhistory-diff fixes

PATCH Applied Paul Eggleton 2 participants 4 messages May 28, 2012 – May 30, 2012

lore

Share & tools

lore

Paul Eggleton

author

2012-05-28 13:07 UTC #0 lore raw

cover A couple of buildhistory-diff fixes

The following changes since commit 363424cdc78cafa278008f973c2b4288297ebf8c:

  image.bbclass: Ensure ${S} is cleaned at the start of rootfs generation (2012-05-25 11:28:00 +0100)

are available in the git repository at:

git://git.openembedded.org/openembedded-core-contrib paule/buildhistory-fixes6
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/buildhistory-fixes6

Paul Eggleton (2):
buildhistory_analysis: fix error when version specifier missing scripts/buildhistory-diff: add GitPython version check

 meta/lib/oe/buildhistory_analysis.py |    2 +-
 scripts/buildhistory-diff            |    8 ++++++--
 2 files changed, 7 insertions(+), 3 deletions(-)

Signature · 1 line

1.7.9.5

Paul Eggleton

author

2012-05-28 13:07 UTC #1 lore raw

PATCH 1/2 buildhistory_analysis: fix error when version specifier missing

Passing None to split_versions() will raise an exception, so check that the version is specified before passing it in.

Signed-off-by Paul Eggleton <[email protected]>

---
 meta/lib/oe/buildhistory_analysis.py |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

meta/lib/oe/buildhistory_analysis.py +1 -1

index 313416c..29dc4a9 100644
@@ -272,7 +272,7 @@ def compare_pkg_lists(astr, bstr):
         if k in depverb:
             dva = depvera[k]
             dvb = depverb[k]
-            if dva != dvb:
+            if dva and dvb and dva != dvb:
                 if bb.utils.vercmp(split_version(dva), split_version(dvb)) < 0:
                     remove.append(k)

Signature · 1 line

1.7.9.5

Paul Eggleton

author

2012-05-28 13:07 UTC #2 lore raw

PATCH 2/2 scripts/buildhistory-diff: add GitPython version check

In reply to Paul Eggleton

Display an error if the user does not have at least version 0.3.1 of GitPython installed.

Signed-off-by Paul Eggleton <[email protected]>

---
 scripts/buildhistory-diff |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

scripts/buildhistory-diff +6 -2

index 9936a4b..3f27eab 100755
@@ -7,16 +7,20 @@
 
 import sys
 import os
+from distutils.version import LooseVersion
 
 # Ensure PythonGit is installed (buildhistory_analysis needs it)
 try:
     import git
 except ImportError:
-    print("Please install PythonGit 0.3.1 or later in order to use this script")
+    print("Please install GitPython (python-git) 0.3.1 or later in order to use this script")
     sys.exit(1)
 
-
 def main():
+    if LooseVersion(git.__version__) < '0.3.1':
+        print("Version of GitPython is too old, please install GitPython (python-git) 0.3.1 or later in order to use this script")
+        sys.exit(1)
+
     if (len(sys.argv) < 3):
         print("Report significant differences in the buildhistory repository")
         print("Syntax: %s <buildhistory-path> <since-revision> [to-revision]" % os.path.basename(sys.argv[0]))

Signature · 1 line

1.7.9.5

Richard Purdie

Applied

2012-05-30 12:13 UTC #3 lore raw

In reply to Paul Eggleton

Quoted 4 lines · Paul Eggleton

The following changes since commit 363424cdc78cafa278008f973c2b4288297ebf8c:
  image.bbclass: Ensure ${S} is cleaned at the start of rootfs generation (2012-05-25 11:28:00 +0100)

Quoted 8 lines

are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib paule/buildhistory-fixes6
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/buildhistory-fixes6
Paul Eggleton (2):
buildhistory_analysis: fix error when version specifier missing scripts/buildhistory-diff: add GitPython version check

Merged to master, thanks.

Richard