sanity.bbclass improvements for Hob
cover sanity.bbclass improvements for Hob
The following changes since commit 363424cdc78cafa278008f973c2b4288297ebf8c:
image.bbclass: Ensure ${S} is cleaned at the start of rootfs generation (2012-05-25 11:28:00 +0100)are available in the git repository at:
git://git.openembedded.org/openembedded-core-contrib paule/hob-sanity-oecore
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/hob-sanity-oecore
Paul Eggleton (2):
classes/sanity: send sanity check failure as a separate event for Hob classes/sanity: fix a couple of grammatical errors in messages
meta/classes/sanity.bbclass | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-)
Signature · 1 line
1.7.9.5
PATCH 1/2 classes/sanity: send sanity check failure as a separate event for Hob
In order to show a friendlier error message within Hob that does not bury the actual sanity error in our typical preamble about disabling sanity checks, use a separate event to indicate that sanity checks failed.
This change is intended to work together with the related change to BitBake, however it has a check to ensure that it does not fail with older versions that do not include that change.
Fixes [YOCTO #2336].
--- meta/classes/sanity.bbclass | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-)
meta/classes/sanity.bbclass +13 -3
@@ -4,7 +4,16 @@ SANITY_REQUIRED_UTILITIES ?= "patch diffstat texi2html makeinfo svn bzip2 tar gzip gawk chrpath wget cpio" -def raise_sanity_error(msg): +def raise_sanity_error(msg, d): + if d.getVar("SANITY_USE_EVENTS", True) == "1": + # FIXME: handle when BitBake version is too old to support bb.event.SanityCheckFailed + # We can just fire the event directly once the minimum version is bumped beyond 1.15.1 + try: + bb.event.fire(bb.event.SanityCheckFailed(msg), d) + return + except AttributeError: + pass + bb.fatal(""" OE-core's config sanity checker detected a potential misconfiguration. Either fix the cause of this error or at your own risk disable the checker (see sanity.conf). Following is the list of potential problems / advisories:
@@ -298,7 +307,7 @@ def check_sanity(sanity_data): return if 0 == os.getuid(): - raise_sanity_error("Do not use Bitbake as root.") + raise_sanity_error("Do not use Bitbake as root.", sanity_data) messages = ""
@@ -532,7 +541,7 @@ def check_sanity(sanity_data): messages = messages + "Error, you have a space in your COREBASE directory path. Please move the installation to a directory which doesn't include a space." if messages != "": - raise_sanity_error(messages) + raise_sanity_error(messages, sanity_data) # Create a copy of the datastore and finalise it to ensure appends and # overrides are set - the datastore has yet to be finalised at ConfigParsed
@@ -548,6 +557,7 @@ python check_sanity_eventhandler() { check_sanity(sanity_data) elif bb.event.getName(e) == "SanityCheck": sanity_data = copy_data(e) + sanity_data.setVar("SANITY_USE_EVENTS", "1") check_sanity(sanity_data) bb.event.fire(bb.event.SanityCheckPassed(), e.data)
Signature · 1 line
1.7.9.5
PATCH 2/2 classes/sanity: fix a couple of grammatical errors in messages
In reply to Paul Eggleton--- meta/classes/sanity.bbclass | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
meta/classes/sanity.bbclass +2 -2
@@ -409,7 +409,7 @@ def check_sanity(sanity_data): if missing != "": missing = missing.rstrip(',') - messages = messages + "Please install following missing utilities: %s\n" % missing + messages = messages + "Please install the following missing utilities: %s\n" % missing pseudo_msg = check_pseudo_wrapper() if pseudo_msg != "":
@@ -431,7 +431,7 @@ def check_sanity(sanity_data): oes_bb_conf = sanity_data.getVar( 'OES_BITBAKE_CONF', True) if not oes_bb_conf: - messages = messages + 'You do not include OpenEmbeddeds version of conf/bitbake.conf. This means your environment is misconfigured, in particular check BBPATH.\n' + messages = messages + 'You do not include the OpenEmbedded version of conf/bitbake.conf. This means your environment is misconfigured, in particular check BBPATH.\n' nolibs = sanity_data.getVar('NO32LIBS', True) if not nolibs:
Signature · 1 line
1.7.9.5
Richard Purdie
AppliedQuoted 4 lines · Paul Eggleton
The following changes since commit
363424cdc78cafa278008f973c2b4288297ebf8c:image.bbclass: Ensure ${S} is cleaned at the start of rootfs generation (2012-05-25 11:28:00 +0100)
Quoted 8 lines
are available in the git repository at:
git://git.openembedded.org/openembedded-core-contribpaule/hob-sanity-oecore
http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/hob-sanity-oecorePaul Eggleton (2):
classes/sanity: send sanity check failure as a separate event for Hob classes/sanity: fix a couple of grammatical errors in messages
Merged to master, thanks.
Richard