Skip to contentSkip to conversation

a fix for poky-tiny

PATCH In review [email protected] 4 participants 6 messages Jun 8, 2012 – Jun 11, 2012

lore
Share & tools
lore
#0 lore raw

cover a fix for poky-tiny

From: Nitin A Kamble <[email protected]>

resending with corrected contrib branch.

The following changes since commit 0612cf3fcb3365e7721a2d5c331f8cd2647ae60b:

hob2: create a standalone deploy image tool (2012-06-08 12:13:43 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib master+work
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=nitin/master+work

Nitin A Kamble (1):
eglibc: remove runtime dependency of perl from eglibc-mtrace

 meta/recipes-core/eglibc/eglibc-package.inc |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Signature · 1 line
1.7.3.4
#1 lore raw

PATCH 1/1 eglibc: remove runtime dependency of perl from eglibc-mtrace

From: Nitin A Kamble <[email protected]>

perl needs eglibc to build. The presence of runtime dependency of perl for eglibc-mtrace caused bitbake to build perl before eglibc, which causes build failure of perl with poky-tiny distro

This fixes bug: [YOCTO #2523]

---
 meta/recipes-core/eglibc/eglibc-package.inc |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
meta/recipes-core/eglibc/eglibc-package.inc +0 -1
index ce37155..423729a 100644
@@ -55,7 +55,6 @@ FILES_${PN}-dbg += "${libexecdir}/*/.debug ${libdir}/audit/.debug"
 FILES_catchsegv${PKGSUFFIX} = "${bindir}/catchsegv"
 RDEPENDS_catchsegv${PKGSUFFIX} = "libsegfault"
 RDEPENDS_${PN}-utils += "bash"
-RDEPENDS_${PN}-mtrace += "perl"
 FILES_${PN}-pcprofile = "${base_libdir}/libpcprofile.so"
 FILES_eglibc-thread-db${PKGSUFFIX} = "${base_libdir}/libthread_db.so.* ${base_libdir}/libthread_db-*.so"
 RPROVIDES_${PN}-dev += "libc-dev"
Signature · 1 line
1.7.3.4
#2 lore raw

Re: [PATCH 1/1] eglibc: remove runtime dependency of perl from eglibc-mtrace

Quoted 7 lines · On 06/08/2012 03:23 PM, [email protected] wrote:

From: Nitin A Kamble <[email protected]>

perl needs eglibc to build.
The presence of runtime dependency of
perl for eglibc-mtrace caused bitbake to build perl before eglibc, which causes build failure of perl with poky-tiny distro

So is this a circular dependency chain?

perl DEPENDS on eglibc
eglibc (because of eglibc-mtrace) RDEPENDS on perl?

If so, doesn't this solution leave eglibc-mtrace with an incomplete set of dependencies in it's final package meta-data?

Would the correct solution be to break eglibc-mtrace out into a separate recipe.

eglibc-mtrace.bb could then DEPENDS=eglibc and RDEPENDS=perl and poky-tiny would need to be able to exclude eglibc-mtrace.

Quoted 19 lines

This fixes bug: [YOCTO #2523]

---
 meta/recipes-core/eglibc/eglibc-package.inc |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
meta/recipes-core/eglibc/eglibc-package.inc +0 -1
index ce37155..423729a 100644
@@ -55,7 +55,6 @@ FILES_${PN}-dbg += "${libexecdir}/*/.debug ${libdir}/audit/.debug"
 FILES_catchsegv${PKGSUFFIX} = "${bindir}/catchsegv"
 RDEPENDS_catchsegv${PKGSUFFIX} = "libsegfault"
 RDEPENDS_${PN}-utils += "bash"
-RDEPENDS_${PN}-mtrace += "perl"
 FILES_${PN}-pcprofile = "${base_libdir}/libpcprofile.so"
 FILES_eglibc-thread-db${PKGSUFFIX} = "${base_libdir}/libthread_db.so.* ${base_libdir}/libthread_db-*.so"
 RPROVIDES_${PN}-dev += "libc-dev"
Signature · 3 lines
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
#3 lore raw

Re: [yocto] [PATCH 1/1] eglibc: remove runtime dependency of perl from eglibc-mtrace

Quoted 13 lines · Darren Hart
Quoted 7 lines · On 06/08/2012 03:23 PM, [email protected] wrote:

From: Nitin A Kamble<[email protected]>

perl needs eglibc to build.
The presence of runtime dependency of
perl for eglibc-mtrace caused bitbake to build perl before eglibc, which causes build failure of perl with poky-tiny distro

So is this a circular dependency chain?

Quoted 9 lines

perl DEPENDS on eglibc
eglibc (because of eglibc-mtrace) RDEPENDS on perl?

If so, doesn't this solution leave eglibc-mtrace with an incomplete set of dependencies in it's final package meta-data?

Would the correct solution be to break eglibc-mtrace out into a separate recipe.

I am not sure if this would be more correct or have the PACKAGES contain something like ${EGLIBC_PACKAGE_MTRACE}, which could the be over-ridden by the yocto-tiny distro.

EGLIBC_PACKAGE_MTRACE ?= "${PN}-mtrace"

and then change ${PN}-mtrace in the PACKAGES list to ${EGLIBC_PACKAGE_MTRACE}.

This exposes another "global", so I am not sure which is better.

Sau!

Quoted 24 lines

eglibc-mtrace.bb could then DEPENDS=eglibc and RDEPENDS=perl and poky-tiny would need to be able to exclude eglibc-mtrace.

Quoted 19 lines
   This fixes bug: [YOCTO #2523]
---
  meta/recipes-core/eglibc/eglibc-package.inc |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)
meta/recipes-core/eglibc/eglibc-package.inc +0 -1
index ce37155..423729a 100644
@@ -55,7 +55,6 @@ FILES_${PN}-dbg += "${libexecdir}/*/.debug ${libdir}/audit/.debug"
  FILES_catchsegv${PKGSUFFIX} = "${bindir}/catchsegv"
  RDEPENDS_catchsegv${PKGSUFFIX} = "libsegfault"
  RDEPENDS_${PN}-utils += "bash"
-RDEPENDS_${PN}-mtrace += "perl"
  FILES_${PN}-pcprofile = "${base_libdir}/libpcprofile.so"
  FILES_eglibc-thread-db${PKGSUFFIX} = "${base_libdir}/libthread_db.so.* ${base_libdir}/libthread_db-*.so"
  RPROVIDES_${PN}-dev += "libc-dev"
#4 lore raw

Re: [yocto] [PATCH 1/1] eglibc: remove runtime dependency of perl from eglibc-mtrace

Quoted 27 lines · Saul Wold
Quoted 13 lines · Darren Hart
Quoted 7 lines · On 06/08/2012 03:23 PM, [email protected] wrote:

From: Nitin A Kamble<[email protected]>

perl needs eglibc to build.
The presence of runtime dependency of
perl for eglibc-mtrace caused bitbake to build perl before eglibc, which causes build failure of perl with poky-tiny distro

So is this a circular dependency chain?

Quoted 9 lines

perl DEPENDS on eglibc
eglibc (because of eglibc-mtrace) RDEPENDS on perl?

If so, doesn't this solution leave eglibc-mtrace with an incomplete set of dependencies in it's final package meta-data?

Would the correct solution be to break eglibc-mtrace out into a separate recipe.

I am not sure if this would be more correct or have the PACKAGES contain something like ${EGLIBC_PACKAGE_MTRACE}, which could the be over-ridden by the yocto-tiny distro.

Quoted 6 lines

EGLIBC_PACKAGE_MTRACE ?= "${PN}-mtrace"

and then change ${PN}-mtrace in the PACKAGES list to ${EGLIBC_PACKAGE_MTRACE}.

This exposes another "global", so I am not sure which is better.

This doesn't seem inconsistent with other solutions to similar sorts of problems. This is certainly less work and a smaller change.

--
Darren

Quoted 28 lines

Sau!

Quoted 24 lines

eglibc-mtrace.bb could then DEPENDS=eglibc and RDEPENDS=perl and poky-tiny would need to be able to exclude eglibc-mtrace.

Quoted 19 lines
   This fixes bug: [YOCTO #2523]
---
  meta/recipes-core/eglibc/eglibc-package.inc |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)
meta/recipes-core/eglibc/eglibc-package.inc +0 -1
index ce37155..423729a 100644
@@ -55,7 +55,6 @@ FILES_${PN}-dbg += "${libexecdir}/*/.debug ${libdir}/audit/.debug"
  FILES_catchsegv${PKGSUFFIX} = "${bindir}/catchsegv"
  RDEPENDS_catchsegv${PKGSUFFIX} = "libsegfault"
  RDEPENDS_${PN}-utils += "bash"
-RDEPENDS_${PN}-mtrace += "perl"
  FILES_${PN}-pcprofile = "${base_libdir}/libpcprofile.so"
  FILES_eglibc-thread-db${PKGSUFFIX} = "${base_libdir}/libthread_db.so.* ${base_libdir}/libthread_db-*.so"
  RPROVIDES_${PN}-dev += "libc-dev"
Signature · 3 lines
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
#5 lore raw

Re: [yocto] [PATCH 1/1] eglibc: remove runtime dependency of perl from eglibc-mtrace

In reply to Saul Wold
Quoted 7 lines · Saul Wold
Quoted 3 lines

Would the correct solution be to break eglibc-mtrace out into a separate recipe.

I am not sure if this would be more correct or have the PACKAGES contain something like ${EGLIBC_PACKAGE_MTRACE}, which could the be over-ridden by the yocto-tiny distro.

Quoted 6 lines

EGLIBC_PACKAGE_MTRACE ?= "${PN}-mtrace"

and then change ${PN}-mtrace in the PACKAGES list to ${EGLIBC_PACKAGE_MTRACE}.

This exposes another "global", so I am not sure which is better.

there are other tools e.g. memusage etc. which could be built in a second pass and IMO
we should separate the eglibc-bin into a separate recipe since everything depends on system libc
its desirable that it should have few dependencies to build it so builds can be more parallel and
eglibc wont be a bottleneck.

-Khem