Tx time stamp advertising for four drivers
Subsystems (5)
cover Tx time stamp advertising for four drivers
This series updates the ethtool code for four drivers that recently add the skb_tx_timestamp hook. Since these drivers now support software transmit time stamps, let us also advertise this via ethtool.
Thanks,
Richard
Richard Cochran (4):
bnx2x: advertise transmit time stamping
e1000: advertise transmit time stamping
e1000e: advertise transmit time stamping
forcedeth: advertise transmit time stamping
.../net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 1 + drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 1 + drivers/net/ethernet/intel/e1000e/ethtool.c | 1 + drivers/net/ethernet/nvidia/forcedeth.c | 1 + 4 files changed, 4 insertions(+), 0 deletions(-)
Signature · 1 line
1.7.2.5
PATCH 1/4 bnx2x: advertise transmit time stamping
This driver now offers software transmit time stamping, so it should advertise that fact via ethtool. Compile tested only.
--- .../net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c +1 -0
@@ -2978,6 +2978,7 @@ static const struct ethtool_ops bnx2x_ethtool_ops = { .get_module_eeprom = bnx2x_get_module_eeprom, .get_eee = bnx2x_get_eee, .set_eee = bnx2x_set_eee, + .get_ts_info = ethtool_op_get_ts_info, };void bnx2x_set_ethtool_ops (struct net_device *netdev)
Signature · 1 line
1.7.2.5
Re: [PATCH net-next 1/4] bnx2x: advertise transmit time stamping
Quoted 6 lines · Richard Cochran
This driver now offers software transmit time stamping, so it should advertise that fact via ethtool. Compile tested only.
Signed-off-by Richard Cochran <[email protected]>Cc Eilon Greenstein <[email protected]>Cc Willem de Bruijn <[email protected]>
Thanks Richard. I was sure it was sent upstream weeks ago, but I see it is somehow still pending to be sent. Thanks for catching it.
PATCH 1/4 bnx2x: advertise transmit time stamping
In reply to Richard CochranThis driver now offers software transmit time stamping, so it should advertise that fact via ethtool. Compile tested only.
--- .../net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c +1 -0
@@ -2978,6 +2978,7 @@ static const struct ethtool_ops bnx2x_ethtool_ops = { .get_module_eeprom = bnx2x_get_module_eeprom, .get_eee = bnx2x_get_eee, .set_eee = bnx2x_set_eee, + .get_ts_info = ethtool_op_get_ts_info, };void bnx2x_set_ethtool_ops (struct net_device *netdev)
Signature · 1 line
1.7.2.5
PATCH 2/4 e1000: advertise transmit time stamping
In reply to Richard CochranThis driver now offers software transmit time stamping, so it should advertise that fact via ethtool. Compile tested only.
--- drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/ethernet/intel/e1000/e1000_ethtool.c +1 -0
@@ -1851,6 +1851,7 @@ static const struct ethtool_ops e1000_ethtool_ops = { .get_sset_count = e1000_get_sset_count, .get_coalesce = e1000_get_coalesce, .set_coalesce = e1000_set_coalesce, + .get_ts_info = ethtool_op_get_ts_info, };void e1000_set_ethtool_ops (struct net_device *netdev)
Signature · 1 line
1.7.2.5
Re: [PATCH net-next 2/4] e1000: advertise transmit time stamping
Quoted 11 lines · Richard Cochran
This driver now offers software transmit time stamping, so it should advertise that fact via ethtool. Compile tested only.
Signed-off-by Richard Cochran <[email protected]>--- drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
PATCH 2/4 e1000: advertise transmit time stamping
In reply to Richard CochranThis driver now offers software transmit time stamping, so it should advertise that fact via ethtool. Compile tested only.
--- drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/ethernet/intel/e1000/e1000_ethtool.c +1 -0
@@ -1851,6 +1851,7 @@ static const struct ethtool_ops e1000_ethtool_ops = { .get_sset_count = e1000_get_sset_count, .get_coalesce = e1000_get_coalesce, .set_coalesce = e1000_set_coalesce, + .get_ts_info = ethtool_op_get_ts_info, };void e1000_set_ethtool_ops (struct net_device *netdev)
Signature · 1 line
1.7.2.5
cover Tx time stamp advertising for four drivers
In reply to Richard CochranSorry, wrong list, was meant for netdev. Please ignore.
Thanks,
Richard
PATCH 3/4 e1000e: advertise transmit time stamping
In reply to Richard CochranThis driver now offers software transmit time stamping, so it should advertise that fact via ethtool. Compile tested only.
--- drivers/net/ethernet/intel/e1000e/ethtool.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/ethernet/intel/e1000e/ethtool.c +1 -0
@@ -2061,6 +2061,7 @@ static const struct ethtool_ops e1000_ethtool_ops = { .get_coalesce = e1000_get_coalesce, .set_coalesce = e1000_set_coalesce, .get_rxnfc = e1000_get_rxnfc, + .get_ts_info = ethtool_op_get_ts_info, };void e1000e_set_ethtool_ops (struct net_device *netdev)
Signature · 1 line
1.7.2.5
Re: [PATCH net-next 3/4] e1000e: advertise transmit time stamping
Quoted 11 lines · Richard Cochran
This driver now offers software transmit time stamping, so it should advertise that fact via ethtool. Compile tested only.
Signed-off-by Richard Cochran <[email protected]>--- drivers/net/ethernet/intel/e1000e/ethtool.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
RE: [E1000-devel] [PATCH net-next 3/4] e1000e: advertise transmit time stamping
In reply to Richard CochranQuoted 33 lines
-----Original Message-----
From: Richard Cochran [mailto:[email protected]]
Sent: Sunday, July 22, 2012 10:16 AM
To: [email protected]
Cc: [email protected]; Willem de Bruijn; David Miller
Subject: [E1000-devel] [PATCH net-next 3/4] e1000e: advertise transmit time stampingThis driver now offers software transmit time stamping, so it should advertise that fact via ethtool. Compile tested only.
Signed-off-by Richard Cochran <[email protected]>--- drivers/net/ethernet/intel/e1000e/ethtool.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)drivers/net/ethernet/intel/e1000e/ethtool.c +1
-0@@ -2061,6 +2061,7 @@ static const struct ethtool_ops e1000_ethtool_ops = { .get_coalesce = e1000_get_coalesce, .set_coalesce = e1000_set_coalesce, .get_rxnfc = e1000_get_rxnfc, + .get_ts_info = ethtool_op_get_ts_info, };
Quoted 1 line
void
e1000e_set_ethtool_ops(struct net_device *netdev)
Thanks Richard. I have a similar patch amongst the PTP 1588 work I'm currently doing for e1000e, but this one is good for now.
PATCH 3/4 e1000e: advertise transmit time stamping
In reply to Richard CochranThis driver now offers software transmit time stamping, so it should advertise that fact via ethtool. Compile tested only.
--- drivers/net/ethernet/intel/e1000e/ethtool.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/ethernet/intel/e1000e/ethtool.c +1 -0
@@ -2061,6 +2061,7 @@ static const struct ethtool_ops e1000_ethtool_ops = { .get_coalesce = e1000_get_coalesce, .set_coalesce = e1000_set_coalesce, .get_rxnfc = e1000_get_rxnfc, + .get_ts_info = ethtool_op_get_ts_info, };void e1000e_set_ethtool_ops (struct net_device *netdev)
Signature · 1 line
1.7.2.5
PATCH 4/4 forcedeth: advertise transmit time stamping
In reply to Richard CochranThis driver now offers software transmit time stamping, so it should advertise that fact via ethtool. Compile tested only.
--- drivers/net/ethernet/nvidia/forcedeth.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/ethernet/nvidia/forcedeth.c +1 -0
@@ -5182,6 +5182,7 @@ static const struct ethtool_ops ops = { .get_ethtool_stats = nv_get_ethtool_stats, .get_sset_count = nv_get_sset_count, .self_test = nv_self_test, + .get_ts_info = ethtool_op_get_ts_info, };/* The mgmt unit and driver use a semaphore to access the phy during init */
Signature · 1 line
1.7.2.5
Re: [PATCH net-next 4/4] forcedeth: advertise transmit time stamping
Quoted 4 lines · Richard Cochran
This driver now offers software transmit time stamping, so it should advertise that fact via ethtool. Compile tested only.
Signed-off-by Richard Cochran <[email protected]>
Quoted 20 lines
Cc Willem de Bruijn <[email protected]>--- drivers/net/ethernet/nvidia/forcedeth.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)drivers/net/ethernet/nvidia/forcedeth.c +1
-1@@ -5182,6 +5182,7 @@ static const struct ethtool_ops ops = { .get_ethtool_stats = nv_get_ethtool_stats, .get_sset_count = nv_get_sset_count, .self_test = nv_self_test, + .get_ts_info = ethtool_op_get_ts_info, };/* The mgmt unit and driver use a semaphore to access the phy during init */ --1.7.2.5
PATCH 4/4 forcedeth: advertise transmit time stamping
In reply to Richard CochranThis driver now offers software transmit time stamping, so it should advertise that fact via ethtool. Compile tested only.
--- drivers/net/ethernet/nvidia/forcedeth.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/ethernet/nvidia/forcedeth.c +1 -0
@@ -5182,6 +5182,7 @@ static const struct ethtool_ops ops = { .get_ethtool_stats = nv_get_ethtool_stats, .get_sset_count = nv_get_sset_count, .self_test = nv_self_test, + .get_ts_info = ethtool_op_get_ts_info, };/* The mgmt unit and driver use a semaphore to access the phy during init */
Signature · 1 line
1.7.2.5
David Miller
maintainerFrom: Richard Cochran <[email protected]>
Date: Sun, 22 Jul 2012 19:15:38 +0200
Quoted 3 lines
This series updates the ethtool code for four drivers that recently add the
skb_tx_timestamphook. Since these drivers now support software transmit time stamps, let us also advertise this via ethtool.
Series applied, thanks.